[Skills] Fix bunx error on windows#27517
Conversation
|
Thank you for your contribution! 🎉 🔔 @keito4 @raulgg @pernielsentikaer @kayotimoteo you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="skills-fix-windows-bunx-fallback"
FORK_URL="https://github.com/DaleSeo/extensions.git"
EXTENSION_NAME="skills"
REPO_NAME="extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
Greptile SummaryThis PR fixes the Confidence Score: 5/5Safe to merge; only issue is a minor changelog date convention. The logic change is small, targeted, and correct. The only finding is a P2 style nit about using a hardcoded date in CHANGELOG.md instead of extensions/skills/CHANGELOG.md — needs Important Files Changed
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
extensions/skills/CHANGELOG.md:3
**Use `{PR_MERGE_DATE}` placeholder instead of a hardcoded date**
The Raycast changelog convention requires using `{PR_MERGE_DATE}` for the top (unreleased) entry so the merge date is substituted automatically. Using a literal date like `2026-04-30` bypasses that mechanism and may be wrong if the PR merges on a different day.
```suggestion
## [Fix Windows bunx Fallback] - {PR_MERGE_DATE}
```
Reviews (2): Last reviewed commit: "Update CHANGELOG.md" | Re-trigger Greptile |
raulgg
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for the fix!
|
Thank you for the fix @DaleSeo! I just realized now about the change to include Not to be tackled in this PR, but here are some thoughts: #27445 stated that Additionally, the errors now can feel like they push Regardless, that's unrelated to the current fix, which I already approved. I just wanted to engage in some discussion over those concerns. |
|
@raulgg Thanks for sharing your thoughts. One thing worth flagging on reversing the fallback chain is that most users who have |
0xdhrv
left a comment
There was a problem hiding this comment.
Looks good to me, approved ✅
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Fixes #27509.
The Skills extension is supposed to try
bunxfirst and then silently switch tonpxif Bun isn't installed. However, on Windows, the fallback never happened. The shell-escape helper wraps every argument in double quotes forcmd.exe, so whenbunxis missing, the error shows up as'"bunx"' is not recognized as an internal or external command. But the resolution-failure matcher only checked for the unquoted version, which is'bunx' is not recognized..., so the error went to the user instead of triggering thenpxfallback. This change adds the cmd.exe-quoted version to the matcher, ensuring the fallback works as it should.Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool