Skip to content

💄 Refined the paginator#135

Open
ckersey2 wants to merge 4 commits into
raycharius:mainfrom
ckersey2:main
Open

💄 Refined the paginator#135
ckersey2 wants to merge 4 commits into
raycharius:mainfrom
ckersey2:main

Conversation

@ckersey2
Copy link
Copy Markdown
Contributor

@ckersey2 ckersey2 commented Jul 19, 2024

💄 Refined the paginator
Updated the pagination actions buttons
If we are on the first page of the data, the "Previous" button is not shown.
If we are on the last page of the data, the "Next" button is not shown.

@ckersey2 ckersey2 changed the title Main Hide Previous and Next buttons when they are not needed in the Paginator Jul 19, 2024
@ckersey2 ckersey2 changed the title Hide Previous and Next buttons when they are not needed in the Paginator 🚜Hide Previous and Next buttons when they are not needed in the Paginator Jul 19, 2024
@ckersey2 ckersey2 changed the title 🚜Hide Previous and Next buttons when they are not needed in the Paginator 🚜Hide previous and next buttons when they are not needed in the paginator Jul 19, 2024
Copy link
Copy Markdown
Contributor Author

@ckersey2 ckersey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small tweek.

@ckersey2 ckersey2 changed the title 🚜Hide previous and next buttons when they are not needed in the paginator ✨ Add new feature for pagination Jul 20, 2024
If we are on the first page of the data, the "Previous" button is not shown.
If we are on the last page of the data, the "Next" button is not shown.

I've updated the following tests:
- easy-paginator.spec.ts
- paginator.spec.ts

All tests pass.
@ckersey2 ckersey2 marked this pull request as ready for review July 24, 2024 02:52
@ckersey2 ckersey2 changed the title ✨ Add new feature for pagination 💄 Refined the Paginator Jul 24, 2024
@ckersey2 ckersey2 changed the title 💄 Refined the Paginator 💄 Refined the paginator Jul 24, 2024
@ckersey2 ckersey2 closed this Jul 24, 2024
@ckersey2 ckersey2 reopened this Nov 7, 2024
james-gre added a commit to ExodusForks/slack-block-builder that referenced this pull request Jan 27, 2026
…rius#135)

- Hide Previous button on first page
- Hide Next button on last page
- Updated tests to reflect new behavior

Implements upstream PR raycharius#135 by @ckersey2
james-gre added a commit to ExodusForks/slack-block-builder that referenced this pull request Jan 27, 2026
* chore: bump version to 2.9.4

* feat(paginator): hide prev/next buttons at page boundaries (PR raycharius#135)

- Hide Previous button on first page
- Hide Next button on last page
- Updated tests to reflect new behavior

Implements upstream PR raycharius#135 by @ckersey2

* feat(timepicker): add timezone support (Issue raycharius#137)

- Add Timezone method mixin
- Add timezone prop constant
- Add timezone to TimePickerBuilder interface
- Add timezone to TimePickerParams

Implements upstream Issue raycharius#137 by @melchii

* chore: bump version to 2.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant