Skip to content

Conversation

@ilijapuaca
Copy link
Contributor

In both skip and generate, we need access to cookie in order to involve the auth token in our rate limiting logic, which currently gets stripped away before being passed into skip and generate

Not sure whether the typing here is the best, and whether there's a reason for cookie alongside other properties not being passed in as perhaps I'm overlooking something, but I'd assume people would want all the info from their request being available in these functions

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 15, 2025

Open in StackBlitz

npm i https://pkg.pr.new/rayriffy/elysia-rate-limit@61

commit: 250831a

Copy link
Owner

@rayriffy rayriffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please help run bun changeset and create a version change as patch update

@ilijapuaca
Copy link
Contributor Author

please help run bun changeset and create a version change as patch update

Done

@rayriffy rayriffy merged commit 8d5fd0d into rayriffy:main Oct 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants