Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking about #4878 , in the solution I had to call
rlSetTexture
before everyrlBegin
, therefore I though that they should merge into one call and avoid problems in the future, so I createdrlStartBatch
.I think that if I use
rlBegin
I would forgetrlSetTexture
, that's why I createdrlStartBatch
, so I don't forget to set both mode and textureId.rlEndBatch
only exists because sometimes there are calls torlSetTexture(0)
(maybe merge withrlEnd()
?).I tested bunnymark in RenderDoc, it looks fine (60 fps with max objects).
So, two options
rlSetTexture/rlBegin
togetherrlStartBatch
and maybe deprecaterlSetTexture/rlBegin
in the future...