-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
C++ compiler support v2 #5252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
C++ compiler support v2 #5252
Conversation
@sakgoyal Added some review comments, just noticed that most are already listed on the TODO. Please, let me know when ready to merge. Thanks! |
I don't want to update some of the dependencies. Many of them seem to introduce breaking changes that need more work to get working again that feels out of scope for this PR. All workflows passed: |
@sakgoyal added some minor tweaks to review |
There could be another CI action for checking formatting (NOT a commit hook). It would reduce a lot of back and forth. |
@sakgoyal sure! but it needs to be coded! |
Redoing #5232 because I messed up the force push.
Allow C++ compilers to compile this code without separately linking as a C library.
Changes:
TODO:
jar_*
is ok to update. Managed by raysan5= {0}
-ftrivial-auto-var-init=zero
or something instead