Skip to content

Conversation

sakgoyal
Copy link

@sakgoyal sakgoyal commented Oct 9, 2025

Redoing #5232 because I messed up the force push.

Allow C++ compilers to compile this code without separately linking as a C library.

Changes:

  • Backport RGFW unicode fix
  • Add C-style casting where necessary
  • Fix a initializer list being in the wrong order (C++ requires declaration order)
  • GLFW currently has issues with cross compiling so I am using RGFW for now
  • Change C Aggregate initializer to C++ default initializer.

TODO:

  • Do not modify external libraries. update them instead
    • jar_* is ok to update. Managed by raysan5
  • C++ = {0}
    • maybe consider -ftrivial-auto-var-init=zero or something instead

@raysan5
Copy link
Owner

raysan5 commented Oct 14, 2025

@sakgoyal Added some review comments, just noticed that most are already listed on the TODO. Please, let me know when ready to merge. Thanks!

@sakgoyal sakgoyal marked this pull request as ready for review October 14, 2025 15:58
@sakgoyal
Copy link
Author

sakgoyal commented Oct 14, 2025

I don't want to update some of the dependencies. Many of them seem to introduce breaking changes that need more work to get working again that feels out of scope for this PR.

All workflows passed:
https://github.com/sakgoyal/raylib/actions

@raysan5
Copy link
Owner

raysan5 commented Oct 14, 2025

@sakgoyal added some minor tweaks to review

@sakgoyal
Copy link
Author

There could be another CI action for checking formatting (NOT a commit hook).

It would reduce a lot of back and forth.

@raysan5
Copy link
Owner

raysan5 commented Oct 14, 2025

@sakgoyal sure! but it needs to be coded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants