Add tests #5
Draft
Add tests #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though the gem will support non-Rails applications, I have decided to use the `:rails` profile in SimpleCov as this was the easiest way to ensure that the correct files were added to the code coverage statistics.
This is a Rails method [1] used in the Base class. In order to support non-rails applications, it's necessary to monkeypatch the Hash class. [1]: https://apidock.com/rails/v5.2.3/Hash/transform_values
This commit adds a test to ensure that a new Message instance is created when the `Base#mail` method is called. In order to do this, it was necessary to add a new private method to the Base class as the `instance_variable_names` method called is a Rails-only method [1] and so would have raised an exception in a non-Rails application. [1]: https://apidock.com/rails/v5.2.3/Object/instance_variable_names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1
WIP - Adding tests to the gem