Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(blade): add Breadcrumb API #2027

Merged
merged 6 commits into from
Feb 28, 2024
Merged

docs(blade): add Breadcrumb API #2027

merged 6 commits into from
Feb 28, 2024

Conversation

anuraghazra
Copy link
Member

@anuraghazra anuraghazra commented Feb 19, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f9e8c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 19, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9f9e8c8:

Sandbox Source
razorpay/blade: basic Configuration

@anuraghazra anuraghazra added the Review - L1 First level of review label Feb 19, 2024
saurabhdaware
saurabhdaware reviewed Feb 20, 2024
View reviewed changes
packages/blade/src/components/Breadcrumb/_decisions/decisions.md Outdated
return (
<Box>
<Breadcrumb showLastSeparator marginBottom="spacing.3">
<BreadcrumbItem href="/">Home</BreadcrumbItem>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add icon as well to these examples? like we have in first figma image?

@anuraghazra anuraghazra marked this pull request as ready for review February 21, 2024 10:39
Rozamo
Rozamo reviewed Feb 22, 2024
View reviewed changes
packages/blade/src/components/Breadcrumb/_decisions/decisions.md Outdated
/**
* Content of the BreadcrumbItem
*/
children: string;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the design there can be cases where the first item shows only an icon. Can we make this optional in case icon prop is supplied?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this will be optional. I'll change this.

@anuraghazra anuraghazra merged commit 58aae51 into master Feb 28, 2024
14 checks passed
@anuraghazra anuraghazra deleted the anu/breadcrumb-api branch February 28, 2024 05:39
pcprashant
pcprashant reviewed Mar 11, 2024
View reviewed changes
Copy link

@pcprashant pcprashant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anuraghazra added a commit that referenced this pull request Apr 9, 2024
@anuraghazra
docs(blade): add Breadcrumb API (#2027)
80e9665 
* chore: add breadcrumb api

* chore: update

* chore: update

* chore: update

* chore: update images

* chore: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcprashant pcprashant pcprashant left review comments

@saurabhdaware saurabhdaware saurabhdaware left review comments

@Rozamo Rozamo Rozamo left review comments

@snitin315 snitin315 snitin315 left review comments

@chaitanyadeorukhkar chaitanyadeorukhkar chaitanyadeorukhkar approved these changes

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani kamleshchandnani is a code owner

Assignees

@chaitanyadeorukhkar chaitanyadeorukhkar

Labels
API Decisions Review - L1 First level of review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anuraghazra @pcprashant @chaitanyadeorukhkar @saurabhdaware @Rozamo @snitin315