Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(FileUpload): add E2E & unit test cases #2040

Merged
merged 11 commits into from
Feb 28, 2024
Merged

test(FileUpload): add E2E & unit test cases #2040

merged 11 commits into from
Feb 28, 2024

Conversation

snitin315
Copy link
Member

Tests for FileUPload.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: eb8ec73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 22, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb8ec73:

Sandbox Source
razorpay/blade: basic Configuration

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 22, 2024 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@snitin315 snitin315 marked this pull request as ready for review February 23, 2024 05:31
@snitin315 snitin315 added the Review - L1 First level of review label Feb 23, 2024
@snitin315 snitin315 mentioned this pull request Feb 28, 2024
Merged
saurabhdaware
saurabhdaware approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@saurabhdaware saurabhdaware left a comment •
edited by snitin315
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Small TODOs before merging

  • The validity check is failing in this PR. Do check that once.
  • Do run E2E tests on other browsers once

@saurabhdaware saurabhdaware added Review - L2 Second level of review and removed Review - L1 First level of review labels Feb 28, 2024
@snitin315 snitin315 mentioned this pull request Feb 28, 2024
Merged
8 tasks
@snitin315 snitin315 merged commit e126797 into feat/add-file-upload Feb 28, 2024
13 of 14 checks passed
@snitin315 snitin315 deleted the tests/file-upload branch February 28, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhdaware saurabhdaware saurabhdaware approved these changes

@anuraghazra anuraghazra anuraghazra approved these changes

@chaitanyadeorukhkar chaitanyadeorukhkar Awaiting requested review from chaitanyadeorukhkar

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani

Assignees

@saurabhdaware saurabhdaware

Labels
Review - L2 Second level of review Run Interaction Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snitin315 @saurabhdaware @anuraghazra