Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: multiple docs UI fixes and unpkg installation link in installation guide #2041

Merged
merged 8 commits into from
Feb 23, 2024
Merged

docs: multiple docs UI fixes and unpkg installation link in installation guide #2041

merged 8 commits into from
Feb 23, 2024

Conversation

saurabhdaware
Copy link
Member

@saurabhdaware saurabhdaware commented Feb 23, 2024 •
edited
Loading

Description

Multiple changes in documentation. These include small and large UI fixes and enhancements

Changes

  • Add unpkg link to font installation as discussed last time in Font CDN Exploration Doc
    image
  • Replace the table in documentation pages like Modal, Dropdown with our Table component to improve consistency
    image image
  • Replace all the old tokens from v10 to new v11 tokens (few were missed during rebranding)
  • UI fixes of codesandbox code (storybook was overriding it with weird font)
    image image
  • Add new intro section with RK's video
    image
  • Figma Community Link added to Links section
  • Removed the section that explained how to turn color tokens from Surface / Feedback / Positive notation to dot notation since its not relevant anymore

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ef429c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 23, 2024 •
edited
Loading

✅ PR title follows Conventional Commits specification.

snitin315
snitin315 previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, did you run the codemod for updating tokens?

:shipit:

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 23, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ef429c5:

Sandbox Source
razorpay/blade: basic Configuration

@saurabhdaware
Copy link
Member Author

Nice, did you run the codemod for updating tokens?

Nope did a find and replace for now since at few places only

@saurabhdaware saurabhdaware added the Review - L2 Second level of review label Feb 23, 2024
chaitanyadeorukhkar
chaitanyadeorukhkar reviewed Feb 23, 2024
View reviewed changes
packages/blade/docs/guides/Intro.stories.mdx
@@ -40,6 +55,7 @@ Blade is the Design System that powers [Razorpay](https://razorpay.com/)
## 🔗 Links

- [Docs](https://blade.razorpay.com)
- [Figma Library](https://www.figma.com/community/file/1341658976127676210)
- [Installation](https://blade.razorpay.com/?path=/docs/guides-installation--page)
- [@razorpay/blade-old](https://github.com/razorpay/blade-old) (Deprecated, Private)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add github link to new blade too?

@saurabhdaware saurabhdaware merged commit 9812ec5 into master Feb 23, 2024
15 checks passed
@saurabhdaware saurabhdaware deleted the docs/fixes-and-font branch February 23, 2024 09:06
@saurabhdaware saurabhdaware mentioned this pull request Feb 23, 2024
Merged
5 tasks
anuraghazra pushed a commit that referenced this pull request Apr 9, 2024
@saurabhdaware @snitin315
docs: multiple docs UI fixes and unpkg installation link in installat…
fbb4b84 
…ion guide (#2041)

* docs: fixes for old tokens, replace ArgsTable with internal table

* fix: layout primitives fonts

* feat: add link rel installation for no bundler tools

* fix: remove commented code

* fix: Badge prop

* Update packages/blade/docs/guides/Installation.stories.mdx

Co-authored-by: Nitin Kumar <[email protected]>

* Update packages/blade/docs/guides/Installation.stories.mdx

Co-authored-by: Nitin Kumar <[email protected]>

* Update packages/blade/docs/guides/Usage.stories.mdx

Co-authored-by: Nitin Kumar <[email protected]>

---------

Co-authored-by: Nitin Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyadeorukhkar chaitanyadeorukhkar chaitanyadeorukhkar approved these changes

@snitin315 snitin315 snitin315 approved these changes

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani kamleshchandnani is a code owner

@anuraghazra anuraghazra Awaiting requested review from anuraghazra anuraghazra is a code owner

Assignees

@chaitanyadeorukhkar chaitanyadeorukhkar

Labels
Review - L2 Second level of review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saurabhdaware @chaitanyadeorukhkar @snitin315