Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextArea): expose onKeydown on TextArea #2532

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Conversation

saurabhdaware
Copy link
Member

@saurabhdaware saurabhdaware commented Feb 7, 2025

Description

  • add numberOfLines={1}
  • expose onKeyDown on TextArea.

onKeyDown will be exposed with these arg type-

onKeyDown={(args) => 
  args.name
  args.value
  args.event
}

Currently other handlers of TextArea expose name and value so it feels inconsistent to have one handler that exposes just event. So using the same type that we internally also use where we append event on top of existing name and value

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: dc2486c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 7, 2025

✅ PR title follows Conventional Commits specification.

@saurabhdaware saurabhdaware added the P0 Critical label Feb 7, 2025
Copy link

codesandbox-ci bot commented Feb 7, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc2486c:

Sandbox Source
razorpay/blade: basic Configuration

anuraghazra
anuraghazra previously approved these changes Feb 7, 2025
@@ -244,6 +246,7 @@ const _TextArea: React.ForwardRefRenderFunction<BladeElementRef, TextAreaProps>
}}
onKeyDown={(e) => {
handleTaggedInputKeydown(e);
onKeyDown?.(e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's e here? {name, value, event}???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{name, value, event}???

I'm fixing it. I just realised its {name, key, event}. We can make it { name, value, event }

@rzpcibot
Copy link
Collaborator

rzpcibot commented Feb 7, 2025

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
Counter 0.849 0.851 +0.002 KB
TextArea 32.685 32.722 +0.037 KB

Generated by 🚫 dangerJS against dc2486c

snitin315
snitin315 previously approved these changes Feb 7, 2025
@saurabhdaware saurabhdaware dismissed stale reviews from snitin315 and anuraghazra via dc2486c February 7, 2025 07:57
@snitin315 snitin315 merged commit 142afcd into master Feb 7, 2025
12 of 14 checks passed
@snitin315 snitin315 deleted the feat/expose-onkeydown branch February 7, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants