-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TextArea): expose onKeydown on TextArea #2532
Conversation
🦋 Changeset detectedLatest commit: dc2486c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ PR title follows Conventional Commits specification. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dc2486c:
|
@@ -244,6 +246,7 @@ const _TextArea: React.ForwardRefRenderFunction<BladeElementRef, TextAreaProps> | |||
}} | |||
onKeyDown={(e) => { | |||
handleTaggedInputKeydown(e); | |||
onKeyDown?.(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's e here? {name, value, event}???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{name, value, event}???
I'm fixing it. I just realised its {name, key, event}
. We can make it { name, value, event }
…o feat/expose-onkeydown
dc2486c
Description
numberOfLines={1}
onKeyDown
on TextArea.onKeyDown will be exposed with these arg type-
Currently other handlers of TextArea expose name and value so it feels inconsistent to have one handler that exposes just event. So using the same type that we internally also use where we append event on top of existing name and value
Changes
Additional Information
Component Checklist