feat(tokens): add motion.easing.settle - #3884
Open
annamalailakshmann wants to merge 2 commits into
Open
Conversation
annamalailakshmann
requested review from
anuraghazra,
kamleshchandnani,
ravikumar-rajagopalan,
rohankokane-dev,
saurabhdaware,
saurav12 and
swapnil-kr1
as code owners
August 14, 2026 17:46
🦋 Changeset detectedLatest commit: 4d0ffd4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
🤖 Slash AI Review has been triggered. View execution logs |
5 tasks
Contributor
|
(Review Cancelled - Superseded by a new run) |
![rzp-slash[bot]](https://avatars.githubusercontent.com/u/7713209?s=60&v=4){kind=small}
| exit: Easing.bezier(0.17, 0, 1, 1), | ||
| standard: Easing.bezier(0.3, 0, 0.2, 1), | ||
| emphasized: Easing.bezier(0.5, 0, 0, 1), | ||
| settle: Easing.bezier(0.32, 0.72, 0, 1), |
Contributor
There was a problem hiding this comment.
🟠 [MAJOR] · code-quality-critique · confidence: 9/10
Problem: Native theme snapshot not regenerated — settle easing entry is missing from createTheme.native.test.tsx.snap (both easing blocks at lines ~1533 and ~3675), while the web snapshot was correctly updated. Native createTheme tests will fail.
Suggestion: Run yarn test:react-native -u (or manually add "settle": "0.32 0.72 0 1" after each "overshoot" entry in the native snapshot) to regenerate the native snapshot.
annamalailakshmann
force-pushed
the
feat/motion-settle-easing
branch
from
August 14, 2026 18:23
9636485 to
2d502ea
Compare
Contributor
|
(Review Cancelled - Superseded by a new run) |
Collaborator
🛡️ Coverage ReportSummaryFull Coverage Details |
Contributor
There was a problem hiding this comment.
✨ Agentic PR Review ✨
Status: Approved ✅
UI Review
Usage
import { useTheme } from '@razorpay/blade';
const { theme } = useTheme();
// Access the new easing token
theme.motion.easing.settle; // 'cubic-bezier(0.32, 0.72, 0, 1)' on web, EasingFactoryFn on native
![rzp-slash[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Co-authored-by: admin <admin>
Contributor
|
🤖 Slash AI Review has been triggered. View execution logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds one easing curve,
motion.easing.settle—cubic-bezier(0.32, 0.72, 0, 1).For surfaces that grow, reflow, or settle into place: a composer expanding, a bar entering, chips reflowing. It leaves quickly and decelerates hard into its final position, which is what makes a resize read as arriving somewhere rather than easing to a stop.
Groundwork only — nothing in this PR consumes it. Kept separate because both
ChatComposerandChatFeedbackwant it, so it shouldn't sit behind either component's review.Changes
motion.easing.settleon the global motion tokensbladeLightTheme.native.tsregeneratedAdditional Information
Second of a stack of four. Based on #3883 for a clean diff; it has no logical dependency on it and can be retargeted to
masterif #3883 lands first.Component Checklist
🤖 Generated with Claude Code