fix(blade-svelte): Button story controls + neutral focus ring - #3937
Merged
Conversation
🦋 Changeset detectedLatest commit: 1bbf64c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
(Review Cancelled - Superseded by a new run) |
rohankokane-dev
enabled auto-merge (squash)
August 27, 2026 13:07
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🤖 Slash AI Review has been triggered. View execution logs |
Collaborator
🛡️ Coverage ReportSummaryFull Coverage Details |
![rzp-slash[bot]](https://avatars.githubusercontent.com/u/7713209?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✨ Agentic PR Review ✨
UI Review
✅ 12 passed
Passing checks (12)
swapnil-kr1
approved these changes
Aug 27, 2026
Contributor
There was a problem hiding this comment.
✨ Agentic PR Review ✨
Status: Approved ✅
UI Review
✅ 15 passed
Passing checks (15)
rzp-slash-public
Bot
added
the
rcore:eligible-for-auto-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asChilddemos ("With Icon Left/Right", "Icon Only", "Avatar Group With Icon") converted to args-driven stories; missingaccessibilityLabelcontrol added.variant/colorcontrols disabled viaargTypeson "Definite Loading Variants" since each button hardcodes its own.IconButton.stories.svelte'scontext="module"tomodule, added missingisDisabled/isHighlighteddefaults.--surface-border-primary-muted) with primary/positive/negative via a compound selector. Added a higher-specificity override socolor="neutral"uses--interactive-border-neutral-fadedinstead, without touching the shared outline/inset-border declarations.Test plan
svelte-autofixer(desired_svelte_version: 5) on both edited story files: 0 issuesyarn svelte-check(blade-svelte): 0 errors, no new warningsyarn test(blade-core): 67/67 pass