Skip to content

feat(geo): add getStatesByZipCode export to geo module [ROW-574]#232

Merged
RgnDunes merged 7 commits intomasterfrom
feat/getStatesByZipCode-api
Apr 1, 2025
Merged

feat(geo): add getStatesByZipCode export to geo module [ROW-574]#232
RgnDunes merged 7 commits intomasterfrom
feat/getStatesByZipCode-api

Conversation

@RgnDunes
Copy link

Description

This function makes a network request to central i18nify-data source and returns a promise for the state name that contains the provided zipcode. If a country code is provided, it will only search in that country, otherwise it will search across all supported countries.

Changes Made

List the main changes made in this pull request.

Title ---
JIRA link https://razorpay.atlassian.net/browse/ROW-574
Slack thread (if any) NA
Product spec NA
Tech spec/One-pager NA
Bundle Size Difference NA
Fixes Issue NA

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Is your change backward compatible ?
  • Tested on major browsers (Chrome, Firefox, Safari, IE) ?
  • Tested in a consumer application(s) ?

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

  • Add Jira ID(s) in PR title and in the description?
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code is written in TypeScript and follows the coding standards of the project.
  • I have added relevant documentation and updated the README if necessary.
  • My commit messages are clear and follow the project's commit message conventions.
  • Is any external library added?
  • My changes do not introduce any new runtime errors or warnings.
  • All relevant unit tests have been added/updated in my PR for the change.
  • Any Screenshots (mobile & desktop) required for PR? If yes, have you added the respective screenshots ?
  • Any manual dev testing done by you on beta/func environment?
  • Reviewer added (SLA 2 days)

Reviewer Checklist

  • Sufficient QA/Dev-Testing is done with proof (test cases list)
  • Ensure that the change in bundle size falls within the acceptable range.

PR Title Format

Format: <type>: <subject>

Types can be as follows:

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2025

🦋 Changeset detected

Latest commit: 061f1c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/i18nify-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RgnDunes RgnDunes requested a review from sudeepgumaste March 28, 2025 19:07
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (d8de170) to head (061f1c4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   99.76%   99.77%   +0.01%     
==========================================
  Files          59       60       +1     
  Lines         851      892      +41     
  Branches      198      210      +12     
==========================================
+ Hits          849      890      +41     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rzpcibot
Copy link
Contributor

rzpcibot commented Mar 28, 2025

Warnings
⚠️

this getStatesByZipCode.test.ts has over 600 lines of code additions 😱 . Try to breakup into separate functions/components 👍

Bundle Size Report

Files

click to expand/collapse
🟢 No Change 🗑 File Deleted 🆕 New File 📈 Size Increased 👍 Size Reduced
Parsed (kb)
🚦 File Name Base PR Diff %
📈 cjs/index.js 171.56 175.44 $\textcolor{red}{3.88}$ 2.26
📈 esm/index.min.js 65.18 66.33 $\textcolor{red}{1.15}$ 1.76
📈 umd/index.js 193.92 198.13 $\textcolor{red}{4.21}$ 2.17

Generated by 🚫 dangerJS against 061f1c4

@RgnDunes RgnDunes merged commit 98d1f5e into master Apr 1, 2025
15 checks passed
@RgnDunes RgnDunes deleted the feat/getStatesByZipCode-api branch April 1, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants