open method returns response data when completed#127
Open
vimalk29 wants to merge 1 commit intorazorpay:masterfrom
Open
open method returns response data when completed#127vimalk29 wants to merge 1 commit intorazorpay:masterfrom
vimalk29 wants to merge 1 commit intorazorpay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK only had the option to listen to the payment success and failure or external wallet.
However If one required to wait till the checkout is complete, there was no way of doing that.
With the new upgrade, It would be possible for developers to do so and still be able to listen to the callbacks.
One feature I wasn't sure of If is needed is in case developers wants to wait for the response, Should we give an extra option to emit it to the event listeners or not.
For eg. If in case listener is preferred in one situation and waiting for response is preferred for another, We can let the developer decide if they wants to emit the response to the listeners or not.