Conversation
ncw
left a comment
There was a problem hiding this comment.
Thanks for doing this - it seems like a very good approach. I hate the naming though Factory this that and the other is giving me Java flashbacks!
How about
- Rename
TempBlobFactoryto:MultipartBackend - Rename
TempBlobto:UploadPart
I've given this a quick review - can you write some tests for temp.go?
I'm going to run the CI now too - the linter will complain about lots of stuff you'll need to fix. It will also complain about security problems - please ignore these - I will fix those!
For sure I was not sure how to name them.
Yes I will do it.
Ok I will try to update this end of this WE |
|
Sorry for the late reply. I took your requests into account and made the uploader more generic so that we can have custom ones implemented in rclone. Feel free to comment my work. |
This is the first stone to solve :
rclone/rclone#7453
What is does:
Comments are appreciated