Skip to content

Fixed #issue-70 related to get_json_object functionality for hive-serde #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixed #issue-70 related to get_json_object functionality for hive-serde #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f642841
Fixed #issue-70 related to get_json_object functionality for string i…
May 27, 2014
e091e3d
Fixed formatting changes
May 28, 2014
4cbc614
Removed logging
Jun 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/org/openx/data/jsonserde/objectinspector/JsonObjectInspectorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector;
import org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector.PrimitiveCategory;
import org.apache.hadoop.hive.serde2.objectinspector.primitive.AbstractPrimitiveJavaObjectInspector;
Expand All @@ -29,6 +30,7 @@
import org.openx.data.jsonserde.objectinspector.primitive.JavaStringDoubleObjectInspector;
import org.openx.data.jsonserde.objectinspector.primitive.JavaStringFloatObjectInspector;
import org.openx.data.jsonserde.objectinspector.primitive.JavaStringIntObjectInspector;
import org.openx.data.jsonserde.objectinspector.primitive.JavaStringJsonObjectInspector;
import org.openx.data.jsonserde.objectinspector.primitive.JavaStringLongObjectInspector;
import org.openx.data.jsonserde.objectinspector.primitive.JavaStringShortObjectInspector;
import org.openx.data.jsonserde.objectinspector.primitive.JavaStringTimestampObjectInspector;
Expand Down Expand Up @@ -171,6 +173,7 @@ public static JsonMapObjectInspector getJsonMapObjectInspector(
= new EnumMap<PrimitiveCategory, AbstractPrimitiveJavaObjectInspector>(PrimitiveCategory.class);

static {
primitiveOICache.put(PrimitiveCategory.STRING, new JavaStringJsonObjectInspector());
primitiveOICache.put(PrimitiveCategory.BYTE, new JavaStringByteObjectInspector());
primitiveOICache.put(PrimitiveCategory.SHORT, new JavaStringShortObjectInspector());
primitiveOICache.put(PrimitiveCategory.INT, new JavaStringIntObjectInspector());
Expand Down
48 changes: 48 additions & 0 deletions ...ava/org/openx/data/jsonserde/objectinspector/primitive/JavaStringJsonObjectInspector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package org.openx.data.jsonserde.objectinspector.primitive;

import org.apache.hadoop.hive.serde2.objectinspector.primitive.AbstractPrimitiveJavaObjectInspector;
import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorUtils;
import org.apache.hadoop.hive.serde2.objectinspector.primitive.SettableStringObjectInspector;
import org.apache.hadoop.io.Text;
import org.apache.log4j.Logger;

public class JavaStringJsonObjectInspector extends AbstractPrimitiveJavaObjectInspector
implements
SettableStringObjectInspector {

Logger logger = Logger.getLogger(JavaStringJsonObjectInspector.class);

public JavaStringJsonObjectInspector() {
super(PrimitiveObjectInspectorUtils.stringTypeEntry);
}

@Override
public Text getPrimitiveWritableObject(Object o) {
return o == null ? null : new Text(((String) o.toString()));
}

@Override
public String getPrimitiveJavaObject(Object o) {
return o == null ? null : o.toString();
}

@Override
public Object create(Text value) {
return value == null ? null : value.toString();
}

@Override
public Object set(Object o, Text value) {
return value == null ? null : value.toString();
}

@Override
public Object create(String value) {
return value;
}

@Override
public Object set(Object o, String value) {
return value;
}
}
154 changes: 154 additions & 0 deletions src/test/java/org/openx/data/jsonserde/GetJsonObjectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,154 @@
package org.openx.data.jsonserde;

import static org.junit.Assert.*;

import java.util.Properties;

import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hive.ql.udf.UDFJson;
import org.apache.hadoop.hive.serde.Constants;
import org.apache.hadoop.hive.serde2.SerDeException;
import org.apache.hadoop.hive.serde2.objectinspector.ListObjectInspector;
import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
import org.apache.hadoop.hive.serde2.objectinspector.primitive.StringObjectInspector;
import org.apache.hadoop.io.Text;
import org.apache.hadoop.io.Writable;
import org.junit.Before;
import org.junit.Test;
import org.openx.data.jsonserde.json.JSONException;
import org.openx.data.jsonserde.json.JSONObject;

/**
* Tests getJson Object
*
* @author snagmote
*
*/
public class GetJsonObjectTest {

static JsonSerDe instance;

@Before
public void setUp() throws Exception {
initialize();
}

static public void initialize() throws Exception {
instance = new JsonSerDe();
Configuration conf = null;
Properties tbl = new Properties();
// from google video API
tbl.setProperty(Constants.LIST_COLUMNS, "kind,etag,pageInfo,v_items");
tbl.setProperty(
Constants.LIST_COLUMN_TYPES,
("string,string," + "string,"
+ "ARRAY<STRUCT<kind:STRING,"
+ "etag:STRING,"
+ "id:STRING,"
+ "v_statistics:STRUCT<viewCount:INT,likeCount:INT,dislikeCount:INT,favoriteCount:INT,commentCount:INT>,"
+ "topicDetails:STRUCT<topicIds:ARRAY<STRING>,relevantTopicIds:ARRAY<STRING>>"
+ ">>").toLowerCase());
tbl.setProperty("mapping.v_items", "items");
tbl.setProperty("mapping.v_statistics", "statistics");

instance.initialize(conf, tbl);
tbl.setProperty("mapping.v_items", "items");
tbl.setProperty("mapping.v_statistics", "statistics");

instance.initialize(conf, tbl);
}

@Test
public void testGetJsonObject() throws SerDeException, JSONException {
Writable w = new Text(
"{ \"kind\": \"youtube#videoListResponse\", \"etag\": \"\\\"79S54kzisD_9SOTfQLu_0TVQSpY/mYlS4-ghMGhc1wTFCwoQl3IYDZc\\\"\", \"pageInfo\": { \"totalResults\": 1, \"resultsPerPage\": 1 }, \"items\": [ { \"kind\": \"youtube#video\", \"etag\": \"\\\"79S54kzisD_9SOTfQLu_0TVQSpY/A4foLs-VO317Po_ulY6b5mSimZA\\\"\", \"id\": \"wHkPb68dxEw\", \"statistics\": { \"viewCount\": \"9211\", \"likeCount\": \"79\", \"dislikeCount\": \"11\", \"favoriteCount\": \"0\", \"commentCount\": \"29\" }, \"topicDetails\": { \"topicIds\": [ \"/m/02mjmr\" ], \"relevantTopicIds\": [ \"/m/0cnfvd\", \"/m/01jdpf\" ] } } ] }");

JSONObject result = (JSONObject) instance.deserialize(w);

StructObjectInspector soi = (StructObjectInspector) instance.getObjectInspector();

Object res = soi.getStructFieldData(result, soi.getStructFieldRef("pageinfo"));

StringObjectInspector loi = (StringObjectInspector) soi.getStructFieldRef("pageinfo")
.getFieldObjectInspector();

UDFJson udfJson = new UDFJson();
Text output = udfJson.evaluate(loi.getPrimitiveJavaObject(res), "$.totalresults");
assertEquals("1", output.toString());

}

@Test
public void testNestedGetJsonObject() throws SerDeException, JSONException {
Writable w = new Text(
"{ \"kind\": \"youtube#videoListResponse\", \"etag\": \"\\\"79S54kzisD_9SOTfQLu_0TVQSpY/mYlS4-ghMGhc1wTFCwoQl3IYDZc\\\"\", \"pageInfo\": { \"pagehit\":{ \"kind\": \"youtube#video\" } ,\"totalResults\": 1, \"resultsPerPage\": 1 }, \"items\": [ { \"kind\": \"youtube#video\", \"etag\": \"\\\"79S54kzisD_9SOTfQLu_0TVQSpY/A4foLs-VO317Po_ulY6b5mSimZA\\\"\", \"id\": \"wHkPb68dxEw\", \"statistics\": { \"viewCount\": \"9211\", \"likeCount\": \"79\", \"dislikeCount\": \"11\", \"favoriteCount\": \"0\", \"commentCount\": \"29\" }, \"topicDetails\": { \"topicIds\": [ \"/m/02mjmr\" ], \"relevantTopicIds\": [ \"/m/0cnfvd\", \"/m/01jdpf\" ] } } ] }");

StructObjectInspector soi = (StructObjectInspector) instance.getObjectInspector();
JSONObject result = (JSONObject) instance.deserialize(w);

Object res = soi.getStructFieldData(result, soi.getStructFieldRef("pageinfo"));

StringObjectInspector loi = (StringObjectInspector) soi.getStructFieldRef("pageinfo")
.getFieldObjectInspector();

UDFJson udfJson = new UDFJson();
Text output = udfJson.evaluate(loi.getPrimitiveJavaObject(res), "$.pagehit");
assertEquals("{\"kind\":\"youtube#video\"}", output.toString());
}

@Test
public void testStringWhenNotJson() throws SerDeException, JSONException {
Writable w = new Text(
"{ \"kind\": \"youtube#videoListResponse\", \"etag\": \"\\\"79S54kzisD_9SOTfQLu_0TVQSpY/mYlS4-ghMGhc1wTFCwoQl3IYDZc\\\"\", \"pageInfo\": \"page\", \"items\": [ { \"kind\": \"youtube#video\", \"etag\": \"\\\"79S54kzisD_9SOTfQLu_0TVQSpY/A4foLs-VO317Po_ulY6b5mSimZA\\\"\", \"id\": \"wHkPb68dxEw\", \"statistics\": { \"viewCount\": \"9211\", \"likeCount\": \"79\", \"dislikeCount\": \"11\", \"favoriteCount\": \"0\", \"commentCount\": \"29\" }, \"topicDetails\": { \"topicIds\": [ \"/m/02mjmr\" ], \"relevantTopicIds\": [ \"/m/0cnfvd\", \"/m/01jdpf\" ] } } ] }");

StructObjectInspector soi = (StructObjectInspector) instance.getObjectInspector();
JSONObject result = (JSONObject) instance.deserialize(w);

Object res = soi.getStructFieldData(result, soi.getStructFieldRef("pageinfo"));

StringObjectInspector loi = (StringObjectInspector) soi.getStructFieldRef("pageinfo")
.getFieldObjectInspector();

UDFJson udfJson = new UDFJson();
Text output = udfJson.evaluate(loi.getPrimitiveJavaObject(res), "$.test_field");
assertNull(output);
}

@Test
public void testStringWhenFieldIsNotInJson() throws SerDeException, JSONException {
Writable w = new Text(
"{ \"kind\": \"youtube#videoListResponse\", \"etag\": \"\\\"79S54kzisD_9SOTfQLu_0TVQSpY/mYlS4-ghMGhc1wTFCwoQl3IYDZc\\\"\", \"pageInfo\": { \"totalResults\": 1, \"resultsPerPage\": 1 }, \"items\": [ { \"kind\": \"youtube#video\", \"etag\": \"\\\"79S54kzisD_9SOTfQLu_0TVQSpY/A4foLs-VO317Po_ulY6b5mSimZA\\\"\", \"id\": \"wHkPb68dxEw\", \"statistics\": { \"viewCount\": \"9211\", \"likeCount\": \"79\", \"dislikeCount\": \"11\", \"favoriteCount\": \"0\", \"commentCount\": \"29\" }, \"topicDetails\": { \"topicIds\": [ \"/m/02mjmr\" ], \"relevantTopicIds\": [ \"/m/0cnfvd\", \"/m/01jdpf\" ] } } ] }");

StructObjectInspector soi = (StructObjectInspector) instance.getObjectInspector();
JSONObject result = (JSONObject) instance.deserialize(w);

Object res = soi.getStructFieldData(result, soi.getStructFieldRef("pageinfo"));

StringObjectInspector loi = (StringObjectInspector) soi.getStructFieldRef("pageinfo")
.getFieldObjectInspector();

UDFJson udfJson = new UDFJson();
Text output = udfJson.evaluate(loi.getPrimitiveJavaObject(res), "$.test_field");
assertNull(output);
}


@Test
public void testStringWhenJson() throws SerDeException, JSONException {
Writable w = new Text(
"{ \"kind\": \"youtube#videoListResponse\", \"etag\": \"\\\"79S54kzisD_9SOTfQLu_0TVQSpY/mYlS4-ghMGhc1wTFCwoQl3IYDZc\\\"\", \"pageInfo\": \"page\", \"items\": [ { \"kind\": \"youtube#video\", \"etag\": \"\\\"79S54kzisD_9SOTfQLu_0TVQSpY/A4foLs-VO317Po_ulY6b5mSimZA\\\"\", \"id\": \"wHkPb68dxEw\", \"statistics\": { \"viewCount\": \"9211\", \"likeCount\": \"79\", \"dislikeCount\": \"11\", \"favoriteCount\": \"0\", \"commentCount\": \"29\" }, \"topicDetails\": { \"topicIds\": [ \"/m/02mjmr\" ], \"relevantTopicIds\": [ \"/m/0cnfvd\", \"/m/01jdpf\" ] } } ] }");

StructObjectInspector soi = (StructObjectInspector) instance.getObjectInspector();
JSONObject result = (JSONObject) instance.deserialize(w);

Object res = soi.getStructFieldData(result, soi.getStructFieldRef("pageinfo"));

StringObjectInspector loi = (StringObjectInspector) soi.getStructFieldRef("pageinfo")
.getFieldObjectInspector();

String sres = loi.getPrimitiveJavaObject(res);
assertEquals("page", sres);

}

}