Fix for #issue-70 related to get_json_object #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are experiencing problems with mis-formed lines, where we think a field is supposed to be a Map, but due to a series of unfortunate events it is actually a String. When we encounter this line, Hive flips out and fails the entire job due to a recurring ClassCastException. This patch simply checks the castability of the variable before actually doing the cast. It returns NULL if it's not castable, and logs the toString() of it at warn level.
i fixes rcongiu#31, static record breakes nested structureswq
- The equals is checking if object is not instance of JSONObject and it is always the case. Changed the Null to be instance of JSONObject
Equals check always false.
Verify castability before actually doing it
This is a reworking of rcongiu#71 to update it to the new directory structure in 1.3
|
Apologies, this appears to have been against the wrong branch. Closing in favor of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reworking of #71 to update it to the new directory structure in 1.3.