Skip to content

Conversation

@piehld
Copy link
Contributor

@piehld piehld commented Dec 8, 2025

No description provided.

@piehld piehld requested a review from trumbullm December 8, 2025 23:33
Copy link
Contributor

@trumbullm trumbullm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments.


# or using uv

uv pip install -e .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this required because of the above line for OpenEye? Or could we do uv sync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, right now I made the project "unmanaged" in pyproject.toml, mainly because of issues with my local installations. I also haven't really used uv sync yet. Would you be able to give it a try? (You'll need to comment out the managed flag:

[tool.uv]
extra-index-url = ["https://pypi.anaconda.org/OpenEye/simple"]
managed = false  # This prevents uv from automatically creating venvs within individual packages when running 'uv run ...' from within the package directory

@piehld
Copy link
Contributor Author

piehld commented Dec 10, 2025

Thanks for your help testing today @trumbullm, and calling out the Docker bug! I switched the Dockerfile back to using pip with the --extra-index-url https://pypi.anaconda.org/OpenEye/simple flag, and it seems to work now.

When you have a chance, could you test it out once more? You can pull the image with:

docker pull harbor.devops.k8s.rcsb.org/rcsb/rcsb-workflow:dev-hatch --platform linux/amd64

The Python utils seem to install OK. I just want to make sure now that the node modules installed OK too.

Copy link
Contributor

@trumbullm trumbullm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Docker image had the correct cli installed

@piehld piehld merged commit 45d001b into master Dec 11, 2025
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants