-
Notifications
You must be signed in to change notification settings - Fork 3
V0.64 Switch to 'pyproject.toml' file and update test pipelines to python 3.12 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
trumbullm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments.
|
|
||
| # or using uv | ||
|
|
||
| uv pip install -e . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this required because of the above line for OpenEye? Or could we do uv sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, right now I made the project "unmanaged" in pyproject.toml, mainly because of issues with my local installations. I also haven't really used uv sync yet. Would you be able to give it a try? (You'll need to comment out the managed flag:
[tool.uv]
extra-index-url = ["https://pypi.anaconda.org/OpenEye/simple"]
managed = false # This prevents uv from automatically creating venvs within individual packages when running 'uv run ...' from within the package directory|
Thanks for your help testing today @trumbullm, and calling out the Docker bug! I switched the Dockerfile back to using When you have a chance, could you test it out once more? You can pull the image with: docker pull harbor.devops.k8s.rcsb.org/rcsb/rcsb-workflow:dev-hatch --platform linux/amd64The Python utils seem to install OK. I just want to make sure now that the |
trumbullm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Docker image had the correct cli installed
No description provided.