Skip to content

LDES1.0 conformance - #151

Open
pietercolpaert wants to merge 27 commits into
mainfrom
feat-ldes10-compliance
Open

pietercolpaert wants to merge 27 commits into
mainfrom
feat-ldes10-compliance

Conversation

@pietercolpaert

@pietercolpaert pietercolpaert commented Jul 25, 2026 •

Copy link
Copy Markdown
Member

The recently published LDES1.0 specification went into a stable version. I’m working on a compliance test suite now that proves spec compliance of independent implementations. This is a PR that tests this spec compliance using a github workflow, and that fixes failing tests we found.

The tests are added here as a GH action. You can find it here as well: https://github.com/pietercolpaert/ldes-client-conformance-test-suite

@pietercolpaert pietercolpaert changed the title LDES1.0 compliance LDES1.0 conformance Jul 26, 2026
@pietercolpaert

Copy link
Copy Markdown
Member Author
image

This PR has a performance regression. Before merging, let’s analyze where things should be implemented more efficiently

@pietercolpaert

Copy link
Copy Markdown
Member Author
image

This PR is now 5.43% faster than its base revision by median throughput. Throughput: 1,292.99 members/s vs 1,226.39 members/s in the base.

I found out that, in order to be spec compliant, that it partly re-implemented extract-cbd-shape, but then also used extract-cbd-shape again, which amounted to a lot of extra work per member. Therefore I added a feature in extract-cbd-shape which made sure it can be used in an LDES compliant way and reused that. The profiler also found further performance gains, which makes this version a bit faster than the main branch.

@pietercolpaert

Copy link
Copy Markdown
Member Author

And now, after some more performance fixes in extract-cbd-shape, we get to these results:

This PR is 11.96% faster than its base revision by median throughput. Throughput: 1,495.44 members/s vs 1,335.65 members/s (base)

image

https://ldes.pages.ilabt.imec.be/ldes-client-performance-tests/

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant