Fix DatasetFactory parent#57
Open
thewilkybarkid wants to merge 1 commit into
Open
Conversation
7 tasks
vhf
reviewed
Dec 3, 2019
Member
There was a problem hiding this comment.
I think it is correct as is, here's how I understand it:
DatasetFactory extends DataFactory, therefore an implementation of DatasetFactory would have all of these:
SomeDatasetFactory {
// from DataFactory
NamedNode namedNode(string value);
BlankNode blankNode(optional string value);
Literal literal(string value, optional (string or NamedNode) languageOrDatatype);
Variable variable(string value);
DefaultGraph defaultGraph();
Quad quad(Term subject, Term predicate, Term object, optional Term? graph);
Term fromTerm(Term original);
Quad fromQuad(Quad original);
// from DatasetFactory
Dataset dataset(optional (Dataset or sequence<Quad>) quads);
}
I think another possibility would be to have DatasetCoreFactory extend DataFactory, then we could have DatasetFactory extend DatasetCoreFactory?
bergos
approved these changes
Dec 3, 2019
Author
Could also just use unions of the two (reduces the requirements on implementing |
|
@ktk feel like reviewing this one too? It seems quite an obvious improvement compared with the status quo. Btw, how does one get the review privilege? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs DefinitelyTyped/DefinitelyTyped#40794 (comment).