Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016PTUEUKZE6DwmyBQbpLa9T
🦋 Changeset detectedLatest commit: c8d5ade The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Jesse · project thread
Proposes the types for #71.
Before: there is no shared interface for matching a basic graph pattern, so each library joins repeated
DatasetCore.matchcalls itself, and a store cannot expose a faster join on its own indexes.After: an optional
BgpMatchable<Q, B>interface withmatchBGP(patterns: Iterable<Q>): Iterable<B>, yielding oneBindingsper solution. A dataset opts in withimplements DatasetCore, BgpMatchable.How: the interface is added to
dataset.d.tsand importsBindingsfrom the query types.rdf-js-tests.tscovers it, and a changeset marks it as a minor release.Compatibility: purely additive. No existing interface changes, so current implementations and callers of
DatasetCore,Dataset,SourceandStorecompile unchanged.npm testandnpm run lintpass (lint reports only the warnings already onmaster).The open questions (method or function, streaming, bindings factory, wildcards, variables inside triple terms, which spec) are listed in the issue. An implementation exists as n3-match-bgp (formerly rdfjs/N3.js#809).
🤖 Generated with Claude Code
https://claude.ai/code/session_016PTUEUKZE6DwmyBQbpLa9T