Extend wrapper in named graph feature - #63
Merged
Conversation
Collaborator
Author
|
Forgot to adjust the README. |
jeswr
approved these changes
Apr 14, 2026
jeswr
left a comment
jeswr
left a comment
Member
There was a problem hiding this comment.
Very elegant. Approved - noting that README still requires updating.
Comment on lines
+18
to
+23
| class SomeDataset extends DatasetWrapper { | ||
| get namedGraph(): NamedGraphDataset { | ||
| return this.named(graph, NamedGraphDataset) | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This is an elegant usage. Please make sure an example like this finds its way into the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align #62 with the rest of the library.
The best place to start a review might be the revised tests, which are almost the same, but highlight the differences well.