fix(Textbox): stops flash on inlineContent change #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was noticed that the TextBox would flash when loading. This would occur when the TextBox contained content that were of type
InlineContent
and any property changed. This was due to the number of lines in the flex container potentially being more than the maxLines within theInlineContent
. It would then calculate the height based on this wrong number and send it back to the TextBox and flash the wrong number of lines.References
LUI-1435
Testing
InlineContent
stories andTextBox
stories renders as expected.maxLines
control, it works as expected and that there is no flashing of the component.Automation
Checklist