Skip to content

Conversation

@VeithMetro
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 11, 2025 09:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes compilation warnings and errors in Linux builds by addressing multiple issues across the codebase: correcting a typo in an enum value, replacing non-standard function identifiers with C99 standard equivalents, fixing buffer overflow vulnerabilities in string operations, correcting return types, and properly suppressing unavoidable compiler warnings.

Key Changes:

  • Fixed spelling of "HIBERNATE" enum value in controller interface
  • Replaced __FUNCTION__ with C99 standard __func__ in logging macros
  • Fixed buffer overflow vulnerabilities in strncpy calls with proper null-termination
  • Corrected return type inconsistencies and added proper unused parameter attributes
  • Added missing header includes and warning suppressions

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
Source/plugins/IController.h Corrected spelling of HIBERNATE enum value from HIBERBATE
Source/extensions/privilegedrequest/include/privilegedrequest/PrivilegedRequest.h Added warning suppression for mkstemp unused result
Source/extensions/hibernate/common/Log.h Replaced FUNCTION with C99 standard func
Source/extensions/hibernate/checkpointserver/CheckpointServer.c Fixed multiple warnings: added errno.h, fixed strncpy buffer overflows, corrected return types, removed unused variables, fixed error format strings, and marked unused parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@VeithMetro VeithMetro requested a review from sebaszm December 11, 2025 09:37
@VeithMetro VeithMetro merged commit cc5d85b into master Dec 11, 2025
83 checks passed
@VeithMetro VeithMetro deleted the development/actions-extensions branch December 11, 2025 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants