RDKEMW-11763 : Intermittent failure on Testframework while running entservices-mediaanddrm workflows #142
+34
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves test failures by fixing invalid JSON syntax in test cases and addressing timing issues in L2 tests.
Key changes:
- Fixed malformed JSON test inputs by replacing incomplete field values with valid empty strings
- Increased sleep durations in timing-sensitive playback control tests to reduce flakiness
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Tests/L2Tests/tests/LinearPlaybackControl_L2Test.cpp | Increased sleep durations from 100ms to 500ms in GetTrickplay_Test to allow sufficient time for file operations and state propagation |
| Tests/L1Tests/tests/test_TextToSpeech.cpp | Fixed invalid JSON syntax in four test cases by replacing incomplete field values (e.g., "speechid": }) with valid empty strings ("speechid": "") |
The changes in this PR are straightforward bug fixes. The test_TextToSpeech.cpp changes correct invalid JSON syntax that would have caused parsing errors. The LinearPlaybackControl_L2Test.cpp changes address potential race conditions by providing more time for asynchronous operations to complete before assertions are made.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…neration when the caller source is Testframework
smanes0213
changed the title
…must build every time
…rs to prevent duplicate definitions
…ld needing Communicator mock
… in testframework
… avoid duplicate definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Resolve intermittent failures while running tests on testframework repo
Test Procedure: Run L1, L2, L2-OOP(If applicable)
Risks: Low
Priority: P0
Version:minor