RDKEMW-10786: Added api to use url from rfc in screencapture #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new API method SendScreenshot to the ScreenCapture component that retrieves the upload URL from RFC (Remote Feature Control) configuration instead of requiring it as a parameter. This allows the screenshot upload destination to be centrally configured via RFC settings.
Key Changes
- Added new
SendScreenshotmethod that reads URL from RFC configuration - Implemented RFC-based enable/disable flag checking for screen capture functionality
- Modified GitHub workflow to temporarily include the feature branch in CI triggers
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| ScreenCapture/ScreenCaptureImplementation.h | Added declaration for new SendScreenshot method |
| ScreenCapture/ScreenCaptureImplementation.cpp | Implemented SendScreenshot with RFC configuration retrieval and validation logic |
| .github/workflows/native_full_build.yml | Added temporary feature branch to pull request trigger list and minor formatting changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
preeja33
force-pushed
the
feature/RDKEMW-10786
branch
from
c74d6f1 to
01b39b6
Compare
ramasat
reviewed
Dec 15, 2025
|
|
||
| this->url = std::move(url); | ||
|
|
||
| if (!callGUID.empty()) |
Contributor
There was a problem hiding this comment.
What if the callGUID is empty? Can we return an error? Also, fill this only when you have URL to maintain consistency
| _adminLock.Unlock(); | ||
| } | ||
|
|
||
| Core::hresult ScreenCaptureImplementation::SendScreenshot(const string &callGUID, Result &result) |
Contributor
There was a problem hiding this comment.
Please add L1/L2 for this method as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason For Change: Added api to use url from rfc in screencapture
Test procedure : Compiled and Verified
version: minor
Priority: P1