Skip to content

Conversation

@karuppaiyak
Copy link
Contributor

No description provided.

@karuppaiyak karuppaiyak requested a review from a team as a code owner July 14, 2025 06:40
@CLAassistant
Copy link

CLAassistant commented Jul 14, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rdkcmf-jenkins
Copy link
Contributor

rdkcmf-jenkins commented Jul 15, 2025

Coverity Issue - Resource leak

Handle variable "connection" going out of scope leaks the handle.

High Impact, CWE-404
RESOURCE_LEAK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_ScreenCapture.cpp:220

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Unchecked return value from library

Calling "send(connection, response.c_str(), response.size(), 0)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_ScreenCapture.cpp:228

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - String not null terminated

Passing unterminated string "buffer" to "basic_string", which expects a null-terminated string. [Note: The source code implementation of the function has been overridden by a builtin model.]

High Impact, CWE-170
STRING_NULL

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_ScreenCapture.cpp:224

@rdkcmf-jenkins
Copy link
Contributor

rdkcmf-jenkins commented Jul 15, 2025

Coverity Issue - Resource leak

Handle variable "sockfd" going out of scope leaks the handle.

High Impact, CWE-404
RESOURCE_LEAK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_ScreenCapture.cpp:211

EVENT_SUBSCRIBE(0, _T("uploadComplete"), _T("org.rdk.ScreenCapture"), message);
EVENT_SUBSCRIBE_1(0, _T("uploadComplete"), _T("org.rdk.ScreenCapture"), message);

EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("uploadScreenCapture"), _T("{\"url\":\"http://127.0.0.1:11111\"}"), response));
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Resource leak

Handle variable "connection" going out of scope leaks the handle.

High Impact, CWE-404
RESOURCE_LEAK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants