Skip to content

RDKEMW-7891 Flashing same image does not end in validation failed #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramkumarpraba wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-7891 Flashing same image does not end in validation failed #163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bf65d3
RDKEMW-7891 Flashing same image does not end in validation failed
ramkumarpraba Oct 23, 2025
1ed0497
Update FirmwareUpdateImplementation.cpp
ramkumarpraba Nov 4, 2025
b3d19b3
Merge pull request #170 from rdkcentral/develop
ramkumarpraba Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions FirmwareUpdate/FirmwareUpdateImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,9 +768,19 @@ namespace WPEFramework {
fileWithoutExtension = name;
}

if (fileWithoutExtension == currentFlashedImage)
// Read currently running image from /tmp/currently_running_image_name
std::ifstream runningImgFile("/tmp/currently_running_image_name");
std::string currentRunningImage;
if (runningImgFile.is_open()) {
std::getline(runningImgFile, currentRunningImage);
runningImgFile.close();
SWUPDATEINFO("currentRunningImage : %s", currentRunningImage.c_str());
} else {
SWUPDATEERR("Failed to read /tmp/currently_running_image_name");
}

if (fileWithoutExtension == currentFlashedImage || name == currentRunningImage)
{

SWUPDATEERR("FW version of the active image and the image to be upgraded are the same. No upgrade required. imagename : %s" ,name.c_str());
snprintf(fwdls.status, sizeof(fwdls.status), "Status|No upgrade needed\n");
snprintf(fwdls.FwUpdateState, sizeof(fwdls.FwUpdateState), "FwUpdateState|No upgrade needed\n");
Expand Down
Loading