Copilot L1 Test generation #164

smanes0213 · 2025-10-30T10:47:04Z

No description provided.

rdkcmf-jenkins · 2025-10-30T12:20:07Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+                stateFound = true;
+            }
+            if (key == "substate") {
+                substate = value;


Coverity Issue - Variable copied when it could be moved

"value" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""value"")" instead of "value".

rdkcmf-jenkins · 2025-10-30T12:20:07Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 0\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:20:07Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    std::this_thread::sleep_for(std::chrono::milliseconds(900));
+    EXPECT_NE(0, access(headerFile.c_str(), F_OK)); // Header file should be deleted
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:20:07Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    EXPECT_NE(0, access(headerFile.c_str(), F_OK)); // Header file should be deleted
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:20:07Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 0\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:20:12Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: Notification Register/Unregister around a successful update (event delivery check) */
+TEST_F(FirmwareUpdateTest, Notification_ReceiveUpdateStateChange) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:20:12Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    // Non-mediaclient success triggers FLASHING_SUCCEEDED via usb path then WAITING_FOR_REBOOT
+    EXPECT_TRUE(state == "FLASHING_SUCCEEDED" || state == "WAITING_FOR_REBOOT");
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:20:12Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    EXPECT_TRUE(state == "FLASHING_SUCCEEDED" || state == "WAITING_FOR_REBOOT");
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:20:12Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    // Firmware file should be deleted on success for mediaclient
+    EXPECT_NE(0, access(TEST_FIRMWARE_PATH.c_str(), F_OK));
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:20:13Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    EXPECT_NE(0, access(TEST_FIRMWARE_PATH.c_str(), F_OK));
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:26:52Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+    std::this_thread::sleep_for(std::chrono::milliseconds(800));
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:26:52Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    std::this_thread::sleep_for(std::chrono::milliseconds(800));
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:26:52Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");
+    std::remove("/opt/swupdate_maintenance_upgrade");


Coverity Issue - Unchecked return value from library

Calling "remove("/opt/swupdate_maintenance_upgrade")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:26:52Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: UpdateFirmware Failure Path (non-mediaclient x86) ensures state FAILED and file retained */
+TEST_F(FirmwareUpdateTest, UpdateFirmware_FlashImage_Failure_NonMediaClient_X86) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:26:53Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    uint32_t rc2 = handler.Invoke(connection, _T("updateFirmware"), req2, response);
+    EXPECT_NE(Core::ERROR_NONE, rc2); // Should return in-progress error code
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:26:56Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: Notification Register/Unregister around a successful update (event delivery check) */
+TEST_F(FirmwareUpdateTest, Notification_ReceiveUpdateStateChange) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:26:56Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    // Non-mediaclient success triggers FLASHING_SUCCEEDED via usb path then WAITING_FOR_REBOOT
+    EXPECT_TRUE(state == "FLASHING_SUCCEEDED" || state == "WAITING_FOR_REBOOT");
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:26:56Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    EXPECT_TRUE(state == "FLASHING_SUCCEEDED" || state == "WAITING_FOR_REBOOT");
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:26:56Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    // Firmware file should be deleted on success for mediaclient
+    EXPECT_NE(0, access(TEST_FIRMWARE_PATH.c_str(), F_OK));
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T12:26:56Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    EXPECT_NE(0, access(TEST_FIRMWARE_PATH.c_str(), F_OK));
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:10:08Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: UpdateFirmware Request Accepted for MediaClient Device */
+TEST_F(FirmwareUpdateTest, UpdateFirmware_FlashImage_MediaClient_RequestAccepted) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:10:08Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 0\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:10:08Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\necho 'Flashing...'\nexit 0\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:10:08Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: UpdateFirmware State Progression for MediaClient Success */
+TEST_F(FirmwareUpdateTest, UpdateFirmware_FlashImage_Success_StateProgression) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:10:09Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+    FirmwareUpdateImpl->Unregister(notify.get());
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:10:15Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: flashImage failure with maintenance mode true for mediaclient */
+TEST_F(FirmwareUpdateTest, UpdateFirmware_FlashImage_Failure_MaintenanceMode_MediaClient) {
+    system("mkdir -p /lib/rdk /opt");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:10:15Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 2\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:10:16Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: Notification Register/Unregister around a successful update (event delivery check) */
+TEST_F(FirmwareUpdateTest, Notification_ReceiveUpdateStateChange) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:10:16Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    // Non-mediaclient success triggers FLASHING_SUCCEEDED via usb path then WAITING_FOR_REBOOT
+    EXPECT_TRUE(state == "FLASHING_SUCCEEDED" || state == "WAITING_FOR_REBOOT");
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:10:16Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    EXPECT_TRUE(state == "FLASHING_SUCCEEDED" || state == "WAITING_FOR_REBOOT");
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:27:21Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: UpdateFirmware Request Validation - MediaClient Device Type Detected */
+TEST_F(FirmwareUpdateTest, UpdateFirmware_MediaClient_DeviceTypeCheck) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:27:21Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 0\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:27:21Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    // Wait long enough for thread to fully complete
+    std::this_thread::sleep_for(std::chrono::milliseconds(3000));
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:27:21Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    std::this_thread::sleep_for(std::chrono::milliseconds(3000));
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:27:21Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 0\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:27:24Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: flashImage failure with maintenance mode true for mediaclient */
+TEST_F(FirmwareUpdateTest, UpdateFirmware_FlashImage_Failure_MaintenanceMode_MediaClient) {
+    system("mkdir -p /lib/rdk /opt");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:27:24Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 2\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:27:24Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: Notification Register/Unregister around a successful update (event delivery check) */
+TEST_F(FirmwareUpdateTest, Notification_ReceiveUpdateStateChange) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:27:24Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    // Non-mediaclient success triggers FLASHING_SUCCEEDED via usb path then WAITING_FOR_REBOOT
+    EXPECT_TRUE(state == "FLASHING_SUCCEEDED" || state == "WAITING_FOR_REBOOT");
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:27:25Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    EXPECT_TRUE(state == "FLASHING_SUCCEEDED" || state == "WAITING_FOR_REBOOT");
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:42:04Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: UpdateFirmware Request Validation - MediaClient Device Type Detected */
+TEST_F(FirmwareUpdateTest, UpdateFirmware_MediaClient_DeviceTypeCheck) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:42:04Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 0\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:42:05Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    // Wait long enough for thread to fully complete
+    std::this_thread::sleep_for(std::chrono::milliseconds(3000));
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:42:05Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    std::this_thread::sleep_for(std::chrono::milliseconds(3000));
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:42:05Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 0\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:42:10Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: flashImage failure with maintenance mode true for mediaclient */
+TEST_F(FirmwareUpdateTest, UpdateFirmware_FlashImage_Failure_MaintenanceMode_MediaClient) {
+    system("mkdir -p /lib/rdk /opt");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:42:10Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 2\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:42:10Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: Notification Register/Unregister around a successful update (event delivery check) */
+TEST_F(FirmwareUpdateTest, Notification_ReceiveUpdateStateChange) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:42:10Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+                    state == "VALIDATION_COMPLETE");
+    }
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:42:10Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    }
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T13:52:11Z

Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_FirmwareUpdate.cpp:1956

rdkcmf-jenkins · 2025-10-30T13:52:12Z

Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_FirmwareUpdate.cpp:1957

rdkcmf-jenkins · 2025-10-30T14:09:38Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: UpdateFirmware Request Validation - MediaClient Device Type Detected */
+TEST_F(FirmwareUpdateTest, UpdateFirmware_MediaClient_DeviceTypeCheck) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T14:09:38Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 0\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T14:09:38Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    // Wait long enough for thread to fully complete
+    std::this_thread::sleep_for(std::chrono::milliseconds(3000));
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T14:09:38Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    std::this_thread::sleep_for(std::chrono::milliseconds(3000));
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T14:09:38Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 0\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T14:09:42Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: flashImage failure with maintenance mode true for mediaclient */
+TEST_F(FirmwareUpdateTest, UpdateFirmware_FlashImage_Failure_MaintenanceMode_MediaClient) {
+    system("mkdir -p /lib/rdk /opt");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T14:09:42Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+        std::ofstream script("/lib/rdk/imageFlasher.sh");
+        script << "#!/bin/sh\nexit 2\n";
+    }
+    chmod("/lib/rdk/imageFlasher.sh", 0755);


Coverity Issue - Unchecked return value from library

Calling "chmod("/lib/rdk/imageFlasher.sh", 493U)" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T14:09:42Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+
+/* Test: Notification Register/Unregister around a successful update (event delivery check) */
+TEST_F(FirmwareUpdateTest, Notification_ReceiveUpdateStateChange) {
+    system("mkdir -p /lib/rdk");


Coverity Issue - Unchecked return value

Calling "system" without checking return value (as is done elsewhere 3 out of 3 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T14:09:42Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    // For non-mediaclient, file should remain after successful flash
+    EXPECT_EQ(0, access(TEST_FIRMWARE_PATH.c_str(), F_OK));
+
+    std::remove("/etc/device.properties");


Coverity Issue - Unchecked return value from library

Calling "remove("/etc/device.properties")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-10-30T14:09:42Z

Tests/L1Tests/tests/test_FirmwareUpdate.cpp

+    EXPECT_EQ(0, access(TEST_FIRMWARE_PATH.c_str(), F_OK));
+
+    std::remove("/etc/device.properties");
+    std::remove("/lib/rdk/imageFlasher.sh");


Coverity Issue - Unchecked return value from library

Calling "remove("/lib/rdk/imageFlasher.sh")" without checking return value. This library function may fail and return an error code.

Medium Impact, CWE-252
CHECKED_RETURN

Copilot L1 Test generation

b4c663e

smanes0213 requested a review from a team as a code owner October 30, 2025 10:47

smanes0213 added 7 commits October 30, 2025 16:19

Merge branch 'develop' into copilot

133f2b2

Update L1-tests.yml

768a2be

Add more test fixtures for increasing coverage

5e07599

Resolve errors

1dca7d7

Resolve errors

da61557

Resolve errors

b5bcacd

Resolve errors

b9f4b45

rdkcmf-jenkins reviewed Oct 30, 2025

View reviewed changes

Resolve errors

d0b5d73

rdkcmf-jenkins reviewed Oct 30, 2025

View reviewed changes

smanes0213 added 2 commits October 30, 2025 18:43

Resolve errors

326f697

Resolve errors

b4757a0

rdkcmf-jenkins reviewed Oct 30, 2025

View reviewed changes

Resolve errors

0d04ba0

rdkcmf-jenkins reviewed Oct 30, 2025

View reviewed changes

Resolve errors

4fae581

rdkcmf-jenkins reviewed Oct 30, 2025

View reviewed changes


		std::this_thread::sleep_for(std::chrono::milliseconds(800));

		std::remove("/etc/device.properties");


		FirmwareUpdateImpl->Unregister(notify.get());

		std::remove("/etc/device.properties");

Copilot L1 Test generation #164

Are you sure you want to change the base?

Copilot L1 Test generation #164

Uh oh!

Conversation

smanes0213 commented Oct 30, 2025

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

rdkcmf-jenkins Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

rdkcmf-jenkins Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

rdkcmf-jenkins Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value from library

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

Choose a reason for hiding this comment

rdkcmf-jenkins Oct 30, 2025 •

edited

Loading

rdkcmf-jenkins Oct 30, 2025 •

edited

Loading

rdkcmf-jenkins Oct 30, 2025 •

edited

Loading

rdkcmf-jenkins Oct 30, 2025 •

edited

Loading