Skip to content

Conversation

@gomathishankar37
Copy link
Contributor

No description provided.

@gomathishankar37 gomathishankar37 requested a review from a team as a code owner November 3, 2025 09:04
/* check if maintenance is on progress or not */
/* if in progress restrict the same */
if (MAINTENANCE_STARTED != m_notify_status)
{
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".

Signed-off-by: gomathishankar37 <[email protected]>
/* check if maintenance is on progress or not */
/* if in progress restrict the same */
if (MAINTENANCE_STARTED != m_notify_status)
{
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".

/* check if maintenance is on progress or not */
/* if in progress restrict the same */
if (MAINTENANCE_STARTED != m_notify_status)
{
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".

/* check if maintenance is on progress or not */
/* if in progress restrict the same */
if (MAINTENANCE_STARTED != m_notify_status)
{
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".

Signed-off-by: gomathishankar37 <[email protected]>
/* check if maintenance is on progress or not */
/* if in progress restrict the same */
if (MAINTENANCE_STARTED != m_notify_status)
{
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".

2024 Oct 03 18:57:31.029050 sh[10255]:  Clock Frequency Info:

Signed-off-by: gomathishankar37 <[email protected]>
Signed-off-by: gomathishankar37 <[email protected]>
/* check if maintenance is on progress or not */
/* if in progress restrict the same */
if (MAINTENANCE_STARTED != m_notify_status)
{
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".

/* check if maintenance is on progress or not */
/* if in progress restrict the same */
if (MAINTENANCE_STARTED != m_notify_status)
{
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".

/* check if maintenance is on progress or not */
/* if in progress restrict the same */
if (MAINTENANCE_STARTED != m_notify_status)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Variable copied when it could be moved

"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".

Copy link
Contributor

@tdeva14 tdeva14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdeva14
Copy link
Contributor

tdeva14 commented Nov 6, 2025

L2 failure not related

@tdeva14 tdeva14 merged commit 3686f6d into develop Nov 6, 2025
8 of 11 checks passed
@tdeva14 tdeva14 deleted the feature/RDK-59287 branch November 6, 2025 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants