-
Notifications
You must be signed in to change notification settings - Fork 4
RDK-59287: Add logic to support Periodic App Maintenance #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: gomathishankar37 <[email protected]>
| /* check if maintenance is on progress or not */ | ||
| /* if in progress restrict the same */ | ||
| if (MAINTENANCE_STARTED != m_notify_status) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Variable copied when it could be moved
"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".
Signed-off-by: gomathishankar37 <[email protected]>
| /* check if maintenance is on progress or not */ | ||
| /* if in progress restrict the same */ | ||
| if (MAINTENANCE_STARTED != m_notify_status) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Variable copied when it could be moved
"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".
…d setMaintenanceMode() APIs Signed-off-by: gomathishankar37 <[email protected]>
Signed-off-by: gomathishankar37 <[email protected]>
Signed-off-by: gomathishankar37 <[email protected]>
| /* check if maintenance is on progress or not */ | ||
| /* if in progress restrict the same */ | ||
| if (MAINTENANCE_STARTED != m_notify_status) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Variable copied when it could be moved
"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".
Signed-off-by: gomathishankar37 <[email protected]>
| /* check if maintenance is on progress or not */ | ||
| /* if in progress restrict the same */ | ||
| if (MAINTENANCE_STARTED != m_notify_status) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Variable copied when it could be moved
"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".
Signed-off-by: gomathishankar37 <[email protected]>
| /* check if maintenance is on progress or not */ | ||
| /* if in progress restrict the same */ | ||
| if (MAINTENANCE_STARTED != m_notify_status) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Variable copied when it could be moved
"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".
2024 Oct 03 18:57:31.029050 sh[10255]: Clock Frequency Info: Signed-off-by: gomathishankar37 <[email protected]>
Signed-off-by: gomathishankar37 <[email protected]>
| /* check if maintenance is on progress or not */ | ||
| /* if in progress restrict the same */ | ||
| if (MAINTENANCE_STARTED != m_notify_status) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Variable copied when it could be moved
"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".
| /* check if maintenance is on progress or not */ | ||
| /* if in progress restrict the same */ | ||
| if (MAINTENANCE_STARTED != m_notify_status) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Variable copied when it could be moved
"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".
| /* check if maintenance is on progress or not */ | ||
| /* if in progress restrict the same */ | ||
| if (MAINTENANCE_STARTED != m_notify_status) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity Issue - Variable copied when it could be moved
"new_trigger_mode" is copied in call to copy assignment for class "string", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""new_trigger_mode"")" instead of "new_trigger_mode".
tdeva14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
L2 failure not related |
No description provided.