RDKEMW-10556 : Fix the uninitialized variables #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialized variables for red, green, blue, iterations, and duration to prevent uninitialized usage.
There was a problem hiding this comment.
Pull request overview
This PR addresses uninitialized variable issues in the frontpanel helper code by adding proper initialization values. The changes ensure that variables have defined values before being passed to parameter getter macros, preventing undefined behavior.
- Initializes RGB color component variables (
red,green,blue) to 0 in two locations - Initializes timing variables (
iterations,duration) to 0 in the blink configuration code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
srikanth-vv
approved these changes
Dec 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change: Uninitialized variable issues have been resolved with proper initialization and necessary code corrections.
Test Procedure: Compiled and Verified
Risks: Low
Priority: P1
version: minor
Signed-off-by: HarshiniRavichandran [email protected]