RDK-57914: Dynamic WhoAmI feature control for Manintenance Manager

[gomathishankar37]

No description provided.

[gomathishankar37]

LGTM

[gomathishankar37]

Please resolve conflicts. LGTM

[rdkcmf-jenkins]

Coverity Issue - Data race condition

Accessing "this->g_task_status" without holding lock "WPEFramework::Plugin::MaintenanceManager.m_statusMutex". Elsewhere, "WPEFramework::Plugin::MaintenanceManager.g_task_status" is written to with "MaintenanceManager.m_statusMutex" held 13 out of 16 times.

Medium Impact, CWE-366
MISSING_LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
MaintenanceManager/MaintenanceManager.cpp:523

[rdkcmf-jenkins]

Coverity Issue - Data race condition

Accessing "this->m_task_map" without holding lock "WPEFramework::Plugin::MaintenanceManager.m_statusMutex". Elsewhere, "WPEFramework::Plugin::MaintenanceManager.m_task_map" is written to with "MaintenanceManager.m_statusMutex" held 11 out of 15 times.

Medium Impact, CWE-366
MISSING_LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
MaintenanceManager/MaintenanceManager.cpp:497

[yogeswaransky]

Comments addressed and Conflicts resolved

[tdeva14]

LGTM

[rdkcmf-jenkins]

Coverity Issue - Unchecked return value

Calling "Invoke" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
MaintenanceManager/MaintenanceManager.cpp:612

[rdkcmf-jenkins]

Coverity Issue - Variable copied when it could be moved

"joGetResult" is passed-by-value as parameter to "WPEFramework::Core::JSON::VariantContainer::VariantContainer(WPEFramework::Core::JSON::VariantContainer const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""joGetResult"")" instead of "joGetResult".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
MaintenanceManager/MaintenanceManager.cpp:619

[tdeva14]

LGTM