Skip to content

Conversation

@nhanasi
Copy link
Contributor

@nhanasi nhanasi commented Jul 18, 2025

No description provided.

@nhanasi nhanasi requested review from a team as code owners July 18, 2025 18:25
@CLAassistant
Copy link

CLAassistant commented Jul 18, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 21 committers have signed the CLA.

✅ dkumar798
✅ ssitar583
✅ AravindanNC
✅ yuvaramachandran-gurusamy
✅ plaksh002c-public
✅ egalla204
✅ klu339
❌ Adrian Muzyka
❌ rosemarybennyy
❌ satlead
❌ pkumbh631
❌ satya200
❌ rdkcm-rdke
❌ nhanasi
❌ tharun-kumarv
❌ divyang-public
❌ arun-madhavan-013
❌ anand-ky
❌ sborushevsky
❌ preeja33
❌ rekhap2kandhavelan


Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI review requested due to automatic review settings October 28, 2025 14:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs a rebase operation that updates component versions and source revisions across the middleware layer, along with adding new workflow automation.

Key Changes:

  • Updates package version from 2.12.0 to 8.3.4.0
  • Adds new components (thunder-plugin-activator, sceneset, packager-headers) and renames thunderhangrecovery to thunder-hang-recovery
  • Updates source revisions (SRCREVs) and package versions (PVs) for numerous middleware components
  • Adds three new GitHub workflow files for PR validation, CLA checking, and FOSSID scanning

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
recipes-core/packagegroups/packagegroup-middleware-layer.bb Updates package version to 8.3.4.0, renames thunder-hang-recovery, and adds new dependencies
conf/include/generic-srcrev.inc Updates source revisions for approximately 50 components and adds new component entries
conf/include/generic-pkgrev.inc Updates package versions and reorganizes version definitions for multiple components
CHANGELOG.md Adds extensive changelog entries for versions 1.8.0 through 1.4.0 with PR references
.github/workflows/validate_pr_desc.yml Adds new workflow for validating PR title and description format
.github/workflows/fossid_integration_stateless_diffscan_target_repo.yml Adds new workflow for FOSSID license scanning
.github/workflows/cla.yml Adds new workflow for CLA signature verification
.github/workflows/auto_pr_creation_target_repo_caller.yml Updates branch pattern to include versioned support branches

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


inherit packagegroup volatile-bind-gen

# For interim development and package depolyment to test should be using pre release tags
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version jump from 2.12.0 to 8.3.4.0 is unusually large and breaks semantic versioning conventions. Consider documenting the rationale for this major version change in the commit message or using a more conventional versioning scheme.

Suggested change
# For interim development and package depolyment to test should be using pre release tags
# For interim development and package depolyment to test should be using pre release tags
# NOTE: The version number was incremented from 2.12.0 to 8.3.4.0 to align with the versioning scheme of related middleware components
# and to reflect significant architectural changes introduced in this release. This jump is intentional and documented here
# to maintain transparency and avoid confusion regarding semantic versioning conventions.

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}"

PV:pn-xdial = "3.0.0"
PV:pn-xdial = "1.0.0"
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xdial package version is being downgraded from 3.0.0 to 1.0.0, which could indicate a potential issue with dependency management or version tracking. Verify this version change is intentional and won't cause compatibility issues.

Suggested change
PV:pn-xdial = "1.0.0"
PV:pn-xdial = "3.0.0"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 28, 2025 16:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


# For interim development and package depolyment to test should be using pre release tags
PV = "2.12.0"
PV = "8.3.4.0"
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version jump from 2.12.0 to 8.3.4.0 is unusually large and may indicate an error. Verify this is the intended version number, as such large jumps can cause confusion in version tracking and may break semantic versioning expectations.

Suggested change
PV = "8.3.4.0"
PV = "2.13.0-dev"

Copilot uses AI. Check for mistakes.
PV:pn-rfc = "1.1.1"
PR:pn-rfc = "r1"
PV:pn-rfc = "1.1.7"
PR:pn-rfc = "r0"
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR (package release) was changed from 'r1' to 'r0' while the version was bumped. Typically, when a version increases, the PR should remain at 'r0', but when downgrading or keeping the same version with changes, PR should increment. Verify this change is intentional.

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH_pn-webconfig-framework = "${MIDDLEWARE_ARCH}"

PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}"

Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xdial package version was changed from 3.0.0 to 1.0.0, which appears to be a downgrade. This could indicate a versioning scheme change or a potential error. Please verify this is intentional and document the reason for the apparent version decrease.

Suggested change
# NOTE: The xdial package version was reset from 3.0.0 to 1.0.0.
# This was intentional due to a versioning scheme change. See issue tracker or release notes for details.

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 29, 2025 19:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

echo "Validating $field_name: $text"

# Check if text matches the pattern <TICKETID>-<ticketno.> : <desc>
if [[ ! "$text" =~ ^[A-Z0-9]+-[0-9]+[[:space:]]*:[[:space:]]*.+ ]]; then
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern allows any combination of uppercase letters and numbers for the ticket ID prefix (e.g., '123ABC-456'), but the validation logic on lines 53-60 only checks against specific valid ticket IDs. This could be confusing. Consider tightening the regex to only match the valid patterns, or at minimum add a comment explaining why the loose regex is intentional.

Copilot uses AI. Check for mistakes.

inherit packagegroup volatile-bind-gen

# For interim development and package depolyment to test should be using pre release tags
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'depolyment' to 'deployment'.

Suggested change
# For interim development and package depolyment to test should be using pre release tags
# For interim development and package deployment to test should be using pre release tags

Copilot uses AI. Check for mistakes.
PV = "2.12.0"
PV = "8.4.1.0"

# PRs are prefered to be be incremented during development stages for any updates in corresponding
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'prefered' to 'preferred' and removed duplicate word 'be'.

Suggested change
# PRs are prefered to be be incremented during development stages for any updates in corresponding
# PRs are preferred to be incremented during development stages for any updates in corresponding

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 30, 2025 19:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

satlead and others added 8 commits October 31, 2025 03:23
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458

Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

---------

Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
Copilot AI review requested due to automatic review settings October 31, 2025 12:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

madanagopalt and others added 5 commits October 31, 2025 08:57
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-9558: Cleanup ripple calls in lifecyclemanager

---------

Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
Copilot AI review requested due to automatic review settings October 31, 2025 15:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

filipe-norte-red and others added 7 commits December 18, 2025 14:19
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC
compliant and no longer depends on Thunder.

Set initial versions of Firebolt C++ recipes.

Risks: None


Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec

Signed-off-by: Tomasz Blaszczak <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- RDKEMW-7712: Update generic-pkgrev.inc [`#1492`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1492)
- RDKEMW-6901: Update the deviceanddisplay tag 3.1.14 in generic-pkgrev [`#1517`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1517)
- RDKEMW-7699: Backmerge release branch to develop for MW 8.3.3.0 Q3 Bi-Weekly Release [`#1460`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1460)
- RDKEMW-6272: Move Playready DRM abstracted API to separae shared obj [`#1494`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1494)
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typo "separae" should be corrected to "separate" in this changelog entry about moving Playready DRM abstracted API.

Suggested change
- RDKEMW-6272: Move Playready DRM abstracted API to separae shared obj [`#1494`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1494)
- RDKEMW-6272: Move Playready DRM abstracted API to separate shared obj [`#1494`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1494)

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}"

PV:pn-xdial = "3.0.0"
PV:pn-xdial = "1.0.1"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version for xdial has been changed from "3.0.0" to "1.0.1", which appears to be a downgrade. This is unusual and potentially problematic. Please verify that this is intentional and not an error, as downgrading versions can introduce bugs, remove features, or cause compatibility issues with other components expecting version 3.0.0 or higher.

Suggested change
PV:pn-xdial = "1.0.1"
PV:pn-xdial = "3.0.0"

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}"

PV:pn-networkmanager-plugin = "0.22.0"
PV:pn-networkmanager-plugin = "v1.10.0"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PV for networkmanager-plugin has been changed to "v1.10.0" which includes a "v" prefix. This is inconsistent with other package version definitions in this file which use numeric versions without prefixes (e.g., "1.0.0", "2.0.1"). The version prefix should be removed to maintain consistency and avoid potential issues with version comparison logic.

Suggested change
PV:pn-networkmanager-plugin = "v1.10.0"
PV:pn-networkmanager-plugin = "1.10.0"

Copilot uses AI. Check for mistakes.
IshvarKR and others added 2 commits December 19, 2025 11:26
Co-authored-by: ikavas409_comcast <[email protected]>
Co-authored-by: madanagopalt <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-10493: copilot fix for static analysis issues

---------

Co-authored-by: agampa263 <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}"

PV:pn-xdial = "3.0.0"
PV:pn-xdial = "1.0.1"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number for xdial has been downgraded from "3.0.0" to "1.0.1". This appears to be a version downgrade rather than an upgrade, which is unusual for a rebase operation and could potentially cause issues. Please verify this is intentional.

Suggested change
PV:pn-xdial = "1.0.1"
PV:pn-xdial = "3.0.0"

Copilot uses AI. Check for mistakes.
- name: Validate PR Title
env:
PR_TITLE: ${{ github.event.pull_request.title }}
PR_BODY: ${{ github.event.pull_request.body }}
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR_BODY environment variable is defined on line 18 but never used in the workflow. This unused variable should be removed to improve code clarity.

Suggested change
PR_BODY: ${{ github.event.pull_request.body }}

Copilot uses AI. Check for mistakes.
- 'support/*.*.*'
- 'support/*.*.*.*'


Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is unnecessary trailing whitespace on line 11. This should be removed for code cleanliness.

Suggested change

Copilot uses AI. Check for mistakes.
melhar098 and others added 6 commits December 19, 2025 14:56
Reason for change: move recipe information closer to developer’s repos
Test Procedure: see Jira ticket
Risks: Low
Priority: P1

Signed-off-by: Mahmoud El-haron <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Version: Major
Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
Copilot AI review requested due to automatic review settings January 5, 2026 15:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

divyang-public and others added 2 commits January 5, 2026 17:53
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
@github-actions
Copy link

github-actions bot commented Jan 9, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


17 out of 18 committers have signed the CLA.
✅ (satlead)[https://github.com/satlead]
✅ (Vismalskumar0)[https://github.com/Vismalskumar0]
✅ (madanagopalt)[https://github.com/madanagopalt]
✅ (nhanasi)[https://github.com/nhanasi]
✅ (anand-ky)[https://github.com/anand-ky]
✅ (rdkcm-rdke)[https://github.com/rdkcm-rdke]
✅ (gurpreet319)[https://github.com/gurpreet319]
✅ (yuvaramachandran-gurusamy)[https://github.com/yuvaramachandran-gurusamy]
✅ (ks734)[https://github.com/ks734]
✅ (vjain008)[https://github.com/vjain008]
✅ (divyang-public)[https://github.com/divyang-public]
✅ (muthushiamsankar)[https://github.com/muthushiamsankar]
✅ (AravindanNC)[https://github.com/AravindanNC]
✅ (sindhu-krishnan)[https://github.com/sindhu-krishnan]
✅ (satya200)[https://github.com/satya200]
✅ (egalla204)[https://github.com/egalla204]
✅ (sborushevsky)[https://github.com/sborushevsky]
@rekhap2kandhavelan
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI review requested due to automatic review settings January 9, 2026 18:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.