-
Notifications
You must be signed in to change notification settings - Fork 16
rebase #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/RDK-58526
Are you sure you want to change the base?
rebase #1055
Conversation
|
Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR performs a rebase operation that updates component versions and source revisions across the middleware layer, along with adding new workflow automation.
Key Changes:
- Updates package version from 2.12.0 to 8.3.4.0
- Adds new components (thunder-plugin-activator, sceneset, packager-headers) and renames thunderhangrecovery to thunder-hang-recovery
- Updates source revisions (SRCREVs) and package versions (PVs) for numerous middleware components
- Adds three new GitHub workflow files for PR validation, CLA checking, and FOSSID scanning
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Updates package version to 8.3.4.0, renames thunder-hang-recovery, and adds new dependencies |
| conf/include/generic-srcrev.inc | Updates source revisions for approximately 50 components and adds new component entries |
| conf/include/generic-pkgrev.inc | Updates package versions and reorganizes version definitions for multiple components |
| CHANGELOG.md | Adds extensive changelog entries for versions 1.8.0 through 1.4.0 with PR references |
| .github/workflows/validate_pr_desc.yml | Adds new workflow for validating PR title and description format |
| .github/workflows/fossid_integration_stateless_diffscan_target_repo.yml | Adds new workflow for FOSSID license scanning |
| .github/workflows/cla.yml | Adds new workflow for CLA signature verification |
| .github/workflows/auto_pr_creation_target_repo_caller.yml | Updates branch pattern to include versioned support branches |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| inherit packagegroup volatile-bind-gen | ||
|
|
||
| # For interim development and package depolyment to test should be using pre release tags |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version jump from 2.12.0 to 8.3.4.0 is unusually large and breaks semantic versioning conventions. Consider documenting the rationale for this major version change in the commit message or using a more conventional versioning scheme.
| # For interim development and package depolyment to test should be using pre release tags | |
| # For interim development and package depolyment to test should be using pre release tags | |
| # NOTE: The version number was incremented from 2.12.0 to 8.3.4.0 to align with the versioning scheme of related middleware components | |
| # and to reflect significant architectural changes introduced in this release. This jump is intentional and documented here | |
| # to maintain transparency and avoid confusion regarding semantic versioning conventions. |
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-xdial = "3.0.0" | ||
| PV:pn-xdial = "1.0.0" |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xdial package version is being downgraded from 3.0.0 to 1.0.0, which could indicate a potential issue with dependency management or version tracking. Verify this version change is intentional and won't cause compatibility issues.
| PV:pn-xdial = "1.0.0" | |
| PV:pn-xdial = "3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # For interim development and package depolyment to test should be using pre release tags | ||
| PV = "2.12.0" | ||
| PV = "8.3.4.0" |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version jump from 2.12.0 to 8.3.4.0 is unusually large and may indicate an error. Verify this is the intended version number, as such large jumps can cause confusion in version tracking and may break semantic versioning expectations.
| PV = "8.3.4.0" | |
| PV = "2.13.0-dev" |
conf/include/generic-pkgrev.inc
Outdated
| PV:pn-rfc = "1.1.1" | ||
| PR:pn-rfc = "r1" | ||
| PV:pn-rfc = "1.1.7" | ||
| PR:pn-rfc = "r0" |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR (package release) was changed from 'r1' to 'r0' while the version was bumped. Typically, when a version increases, the PR should remain at 'r0', but when downgrading or keeping the same version with changes, PR should increment. Verify this change is intentional.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH_pn-webconfig-framework = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}" | ||
|
|
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xdial package version was changed from 3.0.0 to 1.0.0, which appears to be a downgrade. This could indicate a versioning scheme change or a potential error. Please verify this is intentional and document the reason for the apparent version decrease.
| # NOTE: The xdial package version was reset from 3.0.0 to 1.0.0. | |
| # This was intentional due to a versioning scheme change. See issue tracker or release notes for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "Validating $field_name: $text" | ||
|
|
||
| # Check if text matches the pattern <TICKETID>-<ticketno.> : <desc> | ||
| if [[ ! "$text" =~ ^[A-Z0-9]+-[0-9]+[[:space:]]*:[[:space:]]*.+ ]]; then |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex pattern allows any combination of uppercase letters and numbers for the ticket ID prefix (e.g., '123ABC-456'), but the validation logic on lines 53-60 only checks against specific valid ticket IDs. This could be confusing. Consider tightening the regex to only match the valid patterns, or at minimum add a comment explaining why the loose regex is intentional.
|
|
||
| inherit packagegroup volatile-bind-gen | ||
|
|
||
| # For interim development and package depolyment to test should be using pre release tags |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'depolyment' to 'deployment'.
| # For interim development and package depolyment to test should be using pre release tags | |
| # For interim development and package deployment to test should be using pre release tags |
| PV = "2.12.0" | ||
| PV = "8.4.1.0" | ||
|
|
||
| # PRs are prefered to be be incremented during development stages for any updates in corresponding |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'prefered' to 'preferred' and removed duplicate word 'be'.
| # PRs are prefered to be be incremented during development stages for any updates in corresponding | |
| # PRs are preferred to be incremented during development stages for any updates in corresponding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458 Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
Rebase and merge
* Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc --------- Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
* Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-9558: Cleanup ripple calls in lifecyclemanager --------- Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-9849: Move memcapture to middleware layer
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC compliant and no longer depends on Thunder. Set initial versions of Firebolt C++ recipes. Risks: None Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec Signed-off-by: Tomasz Blaszczak <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - RDKEMW-7712: Update generic-pkgrev.inc [`#1492`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1492) | ||
| - RDKEMW-6901: Update the deviceanddisplay tag 3.1.14 in generic-pkgrev [`#1517`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1517) | ||
| - RDKEMW-7699: Backmerge release branch to develop for MW 8.3.3.0 Q3 Bi-Weekly Release [`#1460`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1460) | ||
| - RDKEMW-6272: Move Playready DRM abstracted API to separae shared obj [`#1494`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1494) |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typo "separae" should be corrected to "separate" in this changelog entry about moving Playready DRM abstracted API.
| - RDKEMW-6272: Move Playready DRM abstracted API to separae shared obj [`#1494`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1494) | |
| - RDKEMW-6272: Move Playready DRM abstracted API to separate shared obj [`#1494`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1494) |
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-xdial = "3.0.0" | ||
| PV:pn-xdial = "1.0.1" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version for xdial has been changed from "3.0.0" to "1.0.1", which appears to be a downgrade. This is unusual and potentially problematic. Please verify that this is intentional and not an error, as downgrading versions can introduce bugs, remove features, or cause compatibility issues with other components expecting version 3.0.0 or higher.
| PV:pn-xdial = "1.0.1" | |
| PV:pn-xdial = "3.0.0" |
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-networkmanager-plugin = "0.22.0" | ||
| PV:pn-networkmanager-plugin = "v1.10.0" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PV for networkmanager-plugin has been changed to "v1.10.0" which includes a "v" prefix. This is inconsistent with other package version definitions in this file which use numeric versions without prefixes (e.g., "1.0.0", "2.0.1"). The version prefix should be removed to maintain consistency and avoid potential issues with version comparison logic.
| PV:pn-networkmanager-plugin = "v1.10.0" | |
| PV:pn-networkmanager-plugin = "1.10.0" |
Co-authored-by: ikavas409_comcast <[email protected]> Co-authored-by: madanagopalt <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc * Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-10493: copilot fix for static analysis issues --------- Co-authored-by: agampa263 <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-xdial = "3.0.0" | ||
| PV:pn-xdial = "1.0.1" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number for xdial has been downgraded from "3.0.0" to "1.0.1". This appears to be a version downgrade rather than an upgrade, which is unusual for a rebase operation and could potentially cause issues. Please verify this is intentional.
| PV:pn-xdial = "1.0.1" | |
| PV:pn-xdial = "3.0.0" |
| - name: Validate PR Title | ||
| env: | ||
| PR_TITLE: ${{ github.event.pull_request.title }} | ||
| PR_BODY: ${{ github.event.pull_request.body }} |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR_BODY environment variable is defined on line 18 but never used in the workflow. This unused variable should be removed to improve code clarity.
| PR_BODY: ${{ github.event.pull_request.body }} |
| - 'support/*.*.*' | ||
| - 'support/*.*.*.*' | ||
|
|
||
|
|
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is unnecessary trailing whitespace on line 11. This should be removed for code cleanliness.
Reason for change: move recipe information closer to developer’s repos Test Procedure: see Jira ticket Risks: Low Priority: P1 Signed-off-by: Mahmoud El-haron <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
…ic-support into RDKEMW_11604
Version: Major Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
|
I have read the CLA Document and I hereby sign the CLA 17 out of 18 committers have signed the CLA. |
RDKEMW-11560: Update middleware package group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
No description provided.