-
Notifications
You must be signed in to change notification settings - Fork 16
rebase #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/RDKEMW-6435-dev
Are you sure you want to change the base?
rebase #1149
Conversation
|
Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request performs a rebase operation that updates package versions, source revisions, and dependencies across the middleware layer. The changes reflect version bumps for multiple components and introduce new packages while renaming others.
Key Changes:
- Updated middleware layer package version from "2.12.0" to "8.3.4.0"
- Renamed
thunderhangrecoverytothunder-hang-recoveryand added new dependencies - Updated source revisions (SRCREV) for 50+ components to their latest commits
- Bumped package versions (PV) for numerous middleware components
- Added new GitHub workflow files for PR validation, CLA, and FOSSID scanning
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Updates main package version and renames thunder-related dependencies |
| conf/include/generic-srcrev.inc | Updates source revision hashes for all middleware components |
| conf/include/generic-pkgrev.inc | Bumps package versions and consolidates related package configurations |
| CHANGELOG.md | Adds release notes for versions 1.4.0 through 1.8.0 |
| .github/workflows/validate_pr_desc.yml | Adds new PR description validation workflow |
| .github/workflows/fossid_integration_stateless_diffscan_target_repo.yml | Adds FOSSID scanning workflow |
| .github/workflows/cla.yml | Adds CLA signature workflow |
| .github/workflows/auto_pr_creation_target_repo_caller.yml | Updates branch pattern to support versioned support branches |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-xdial = "3.0.0" | ||
| PV:pn-xdial = "1.0.0" |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version downgrade detected: xdial version changes from '3.0.0' to '1.0.0'. This appears to be a regression unless intentional. Please verify this is correct.
| PV:pn-xdial = "1.0.0" | |
| PV:pn-xdial = "3.0.0" |
conf/include/generic-pkgrev.inc
Outdated
| PV:pn-rdmagent = "2.0.1" | ||
| PR:pn-rdmagent = "r1" | ||
| PV:pn-rdmagent = "2.1.1" | ||
| PR:pn-rdmagent = "r0" |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package revision reset from 'r1' to 'r0' while version increased. When bumping PV, PR should typically remain at its current value or increment, not reset to r0.
| PR:pn-rdmagent = "r0" | |
| PR:pn-rdmagent = "r1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| inherit packagegroup volatile-bind-gen | ||
|
|
||
| # For interim development and package depolyment to test should be using pre release tags |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'depolyment' to 'deployment'.
| # For interim development and package depolyment to test should be using pre release tags | |
| # For interim development and package deployment to test should be using pre release tags |
| PV = "2.12.0" | ||
| PV = "8.4.1.0" | ||
|
|
||
| # PRs are prefered to be be incremented during development stages for any updates in corresponding |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'prefered' to 'preferred' and removed duplicate 'be' word.
| # PRs are prefered to be be incremented during development stages for any updates in corresponding | |
| # PRs are preferred to be incremented during development stages for any updates in corresponding |
| echo "" | ||
| echo "=== Validation Summary ===" | ||
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent spacing in the FAILED output: PR Title has ' FAILED' (with leading space) while PR Description has 'FAILED' (no leading space). This makes the validation summary output inconsistent.
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" | |
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")" |
conf/include/generic-pkgrev.inc
Outdated
| PV:pn-rdkcertconfig = "1.0.0" | ||
| PV:pn-rdkcertconfig = "1.0.1" | ||
| PR:pn-rdkcertconfig = "r0" | ||
| PACKAGE_ARCH:rdkcertconfig = "${MIDDLEWARE_ARCH}" |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing colon separator in PACKAGE_ARCH assignment. Should be 'PACKAGE_ARCH:pn-rdkcertconfig' to match the pattern used in the rest of the file.
| PACKAGE_ARCH:rdkcertconfig = "${MIDDLEWARE_ARCH}" | |
| PACKAGE_ARCH:pn-rdkcertconfig = "${MIDDLEWARE_ARCH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458 Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
Rebase and merge
* Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc --------- Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
* Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-9558: Cleanup ripple calls in lifecyclemanager --------- Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-9849: Move memcapture to middleware layer
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC compliant and no longer depends on Thunder. Set initial versions of Firebolt C++ recipes. Risks: None Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec Signed-off-by: Tomasz Blaszczak <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CHANGELOG.md
Outdated
| @@ -4,8 +4,358 @@ All notable changes to this project will be documented in this file. Dates are d | |||
|
|
|||
| Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). | |||
|
|
|||
| #### [1.4.0](https://github.com/rdkcentral/meta-middleware-generic-support/compare/2.8.0-test4...1.4.0) | |||
| #### [1.13.1](https://github.com/rdkcentral/meta-middleware-generic-support/compare/2.8.0-test4...1.13.1) | |||
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title "rebase" is not descriptive and doesn't follow the expected format. PR titles should include a ticket ID (e.g., RDKEMW-XXXX) followed by a colon and a meaningful description of the changes. A rebase PR should still describe what is being rebased or merged.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH_pn-webconfig-framework = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}" | ||
|
|
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version for xdial has been changed from "3.0.0" to "1.0.1", which is a downgrade. This is unusual and could indicate a versioning error or a rollback. Verify that this version change is intentional and document the reason for the downgrade, as it could cause confusion or integration issues.
| # NOTE: xdial PV intentionally rolled back from 3.0.0 to 1.0.1 due to regressions/incompatibilities in 3.0.0. |
conf/include/generic-pkgrev.inc
Outdated
| PV:pn-thunder-hang-recovery = "1.0.0" | ||
| PR:pn-thunder-hang-recovery = "r0" | ||
| PACKAGE_ARCH:pn-thunder-hang-recovery = "${MIDDLEWARE_ARCH}" | ||
|
|
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package configuration for "pn-thunderhangrecovery" is being removed, but the new package "pn-thunder-hang-recovery" has been added. This is a rename operation. Ensure that any build systems or dependent configurations that reference "thunderhangrecovery" are updated to use "thunder-hang-recovery" to avoid build failures.
| # Backward compatibility aliases for the old package name. | |
| PV:pn-thunderhangrecovery = "${PV:pn-thunder-hang-recovery}" | |
| PR:pn-thunderhangrecovery = "${PR:pn-thunder-hang-recovery}" | |
| PACKAGE_ARCH:pn-thunderhangrecovery = "${PACKAGE_ARCH:pn-thunder-hang-recovery}" |
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-iarm-event-sender = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-iarm-query-powerstate = "1.0.4" | ||
| # All of these iarm-query-powerstate, iarm-set-powerstate, iarm-event-sender, |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on line 105 contains a typo: "iarm-query-powerstate" is missing a subject in the sentence. The comment should read "All of these: iarm-query-powerstate, iarm-set-powerstate, iarm-event-sender, key-simulator and mfr-utils use sys_mon_tools repo." or be restructured for clarity.
| # All of these iarm-query-powerstate, iarm-set-powerstate, iarm-event-sender, | |
| # All of these: iarm-query-powerstate, iarm-set-powerstate, iarm-event-sender, |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow uses deprecated actions/checkout version. Consider updating from actions/checkout@v4 to the latest version to ensure security patches and bug fixes are included. While v4 is relatively recent, it's good practice to use the latest stable version.
| uses: actions/checkout@v4 | |
| uses: actions/checkout@v4.2.0 |
|
|
||
| on: | ||
| pull_request: | ||
| branches: [develop] |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title validation workflow only validates PRs targeting the "develop" branch. However, this PR itself is titled "rebase" which doesn't follow the validation format (missing ticket ID). Consider whether this workflow should also validate PR titles for other branches like support branches, or document why it only applies to develop.
| branches: [develop] | |
| branches: | |
| - develop | |
| - 'support/**' |
Co-authored-by: ikavas409_comcast <[email protected]> Co-authored-by: madanagopalt <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc * Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-10493: copilot fix for static analysis issues --------- Co-authored-by: agampa263 <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-xdial = "3.0.0" | ||
| PV:pn-xdial = "1.0.1" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line for "PV:pn-xdial" shows a version decrease from "3.0.0" to "1.0.1". This is unusual and could indicate either a rollback or a versioning error. Please verify that this downgrade is intentional and document the reason for it.
| PV:pn-xdial = "1.0.1" | |
| PV:pn-xdial = "3.0.0" |
conf/include/generic-pkgrev.inc
Outdated
| PV:pn-thunder-hang-recovery = "1.0.0" | ||
| PR:pn-thunder-hang-recovery = "r0" | ||
| PACKAGE_ARCH:pn-thunder-hang-recovery = "${MIDDLEWARE_ARCH}" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name has been changed from "thunderhangrecovery" to "thunder-hang-recovery" (lines 301-303). This change must be consistent with the corresponding change in the packagegroup file and throughout the entire codebase. Verify that the recipe file has also been renamed accordingly.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-networkmanager-plugin = "0.22.0" | ||
| PV:pn-networkmanager-plugin = "v1.10.0" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "networkmanager-plugin" version has been changed from "0.22.0" to "v1.10.0". The addition of the "v" prefix is inconsistent with the previous versioning format. Ensure this is intentional and follows the component's versioning scheme. Mixed version formats (with and without "v" prefix) can cause confusion.
| PV:pn-networkmanager-plugin = "v1.10.0" | |
| PV:pn-networkmanager-plugin = "1.10.0" |
Reason for change: move recipe information closer to developer’s repos Test Procedure: see Jira ticket Risks: Low Priority: P1 Signed-off-by: Mahmoud El-haron <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
…ic-support into RDKEMW_11604
Version: Major Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
|
I have read the CLA Document and I hereby sign the CLA 17 out of 18 committers have signed the CLA. |
RDKEMW-11560: Update middleware package group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
No description provided.