-
Notifications
You must be signed in to change notification settings - Fork 16
bring latest changes #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: topic/rdkemw-7516
Are you sure you want to change the base?
bring latest changes #1479
Conversation
|
Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request brings in the latest changes to the middleware layer, primarily updating package versions and source revisions across multiple components. The changes include version bumps for core middleware packages, updated source commit references, and configuration adjustments including workflow enhancements and dependency updates.
Key changes:
- Updated middleware layer version from 8.3.2.0 to 8.3.4.0
- Renamed
thunderhangrecoverytothunder-hang-recoveryand added new dependencies - Updated source revisions (SRCREV) for approximately 30+ components with newer commit hashes
- Added new GitHub workflow for PR description validation and updated existing workflows
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Updated package version and runtime dependencies including package name changes and additions |
| conf/include/generic-srcrev.inc | Updated source revisions for multiple middleware components to point to newer commits |
| conf/include/generic-pkgrev.inc | Updated package versions across numerous middleware components and reorganized version definitions |
| .github/workflows/validate_pr_desc.yml | Added new workflow for validating PR title and description formats against ticket ID requirements |
| .github/workflows/fossid_integration_stateless_diffscan_target_repo.yml | Added new workflow for Fossid stateless diff scanning on pull requests |
| .github/workflows/cla.yml | Added new workflow for Contributor License Agreement checking |
| .github/workflows/auto_pr_creation_target_repo_caller.yml | Extended branch pattern matching to include versioned support branches |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
conf/include/generic-pkgrev.inc:1
- Extra space in FAILED output - should be 'FAILED' not ' FAILED'
PV:pn-apparmor-generic="1.1.0"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-xdial = "3.0.1" | ||
| PV:pn-xdial = "1.0.0" |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version for xdial is being downgraded from 3.0.1 to 1.0.0. This is unusual and could indicate an issue with versioning or a potential rollback that should be documented or verified.
| PV:pn-xdial = "1.0.0" | |
| PV:pn-xdial = "3.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| inherit packagegroup volatile-bind-gen | ||
|
|
||
| # For interim development and package depolyment to test should be using pre release tags |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'depolyment' to 'deployment'.
| # For interim development and package depolyment to test should be using pre release tags | |
| # For interim development and package deployment to test should be using pre release tags |
| PV = "8.3.2.0" | ||
| PV = "8.4.1.0" | ||
|
|
||
| # PRs are prefered to be be incremented during development stages for any updates in corresponding |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'prefered' to 'preferred'.
| # PRs are prefered to be be incremented during development stages for any updates in corresponding | |
| # PRs are preferred to be be incremented during development stages for any updates in corresponding |
| PV = "8.3.2.0" | ||
| PV = "8.4.1.0" | ||
|
|
||
| # PRs are prefered to be be incremented during development stages for any updates in corresponding |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed duplicate word 'be' in comment.
| # PRs are prefered to be be incremented during development stages for any updates in corresponding | |
| # PRs are prefered to be incremented during development stages for any updates in corresponding |
conf/include/generic-pkgrev.inc
Outdated
|
|
||
| PV:pn-rbus = "2.6.0" | ||
| PR:pn-rbus = "r7" | ||
| PV:pn-rbus = "2.9.0" |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The PR (package release) value was changed from 'r7' to 'r0'. When bumping a major/minor version (2.6.0 → 2.9.0), resetting PR to r0 is correct. However, consider documenting this convention in comments to make the rationale clear for future maintainers.
| PV:pn-rbus = "2.9.0" | |
| PV:pn-rbus = "2.9.0" | |
| # PR reset to r0 due to major/minor version bump (e.g., 2.6.0 → 2.9.0) as per packaging convention. |
| echo "" | ||
| echo "=== Validation Summary ===" | ||
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra space before 'FAILED' that creates inconsistent alignment with the 'PASSED' output. Remove the space for consistent formatting: echo \"PASSED\" || echo \"FAILED\".
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" | |
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458 Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
Rebase and merge
* Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc --------- Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
* Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-9558: Cleanup ripple calls in lifecyclemanager --------- Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-9849: Move memcapture to middleware layer
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC compliant and no longer depends on Thunder. Set initial versions of Firebolt C++ recipes. Risks: None Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec Signed-off-by: Tomasz Blaszczak <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Validate PR Title | ||
| env: | ||
| PR_TITLE: ${{ github.event.pull_request.title }} | ||
| PR_BODY: ${{ github.event.pull_request.body }} |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment variable PR_BODY is defined but never used in the workflow. If PR body validation is not needed, this variable should be removed to avoid confusion. If PR body validation was intended, the implementation is missing.
| PR_BODY: ${{ github.event.pull_request.body }} |
Co-authored-by: ikavas409_comcast <[email protected]> Co-authored-by: madanagopalt <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc * Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-10493: copilot fix for static analysis issues --------- Co-authored-by: agampa263 <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| libsyswrapper \ | ||
| libunpriv \ | ||
| logrotate \ | ||
| lsof \ |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package 'lsof' is listed in RDEPENDS but has no corresponding version configuration (PV, PR, PACKAGE_ARCH) in generic-pkgrev.inc. The version entries for lsof were removed (previously at lines 432-435 in generic-pkgrev.inc), but lsof is still referenced in the dependency list. Either restore the version configuration in generic-pkgrev.inc or remove lsof from RDEPENDS if it's no longer needed.
| lsof \ |
CHANGELOG.md
Outdated
| @@ -4,11 +4,309 @@ All notable changes to this project will be documented in this file. Dates are d | |||
|
|
|||
| Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). | |||
|
|
|||
| #### [1.8.0](https://github.com/rdkcentral/meta-middleware-generic-support/compare/2.8.0-test4...1.8.0) | |||
| #### [1.13.1](https://github.com/rdkcentral/meta-middleware-generic-support/compare/2.8.0-test4...1.13.1) | |||
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CHANGELOG version header shows "1.13.1" comparing from "2.8.0-test4" to "1.13.1", which represents a version downgrade (from 2.8.0 to 1.13.1). This is unusual and potentially indicates a versioning inconsistency. The packagegroup-middleware-layer.bb file shows version "8.4.2.1", which doesn't align with either version in the CHANGELOG. Verify that the version numbering scheme is correct and consistent across all files.
| #### [1.13.1](https://github.com/rdkcentral/meta-middleware-generic-support/compare/2.8.0-test4...1.13.1) | |
| #### [1.13.1](https://github.com/rdkcentral/meta-middleware-generic-support/compare/1.13.0...1.13.1) |
Reason for change: move recipe information closer to developer’s repos Test Procedure: see Jira ticket Risks: Low Priority: P1 Signed-off-by: Mahmoud El-haron <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
…ic-support into RDKEMW_11604
Version: Major Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
|
I have read the CLA Document and I hereby sign the CLA 17 out of 18 committers have signed the CLA. |
RDKEMW-11560: Update middleware package group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
No description provided.