-
Notifications
You must be signed in to change notification settings - Fork 16
RDKEMW-7398 : [AppManager] isInstalled Error Handling (#1551) #1571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: RDKEMW-7516_1
Are you sure you want to change the base?
Conversation
|
Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses error handling improvements in the AppManager's isInstalled functionality (RDKEMW-7398) and includes version bumps across multiple middleware components.
Key Changes:
- Updated middleware layer package version from 8.3.3.0 to 8.3.4.0
- Added sceneset package as a conditional runtime dependency
- Updated source revisions (SRCREV) for 30+ middleware components including iarmmgrs, aamp, hdmicec, rfc, and others
- Version bumps for numerous packages including devicesettings (1.0.18→1.0.22), rbus (2.6.0→2.9.0), aamp (2.8.0→2.9.2)
- Added three new GitHub workflow files for PR validation, FOSSID scanning, and CLA verification
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Bumped package version and added conditional sceneset dependency |
| conf/include/generic-srcrev.inc | Updated source revisions for 30+ middleware components and added new package entries |
| conf/include/generic-pkgrev.inc | Updated package versions across middleware stack and consolidated related packages |
| .github/workflows/validate_pr_desc.yml | Added new workflow to validate PR title and description format |
| .github/workflows/fossid_integration_stateless_diffscan_target_repo.yml | Added FOSSID security scanning workflow |
| .github/workflows/cla.yml | Added CLA signature verification workflow |
| .github/workflows/auto_pr_creation_target_repo_caller.yml | Extended branch pattern to include versioned support branches |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| inherit packagegroup volatile-bind-gen | ||
|
|
||
| # For interim development and package depolyment to test should be using pre release tags |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'depolyment' to 'deployment'.
| # For interim development and package depolyment to test should be using pre release tags | |
| # For interim development and package deployment to test should be using pre release tags |
| PV = "8.3.3.0" | ||
| PV = "8.4.1.0" | ||
|
|
||
| # PRs are prefered to be be incremented during development stages for any updates in corresponding |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'prefered' to 'preferred' and removed duplicate word 'be'.
| # PRs are prefered to be be incremented during development stages for any updates in corresponding | |
| # PRs are preferred to be incremented during development stages for any updates in corresponding |
conf/include/generic-pkgrev.inc
Outdated
|
|
||
| PV:pn-iarm-query-powerstate = "1.0.6" | ||
| # All of these iarm-query-powerstate, iarm-set-powerstate, iarm-event-sender, | ||
| # key-simulator and mfr-utils use sys_mon_tools repo. |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding a reference to the sys_mon_tools repository URL or location in this comment to make it easier for developers to locate the shared source.
| # key-simulator and mfr-utils use sys_mon_tools repo. | |
| # key-simulator and mfr-utils use sys_mon_tools repo (see: https://github.com/example-org/sys_mon_tools). |
| echo "" | ||
| echo "=== Validation Summary ===" | ||
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent spacing in validation summary: 'PASSED' and ' FAILED' have different leading spaces. The space before 'FAILED' should be removed for consistent output formatting.
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" | |
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458 Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
Rebase and merge
* Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc --------- Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
* Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-9558: Cleanup ripple calls in lifecyclemanager --------- Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-9849: Move memcapture to middleware layer
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC compliant and no longer depends on Thunder. Set initial versions of Firebolt C++ recipes. Risks: None Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec Signed-off-by: Tomasz Blaszczak <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PV:pn-systimemgrinetrface = "1.4.0" | ||
| PR:pn-systimemgrinetrface = "r0" | ||
| PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name "systimemgrinetrface" appears to be a misspelling of "systimemgrinterface". The word "inetrface" should be "interface".
| PV:pn-systimemgrinetrface = "1.4.0" | |
| PR:pn-systimemgrinetrface = "r0" | |
| PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}" | |
| PV:pn-systimemgrinterface = "1.4.0" | |
| PR:pn-systimemgrinterface = "r0" | |
| PACKAGE_ARCH:pn-systimemgrinterface = "${MIDDLEWARE_ARCH}" |
Co-authored-by: ikavas409_comcast <[email protected]> Co-authored-by: madanagopalt <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc * Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-10493: copilot fix for static analysis issues --------- Co-authored-by: agampa263 <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PV:pn-systimemgrinetrface = "1.4.0" | ||
| PR:pn-systimemgrinetrface = "r0" | ||
| PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the comment. The word "inetrface" should be "interface".
| PV:pn-systimemgrinetrface = "1.4.0" | |
| PR:pn-systimemgrinetrface = "r0" | |
| PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}" | |
| PV:pn-systimemgrinterface = "1.4.0" | |
| PR:pn-systimemgrinterface = "r0" | |
| PACKAGE_ARCH:pn-systimemgrinterface = "${MIDDLEWARE_ARCH}" |
conf/include/generic-srcrev.inc
Outdated
| SRCREV:pn-rialto-gstreamer = "d91ab82133a6071eb1bdc360e59a390e9704925c" | ||
| SRCREV:pn-rialto = "61f6aa83b2dd5abe40dae6a1b64d6c153f2a0eaa" | ||
| SRCREV:pn-rialto-ocdm = "4f8e4556754cde3498d960d47fd0827f997ea43b" | ||
| SRCREV:pn-xmidt-agent = "a42eef93f5f129da6a25f1ce5386b2ee" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SRCREV for xmidt-agent appears to be incomplete. Git commit hashes should be 40 characters (full SHA-1) or at least 7-8 characters for short hashes. This value "a42eef93f5f129da6a25f1ce5386b2ee" is only 32 characters, which is unusual. Please verify this is the correct commit hash format for this package.
| SRCREV:pn-xmidt-agent = "a42eef93f5f129da6a25f1ce5386b2ee" | |
| SRCREV:pn-xmidt-agent = "a42eef93f5f129da6a25f1ce5386b2ee00000000" |
| - name: Validate PR Title | ||
| env: | ||
| PR_TITLE: ${{ github.event.pull_request.title }} | ||
| PR_BODY: ${{ github.event.pull_request.body }} |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment variable PR_BODY is defined but never used in the script. Consider removing it to avoid confusion, or if it's intended for future use, add a comment explaining its purpose.
| PR_BODY: ${{ github.event.pull_request.body }} |
Reason for change: move recipe information closer to developer’s repos Test Procedure: see Jira ticket Risks: Low Priority: P1 Signed-off-by: Mahmoud El-haron <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
…ic-support into RDKEMW_11604
Version: Major Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
|
I have read the CLA Document and I hereby sign the CLA 17 out of 18 committers have signed the CLA. |
RDKEMW-11560: Update middleware package group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Reason for change: Fixing isInstalled Error Handling issue.
Test Procedure: verified
Risks: Low
Priority: P2
Signed-off-by: Sourav Dutta [email protected]
Signed-off-by: Sourav Dutta [email protected]