Skip to content

Conversation

@madanagopalt
Copy link
Contributor

Reason for change: Fixing isInstalled Error Handling issue.
Test Procedure: verified
Risks: Low
Priority: P2
Signed-off-by: Sourav Dutta [email protected]

Signed-off-by: Sourav Dutta [email protected]

@madanagopalt madanagopalt requested review from a team as code owners September 15, 2025 16:51
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 21 committers have signed the CLA.

✅ ssitar583
✅ yuvaramachandran-gurusamy
✅ egalla204
✅ plaksh002c-public
✅ dkumar798
✅ klu339
✅ AravindanNC
❌ Adrian Muzyka
❌ satlead
❌ rosemarybennyy
❌ nhanasi
❌ pkumbh631
❌ rdkcm-rdke
❌ rekhap2kandhavelan
❌ satya200
❌ anand-ky
❌ sborushevsky
❌ preeja33
❌ arun-madhavan-013
❌ divyang-public
❌ tharun-kumarv


Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI review requested due to automatic review settings October 28, 2025 14:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses error handling improvements in the AppManager's isInstalled functionality (RDKEMW-7398) and includes version bumps across multiple middleware components.

Key Changes:

  • Updated middleware layer package version from 8.3.3.0 to 8.3.4.0
  • Added sceneset package as a conditional runtime dependency
  • Updated source revisions (SRCREV) for 30+ middleware components including iarmmgrs, aamp, hdmicec, rfc, and others
  • Version bumps for numerous packages including devicesettings (1.0.18→1.0.22), rbus (2.6.0→2.9.0), aamp (2.8.0→2.9.2)
  • Added three new GitHub workflow files for PR validation, FOSSID scanning, and CLA verification

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
recipes-core/packagegroups/packagegroup-middleware-layer.bb Bumped package version and added conditional sceneset dependency
conf/include/generic-srcrev.inc Updated source revisions for 30+ middleware components and added new package entries
conf/include/generic-pkgrev.inc Updated package versions across middleware stack and consolidated related packages
.github/workflows/validate_pr_desc.yml Added new workflow to validate PR title and description format
.github/workflows/fossid_integration_stateless_diffscan_target_repo.yml Added FOSSID security scanning workflow
.github/workflows/cla.yml Added CLA signature verification workflow
.github/workflows/auto_pr_creation_target_repo_caller.yml Extended branch pattern to include versioned support branches

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 28, 2025 16:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 29, 2025 19:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


inherit packagegroup volatile-bind-gen

# For interim development and package depolyment to test should be using pre release tags
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'depolyment' to 'deployment'.

Suggested change
# For interim development and package depolyment to test should be using pre release tags
# For interim development and package deployment to test should be using pre release tags

Copilot uses AI. Check for mistakes.
PV = "8.3.3.0"
PV = "8.4.1.0"

# PRs are prefered to be be incremented during development stages for any updates in corresponding
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'prefered' to 'preferred' and removed duplicate word 'be'.

Suggested change
# PRs are prefered to be be incremented during development stages for any updates in corresponding
# PRs are preferred to be incremented during development stages for any updates in corresponding

Copilot uses AI. Check for mistakes.

PV:pn-iarm-query-powerstate = "1.0.6"
# All of these iarm-query-powerstate, iarm-set-powerstate, iarm-event-sender,
# key-simulator and mfr-utils use sys_mon_tools repo.
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a reference to the sys_mon_tools repository URL or location in this comment to make it easier for developers to locate the shared source.

Suggested change
# key-simulator and mfr-utils use sys_mon_tools repo.
# key-simulator and mfr-utils use sys_mon_tools repo (see: https://github.com/example-org/sys_mon_tools).

Copilot uses AI. Check for mistakes.
echo ""
echo "=== Validation Summary ==="
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")"
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent spacing in validation summary: 'PASSED' and ' FAILED' have different leading spaces. The space before 'FAILED' should be removed for consistent output formatting.

Suggested change
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")"
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 30, 2025 19:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

satlead and others added 8 commits October 31, 2025 03:23
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458

Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

---------

Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
Copilot AI review requested due to automatic review settings October 31, 2025 12:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

madanagopalt and others added 5 commits October 31, 2025 08:57
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-9558: Cleanup ripple calls in lifecyclemanager

---------

Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
Copilot AI review requested due to automatic review settings October 31, 2025 15:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

filipe-norte-red and others added 7 commits December 18, 2025 14:19
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC
compliant and no longer depends on Thunder.

Set initial versions of Firebolt C++ recipes.

Risks: None


Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec

Signed-off-by: Tomasz Blaszczak <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 179 to 181
PV:pn-systimemgrinetrface = "1.4.0"
PR:pn-systimemgrinetrface = "r0"
PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name "systimemgrinetrface" appears to be a misspelling of "systimemgrinterface". The word "inetrface" should be "interface".

Suggested change
PV:pn-systimemgrinetrface = "1.4.0"
PR:pn-systimemgrinetrface = "r0"
PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}"
PV:pn-systimemgrinterface = "1.4.0"
PR:pn-systimemgrinterface = "r0"
PACKAGE_ARCH:pn-systimemgrinterface = "${MIDDLEWARE_ARCH}"

Copilot uses AI. Check for mistakes.
IshvarKR and others added 2 commits December 19, 2025 11:26
Co-authored-by: ikavas409_comcast <[email protected]>
Co-authored-by: madanagopalt <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-10493: copilot fix for static analysis issues

---------

Co-authored-by: agampa263 <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 179 to 181
PV:pn-systimemgrinetrface = "1.4.0"
PR:pn-systimemgrinetrface = "r0"
PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the comment. The word "inetrface" should be "interface".

Suggested change
PV:pn-systimemgrinetrface = "1.4.0"
PR:pn-systimemgrinetrface = "r0"
PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}"
PV:pn-systimemgrinterface = "1.4.0"
PR:pn-systimemgrinterface = "r0"
PACKAGE_ARCH:pn-systimemgrinterface = "${MIDDLEWARE_ARCH}"

Copilot uses AI. Check for mistakes.
SRCREV:pn-rialto-gstreamer = "d91ab82133a6071eb1bdc360e59a390e9704925c"
SRCREV:pn-rialto = "61f6aa83b2dd5abe40dae6a1b64d6c153f2a0eaa"
SRCREV:pn-rialto-ocdm = "4f8e4556754cde3498d960d47fd0827f997ea43b"
SRCREV:pn-xmidt-agent = "a42eef93f5f129da6a25f1ce5386b2ee"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SRCREV for xmidt-agent appears to be incomplete. Git commit hashes should be 40 characters (full SHA-1) or at least 7-8 characters for short hashes. This value "a42eef93f5f129da6a25f1ce5386b2ee" is only 32 characters, which is unusual. Please verify this is the correct commit hash format for this package.

Suggested change
SRCREV:pn-xmidt-agent = "a42eef93f5f129da6a25f1ce5386b2ee"
SRCREV:pn-xmidt-agent = "a42eef93f5f129da6a25f1ce5386b2ee00000000"

Copilot uses AI. Check for mistakes.
- name: Validate PR Title
env:
PR_TITLE: ${{ github.event.pull_request.title }}
PR_BODY: ${{ github.event.pull_request.body }}
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable PR_BODY is defined but never used in the script. Consider removing it to avoid confusion, or if it's intended for future use, add a comment explaining its purpose.

Suggested change
PR_BODY: ${{ github.event.pull_request.body }}

Copilot uses AI. Check for mistakes.
melhar098 and others added 6 commits December 19, 2025 14:56
Reason for change: move recipe information closer to developer’s repos
Test Procedure: see Jira ticket
Risks: Low
Priority: P1

Signed-off-by: Mahmoud El-haron <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Version: Major
Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
Copilot AI review requested due to automatic review settings January 5, 2026 15:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

divyang-public and others added 2 commits January 5, 2026 17:53
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
@github-actions
Copy link

github-actions bot commented Jan 9, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


17 out of 18 committers have signed the CLA.
✅ (satlead)[https://github.com/satlead]
✅ (Vismalskumar0)[https://github.com/Vismalskumar0]
✅ (madanagopalt)[https://github.com/madanagopalt]
✅ (nhanasi)[https://github.com/nhanasi]
✅ (anand-ky)[https://github.com/anand-ky]
✅ (rdkcm-rdke)[https://github.com/rdkcm-rdke]
✅ (gurpreet319)[https://github.com/gurpreet319]
✅ (yuvaramachandran-gurusamy)[https://github.com/yuvaramachandran-gurusamy]
✅ (ks734)[https://github.com/ks734]
✅ (vjain008)[https://github.com/vjain008]
✅ (divyang-public)[https://github.com/divyang-public]
✅ (muthushiamsankar)[https://github.com/muthushiamsankar]
✅ (AravindanNC)[https://github.com/AravindanNC]
✅ (sindhu-krishnan)[https://github.com/sindhu-krishnan]
✅ (satya200)[https://github.com/satya200]
✅ (egalla204)[https://github.com/egalla204]
✅ (sborushevsky)[https://github.com/sborushevsky]
@rekhap2kandhavelan
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI review requested due to automatic review settings January 9, 2026 18:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.