Skip to content

Conversation

@madanagopalt
Copy link
Contributor

No description provided.

@madanagopalt madanagopalt requested review from a team as code owners September 16, 2025 06:08
@CLAassistant
Copy link

CLAassistant commented Sep 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 21 committers have signed the CLA.

✅ ssitar583
✅ yuvaramachandran-gurusamy
✅ egalla204
✅ plaksh002c-public
✅ dkumar798
✅ klu339
✅ AravindanNC
❌ Adrian Muzyka
❌ satlead
❌ rosemarybennyy
❌ satya200
❌ rdkcm-rdke
❌ sborushevsky
❌ rekhap2kandhavelan
❌ preeja33
❌ pkumbh631
❌ nhanasi
❌ anand-ky
❌ divyang-public
❌ tharun-kumarv
❌ arun-madhavan-013


Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI review requested due to automatic review settings October 28, 2025 14:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request brings the latest changes to the middleware layer, primarily updating component versions and source revisions, adding new packages, and implementing GitHub workflow automation.

  • Version bumps for multiple middleware components (e.g., packagegroup-middleware-layer from 8.3.3.0 to 8.3.4.0)
  • Addition of sceneset package support with conditional inclusion based on DISTRO_FEATURES
  • Implementation of PR validation, CLA, and FossID scanning workflows

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
recipes-core/packagegroups/packagegroup-middleware-layer.bb Updated package version and added conditional sceneset dependency
conf/include/generic-srcrev.inc Updated source revisions for 30+ middleware components and added new package SRCREVs
conf/include/generic-pkgrev.inc Updated package versions for middleware components and consolidated iarm-related package configurations
.github/workflows/validate_pr_desc.yml Added new workflow for validating PR title and description format with ticket ID requirements
.github/workflows/fossid_integration_stateless_diffscan_target_repo.yml Added FossID scanning workflow for license compliance
.github/workflows/cla.yml Added Contributor License Agreement workflow
.github/workflows/auto_pr_creation_target_repo_caller.yml Extended branch trigger pattern to support version-specific branches

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 28, 2025 16:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 29, 2025 19:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


inherit packagegroup volatile-bind-gen

# For interim development and package depolyment to test should be using pre release tags
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'depolyment' to 'deployment'.

Suggested change
# For interim development and package depolyment to test should be using pre release tags
# For interim development and package deployment to test should be using pre release tags

Copilot uses AI. Check for mistakes.
PV = "8.3.3.0"
PV = "8.4.1.0"

# PRs are prefered to be be incremented during development stages for any updates in corresponding
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'prefered' to 'preferred' and removed duplicate 'be'.

Suggested change
# PRs are prefered to be be incremented during development stages for any updates in corresponding
# PRs are preferred to be incremented during development stages for any updates in corresponding

Copilot uses AI. Check for mistakes.
wlan-p2p \
thunder-hang-recovery \
thunder-plugin-activator \
${@bb.utils.contains('DISTRO_FEATURES', 'sceneset', " sceneset ", "", d)} \
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sceneset conditional dependency has unnecessary spaces around the package name. Consider removing the extra spaces for consistency with other package entries: "sceneset" instead of " sceneset ".

Suggested change
${@bb.utils.contains('DISTRO_FEATURES', 'sceneset', " sceneset ", "", d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'sceneset', "sceneset", "", d)} \

Copilot uses AI. Check for mistakes.
echo ""
echo "=== Validation Summary ==="
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")"
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency in spacing - line 102 has an extra space before "FAILED" while line 103 does not. Consider making them consistent by removing the extra space: echo "PASSED" || echo "FAILED".

Suggested change
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")"
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 30, 2025 19:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

satlead and others added 8 commits October 31, 2025 03:23
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458

Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

---------

Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
Copilot AI review requested due to automatic review settings October 31, 2025 12:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

madanagopalt and others added 5 commits October 31, 2025 08:57
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-9558: Cleanup ripple calls in lifecyclemanager

---------

Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
Copilot AI review requested due to automatic review settings October 31, 2025 15:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

filipe-norte-red and others added 7 commits December 18, 2025 14:19
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC
compliant and no longer depends on Thunder.

Set initial versions of Firebolt C++ recipes.

Risks: None


Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec

Signed-off-by: Tomasz Blaszczak <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}"

PV:pn-xdial = "3.0.1"
PV:pn-xdial = "1.0.1"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version for xdial is being changed from "3.0.1" to "1.0.1", which appears to be a downgrade. Please verify this is intentional and not a mistake, as downgrades are unusual in normal development flow.

Suggested change
PV:pn-xdial = "1.0.1"
PV:pn-xdial = "3.0.1"

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}"

PV:pn-networkmanager-plugin = "1.0.0"
PV:pn-networkmanager-plugin = "v1.10.0"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version format for networkmanager-plugin is inconsistent with other packages. It uses "v1.10.0" with a 'v' prefix, while all other packages in this file use plain version numbers without prefix. Consider removing the 'v' prefix for consistency.

Suggested change
PV:pn-networkmanager-plugin = "v1.10.0"
PV:pn-networkmanager-plugin = "1.10.0"

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,81 @@
name: RDK-E Middleware Change Request
description: Change Request for RDK-E Middleware
title: "<JIRA TICKET>:<Ticket Title> "
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title template includes a trailing space after the closing angle bracket: "<JIRA TICKET>:<Ticket Title> ". Consider removing the trailing space to avoid users creating issues with unintended whitespace in titles.

Suggested change
title: "<JIRA TICKET>:<Ticket Title> "
title: "<JIRA TICKET>:<Ticket Title>"

Copilot uses AI. Check for mistakes.
- rebase [`#1895`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1895)
- Update generic-pkgrev.inc [`#1827`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1827)
- RDKEMW-6942: Download manager updates [`#1883`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1883)
- bring latest changes [`#1889`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1889)
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry on line 82 appears to be a duplicate or very similar to the entry being added on line 9 ("bring latest changes"). Consider whether this is intentional or if one should reference a different ticket/PR.

Suggested change
- bring latest changes [`#1889`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1889)
- Maintenance: sync with latest upstream changes [`#1889`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1889)

Copilot uses AI. Check for mistakes.

#### [2.8.0-test4](https://github.com/rdkcentral/meta-middleware-generic-support/compare/2.8.0-test3...2.8.0-test4)

> 26 March 2025

- Updating the changelog and revision in Recipe file for 2.8.0-test4 [`7a7870f`](https://github.com/rdkcentral/meta-middleware-generic-support/commit/7a7870f9bbf5f081df5d7d2a35ea859005541123)

#### [2.8.0-test3](https://github.com/rdkcentral/meta-middleware-generic-support/compare/1.7.1...2.8.0-test3)
#### [2.8.0-test3](https://github.com/rdkcentral/meta-middleware-generic-support/compare/1.13.0...2.8.0-test3)

> 26 March 2025
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date "26 March 2025" appears to be in the future. Since the current date is December 19, 2025, this date in March 2025 has already passed. However, the date format suggests this might have been set incorrectly or this is test data. Please verify the date is correct for this release.

Copilot uses AI. Check for mistakes.
- RDKEMW-4708: Replacing IARM Power manager with Power Manager Plugin [`#1178`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1178)
- RDKEMW-4009: Add new AVI info frame APIs [`#1130`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1130)
- RDKEMW-6582: Improve the ARC volume logo smoothness during the Volume +/- press and hold scenario [`#1172`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1172)
- RDKEMW-6672: Memcr ver from 22.07.2025 [`#1169`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1169)
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date "22.07.2025" appears to reference July 22, 2025, which has already passed based on the current date of December 19, 2025. However, this date appears in the context of "Memcr ver from 22.07.2025", which might be referencing a version identifier rather than a release date. If this is meant to be a version identifier, consider clarifying the format to avoid confusion with dates.

Suggested change
- RDKEMW-6672: Memcr ver from 22.07.2025 [`#1169`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1169)
- RDKEMW-6672: Memcr version 22.07.2025 (version identifier) [`#1169`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/1169)

Copilot uses AI. Check for mistakes.
IshvarKR and others added 2 commits December 19, 2025 11:26
Co-authored-by: ikavas409_comcast <[email protected]>
Co-authored-by: madanagopalt <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-10493: copilot fix for static analysis issues

---------

Co-authored-by: agampa263 <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

melhar098 and others added 6 commits December 19, 2025 14:56
Reason for change: move recipe information closer to developer’s repos
Test Procedure: see Jira ticket
Risks: Low
Priority: P1

Signed-off-by: Mahmoud El-haron <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Version: Major
Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
Copilot AI review requested due to automatic review settings January 5, 2026 15:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

divyang-public and others added 2 commits January 5, 2026 17:53
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
@github-actions
Copy link

github-actions bot commented Jan 9, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


17 out of 18 committers have signed the CLA.
✅ (satlead)[https://github.com/satlead]
✅ (Vismalskumar0)[https://github.com/Vismalskumar0]
✅ (madanagopalt)[https://github.com/madanagopalt]
✅ (nhanasi)[https://github.com/nhanasi]
✅ (anand-ky)[https://github.com/anand-ky]
✅ (rdkcm-rdke)[https://github.com/rdkcm-rdke]
✅ (gurpreet319)[https://github.com/gurpreet319]
✅ (yuvaramachandran-gurusamy)[https://github.com/yuvaramachandran-gurusamy]
✅ (ks734)[https://github.com/ks734]
✅ (vjain008)[https://github.com/vjain008]
✅ (divyang-public)[https://github.com/divyang-public]
✅ (muthushiamsankar)[https://github.com/muthushiamsankar]
✅ (AravindanNC)[https://github.com/AravindanNC]
✅ (sindhu-krishnan)[https://github.com/sindhu-krishnan]
✅ (satya200)[https://github.com/satya200]
✅ (egalla204)[https://github.com/egalla204]
✅ (sborushevsky)[https://github.com/sborushevsky]
@rekhap2kandhavelan
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI review requested due to automatic review settings January 9, 2026 18:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.