-
Notifications
You must be signed in to change notification settings - Fork 16
bring latest changes #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: topic/RDKEMW-7855
Are you sure you want to change the base?
bring latest changes #1609
Conversation
|
Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR brings latest changes from upstream, updating package versions, source revisions, and adding new GitHub workflow automation. The main updates include version bumps for middleware components, addition of new packages (sceneset, packager-headers), and integration of PR validation and CLA workflows.
Key Changes:
- Updated 50+ package versions and source revisions across middleware components
- Added sceneset package with conditional inclusion based on DISTRO_FEATURES
- Integrated new GitHub workflows for PR description validation, FOSSID scanning, and CLA management
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Bumped version to 8.3.4.0 and added conditional sceneset dependency |
| conf/include/generic-srcrev.inc | Updated 48 source revisions and reorganized entries for better maintainability |
| conf/include/generic-pkgrev.inc | Updated 35 package versions and consolidated sys_mon_tools related packages |
| .github/workflows/validate_pr_desc.yml | Added new PR validation workflow to enforce ticket ID format in titles and descriptions |
| .github/workflows/fossid_integration_stateless_diffscan_target_repo.yml | Added FOSSID stateless diff scan workflow for license compliance |
| .github/workflows/cla.yml | Added CLA signature verification workflow |
| .github/workflows/auto_pr_creation_target_repo_caller.yml | Extended branch pattern to support version-specific support branches |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }} | ||
| FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }} | ||
| FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }} | ||
| FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }} |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation: The 'secrets:' section uses 8 spaces instead of the standard 4 or 2 spaces used in YAML workflows.
| FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }} | |
| FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }} | |
| FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }} | |
| FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }} | |
| FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }} | |
| FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }} | |
| FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }} | |
| FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| inherit packagegroup volatile-bind-gen | ||
|
|
||
| # For interim development and package depolyment to test should be using pre release tags |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'depolyment' to 'deployment'.
| # For interim development and package depolyment to test should be using pre release tags | |
| # For interim development and package deployment to test should be using pre release tags |
| PV = "8.3.2.0" | ||
| PV = "8.4.1.0" | ||
|
|
||
| # PRs are prefered to be be incremented during development stages for any updates in corresponding |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'prefered' to 'preferred' and removed duplicate 'be'.
| # PRs are prefered to be be incremented during development stages for any updates in corresponding | |
| # PRs are preferred to be incremented during development stages for any updates in corresponding |
| echo "" | ||
| echo "=== Validation Summary ===" | ||
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent spacing in output: 'PASSED' has no leading space while 'FAILED' has a leading space. This creates misaligned output. Remove the leading space from ' FAILED' to maintain consistent formatting.
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" | |
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458 Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
Rebase and merge
* Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc --------- Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
* Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-9558: Cleanup ripple calls in lifecyclemanager --------- Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-9849: Move memcapture to middleware layer
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC compliant and no longer depends on Thunder. Set initial versions of Firebolt C++ recipes. Risks: None Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec Signed-off-by: Tomasz Blaszczak <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "Validating $field_name: $text" | ||
| # Check if text matches the pattern <TICKETID>-<ticketno.> : <desc> |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment states "Check if text matches the pattern -<ticketno.> : " but the actual regex pattern used on line 31 is ^[A-Z0-9]+-[0-9]+[[:space:]]*:[[:space:]]*.+. This pattern requires at least one character after the colon (.+), which means a description is mandatory. However, the comment uses "" without indicating it's required. For clarity, the comment should state "matches the pattern -<ticketno.> : " to make it clear that a description is required.
| # Check if text matches the pattern <TICKETID>-<ticketno.> : <desc> | |
| # Check if text matches the pattern <TICKETID>-<ticketno.> : <description> |
| echo "=== Validating PR Title ===" | ||
| if ! validate_ticket "$PR_TITLE" "PR title"; then | ||
| echo "" | ||
| echo "VALIDATION FAILED: PR title must contain a valid ticket ID from the approved list: ${VALID_TICKET_IDS[@]}" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the shell script, the array VALID_TICKET_IDS is accessed with "${VALID_TICKET_IDS[@]}" on line 81 to display error messages. However, when displayed in the error message without proper formatting, this will show all ticket IDs concatenated without clear separators. Consider using printf '%s\n' "${VALID_TICKET_IDS[@]}" as done on line 37, or use ${VALID_TICKET_IDS[*]} with proper quoting for comma-separated display in the error message for better readability.
| echo "VALIDATION FAILED: PR title must contain a valid ticket ID from the approved list: ${VALID_TICKET_IDS[@]}" | |
| echo "VALIDATION FAILED: PR title must contain a valid ticket ID from the approved list." | |
| echo "Valid ticket IDs are:" | |
| printf "%s\n" "${VALID_TICKET_IDS[@]}" |
| @@ -0,0 +1,81 @@ | |||
| name: RDK-E Middleware Change Request | |||
| description: Change Request for RDK-E Middleware | |||
| title: "<JIRA TICKET>:<Ticket Title> " | |||
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title template uses angle brackets around placeholder text: ": ". However, this format is inconsistent with the validation workflow that expects the format "TICKETID-number : description" (e.g., "RDKEMW-123 : Fix issue"). The template should be updated to match the validation format, such as "TICKETID-number : Ticket Title" to avoid confusion and validation failures.
| title: "<JIRA TICKET>:<Ticket Title> " | |
| title: "TICKETID-number : Ticket Title" |
| PV = "8.3.2.0" | ||
| PV = "8.4.2.1" | ||
|
|
||
| # PRs are prefered to be be incremented during development stages for any updates in corresponding |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment contains a typo: "PRs are prefered to be be incremented" should be "PRs are preferred to be incremented". There are two issues here: "prefered" should be "preferred" (correct spelling), and there's a duplicate "be".
| # PRs are prefered to be be incremented during development stages for any updates in corresponding | |
| # PRs are preferred to be incremented during development stages for any updates in corresponding |
|
|
||
| inherit packagegroup volatile-bind-gen | ||
|
|
||
| # For interim development and package depolyment to test should be using pre release tags |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment contains a typo: "package depolyment" should be "package deployment". The word "depolyment" is misspelled.
| # For interim development and package depolyment to test should be using pre release tags | |
| # For interim development and package deployment to test should be using pre release tags |
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-networkmanager-plugin = "1.0.0" | ||
| PV:pn-networkmanager-plugin = "v1.10.0" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string for networkmanager-plugin is inconsistent with other version formats in this file. It uses "v1.10.0" with a "v" prefix, while all other packages use plain version numbers without the "v" prefix (e.g., "1.3.0", "4.2.0", etc.). This should be "1.10.0" for consistency.
| PV:pn-networkmanager-plugin = "v1.10.0" | |
| PV:pn-networkmanager-plugin = "1.10.0" |
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-xdial = "3.0.1" | ||
| PV:pn-xdial = "1.0.1" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string for xdial has been changed from "3.0.1" to "1.0.1", which represents a major version downgrade from 3.x to 1.x. This appears to be unusual and potentially incorrect. Please verify that this downgrade is intentional and not a mistake.
| PV:pn-xdial = "1.0.1" | |
| PV:pn-xdial = "3.0.1" |
Co-authored-by: ikavas409_comcast <[email protected]> Co-authored-by: madanagopalt <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc * Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-10493: copilot fix for static analysis issues --------- Co-authored-by: agampa263 <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Define valid ticket IDs | ||
| VALID_TICKET_IDS=("RDKEMW" "RDKEVD" "IMMUI" "RDK") |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of valid ticket IDs is defined with IMMUI included, but the actual regex pattern only matches alphanumeric characters. Consider if IMMUI is a valid format (it contains only letters). Additionally, document what each ticket ID represents to make the validation more maintainable.
Reason for change: move recipe information closer to developer’s repos Test Procedure: see Jira ticket Risks: Low Priority: P1 Signed-off-by: Mahmoud El-haron <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
…ic-support into RDKEMW_11604
Version: Major Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
|
I have read the CLA Document and I hereby sign the CLA 17 out of 18 committers have signed the CLA. |
RDKEMW-11560: Update middleware package group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
No description provided.