-
Notifications
You must be signed in to change notification settings - Fork 16
bring latest changes #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: topic/RDKEMW-6882
Are you sure you want to change the base?
bring latest changes #1639
Conversation
|
Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR brings latest changes by updating component versions, source revisions, and adding CI workflow configurations. The changes include version bumps for multiple middleware packages and introduction of new GitHub Actions workflows for PR validation and scanning.
- Updated package versions (PV) and source revisions (SRCREV) for approximately 30 middleware components
- Added new sceneset and packager-headers components with their version configurations
- Introduced GitHub Actions workflows for PR description validation, Fossid scanning, CLA checking, and auto-PR creation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Bumped package version to 8.3.4.0 and added conditional sceneset dependency |
| conf/include/generic-srcrev.inc | Updated source revisions for multiple components and added new component entries |
| conf/include/generic-pkgrev.inc | Updated package versions across middleware components and consolidated duplicate entries |
| .github/workflows/validate_pr_desc.yml | Added new workflow for validating PR title and description format |
| .github/workflows/fossid_integration_stateless_diffscan_target_repo.yml | Added Fossid stateless diff scan workflow |
| .github/workflows/cla.yml | Added CLA signature verification workflow |
| .github/workflows/auto_pr_creation_target_repo_caller.yml | Extended branch pattern to support versioned support branches |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-xdial = "3.0.1" | ||
| PV:pn-xdial = "1.0.0" |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xdial version is being downgraded from 3.0.1 to 1.0.0. This appears to be a regression that could introduce compatibility issues or remove features. If this is intentional, it should be explicitly documented in the PR description.
| PV:pn-xdial = "1.0.0" | |
| PV:pn-xdial = "3.0.1" |
conf/include/generic-pkgrev.inc
Outdated
| # All of these iarm-query-powerstate, iarm-set-powerstate, iarm-event-sender, | ||
| # key-simulator and mfr-utils use sys_mon_tools repo. |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comment describes a shared repository relationship but doesn't explain why these packages now derive their version from iarm-query-powerstate (lines 111-125). Consider adding a note explaining this consolidation to improve maintainability.
| # All of these iarm-query-powerstate, iarm-set-powerstate, iarm-event-sender, | |
| # key-simulator and mfr-utils use sys_mon_tools repo. | |
| # The following packages (iarm-query-powerstate, iarm-set-powerstate, iarm-event-sender, | |
| # key-simulator, and mfr-utils) are all built from the sys_mon_tools repository. | |
| # To ensure consistency and avoid version mismatches, their PV and PR values are | |
| # derived from iarm-query-powerstate. This consolidation means all these packages | |
| # will always share the same version and release, reflecting the state of the shared source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| inherit packagegroup volatile-bind-gen | ||
|
|
||
| # For interim development and package depolyment to test should be using pre release tags |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'depolyment' to 'deployment'.
| # For interim development and package depolyment to test should be using pre release tags | |
| # For interim development and package deployment to test should be using pre release tags |
| PV = "8.3.3.0" | ||
| PV = "8.4.1.0" | ||
|
|
||
| # PRs are prefered to be be incremented during development stages for any updates in corresponding |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'prefered' to 'preferred'.
| # PRs are prefered to be be incremented during development stages for any updates in corresponding | |
| # PRs are preferred to be be incremented during development stages for any updates in corresponding |
| PV = "8.3.3.0" | ||
| PV = "8.4.1.0" | ||
|
|
||
| # PRs are prefered to be be incremented during development stages for any updates in corresponding |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed duplicate word 'be be'.
| # PRs are prefered to be be incremented during development stages for any updates in corresponding | |
| # PRs are prefered to be incremented during development stages for any updates in corresponding |
| wlan-p2p \ | ||
| thunder-hang-recovery \ | ||
| thunder-plugin-activator \ | ||
| ${@bb.utils.contains('DISTRO_FEATURES', 'sceneset', " sceneset ", "", d)} \ |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sceneset conditional has unnecessary spaces around the package name. Consider using 'sceneset' instead of ' sceneset ' for consistency with other conditional package inclusions in the file.
| ${@bb.utils.contains('DISTRO_FEATURES', 'sceneset', " sceneset ", "", d)} \ | |
| ${@bb.utils.contains('DISTRO_FEATURES', 'sceneset', "sceneset", "", d)} \ |
| echo "" | ||
| echo "=== Validation Summary ===" | ||
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent spacing in validation output. The 'FAILED' output for PR Title has an extra leading space (' FAILED') compared to PR Description output ('FAILED'). This should be consistent.
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" | |
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458 Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
Rebase and merge
* Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc --------- Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
* Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-9558: Cleanup ripple calls in lifecyclemanager --------- Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-9849: Move memcapture to middleware layer
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC compliant and no longer depends on Thunder. Set initial versions of Firebolt C++ recipes. Risks: None Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec Signed-off-by: Tomasz Blaszczak <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| inherit packagegroup volatile-bind-gen | ||
|
|
||
| # For interim development and package depolyment to test should be using pre release tags |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word "depolyment" appears to be a misspelling of "deployment". This typo exists in a comment line that is adjacent to the changes but should be corrected.
| # For interim development and package depolyment to test should be using pre release tags | |
| # For interim development and package deployment to test should be using pre release tags |
Co-authored-by: ikavas409_comcast <[email protected]> Co-authored-by: madanagopalt <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc * Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-10493: copilot fix for static analysis issues --------- Co-authored-by: agampa263 <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-networkmanager-plugin = "1.0.0" | ||
| PV:pn-networkmanager-plugin = "v1.10.0" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string "v1.10.0" contains a "v" prefix which is inconsistent with the versioning convention used throughout this file. Consider using "1.10.0" instead to maintain consistency with other package versions in this configuration file.
| PV:pn-networkmanager-plugin = "v1.10.0" | |
| PV:pn-networkmanager-plugin = "1.10.0" |
Reason for change: move recipe information closer to developer’s repos Test Procedure: see Jira ticket Risks: Low Priority: P1 Signed-off-by: Mahmoud El-haron <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
…ic-support into RDKEMW_11604
Version: Major Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
|
I have read the CLA Document and I hereby sign the CLA 17 out of 18 committers have signed the CLA. |
RDKEMW-11560: Update middleware package group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
No description provided.