Skip to content

Conversation

@madanagopalt
Copy link
Contributor

No description provided.

@madanagopalt madanagopalt requested review from a team as code owners September 24, 2025 07:01
@CLAassistant
Copy link

CLAassistant commented Sep 24, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 21 committers have signed the CLA.

✅ ssitar583
✅ yuvaramachandran-gurusamy
✅ dkumar798
✅ AravindanNC
✅ plaksh002c-public
✅ klu339
✅ egalla204
❌ Adrian Muzyka
❌ nhanasi
❌ rosemarybennyy
❌ pkumbh631
❌ satlead
❌ rekhap2kandhavelan
❌ rdkcm-rdke
❌ satya200
❌ divyang-public
❌ sborushevsky
❌ preeja33
❌ anand-ky
❌ arun-madhavan-013
❌ tharun-kumarv


Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI review requested due to automatic review settings October 28, 2025 14:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR brings the latest changes by updating component versions, adding new packages, and introducing GitHub workflow automations. The changes primarily involve version bumps across multiple middleware components, adding support for new features like sceneset, and implementing CI/CD improvements.

  • Updated middleware layer package version from 8.3.3.0 to 8.3.4.0 with conditional sceneset integration
  • Upgraded 30+ component source and package revisions to their latest versions
  • Added three new GitHub workflow files for PR validation, Fossid scanning, and CLA management

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
recipes-core/packagegroups/packagegroup-middleware-layer.bb Bumped package version and added conditional sceneset dependency
conf/include/generic-srcrev.inc Updated source revisions for multiple components and added entries for xdial, sceneset, and packager-headers
conf/include/generic-pkgrev.inc Updated package versions for numerous middleware components and consolidated iarm-related package definitions
.github/workflows/validate_pr_desc.yml Added workflow to validate PR titles and descriptions contain approved ticket IDs
.github/workflows/fossid_integration_stateless_diffscan_target_repo.yml Added workflow for Fossid compliance scanning on pull requests
.github/workflows/cla.yml Added workflow for Contributor License Agreement management

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}"

PV:pn-xdial = "3.0.1"
PV:pn-xdial = "1.0.0"
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xdial package version appears to have been downgraded from '3.0.1' to '1.0.0'. This is likely unintentional given the PR's purpose of bringing latest changes. Verify if this downgrade is correct or if the version should be '3.0.1' or newer.

Suggested change
PV:pn-xdial = "1.0.0"
PV:pn-xdial = "3.0.1"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 28, 2025 16:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 29, 2025 19:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


inherit packagegroup volatile-bind-gen

# For interim development and package depolyment to test should be using pre release tags
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'depolyment' to 'deployment'.

Suggested change
# For interim development and package depolyment to test should be using pre release tags
# For interim development and package deployment to test should be using pre release tags

Copilot uses AI. Check for mistakes.
PV = "8.3.3.0"
PV = "8.4.1.0"

# PRs are prefered to be be incremented during development stages for any updates in corresponding
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'prefered' to 'preferred' and removed duplicate word 'be'.

Suggested change
# PRs are prefered to be be incremented during development stages for any updates in corresponding
# PRs are preferred to be incremented during development stages for any updates in corresponding

Copilot uses AI. Check for mistakes.
Comment on lines 111 to 112
PV:pn-iarm-set-powerstate = "${PV:pn-iarm-query-powerstate}"
PR:pn-iarm-set-powerstate = "${PR:pn-iarm-query-powerstate}"
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] These variable references create a dependency chain where iarm-set-powerstate, iarm-event-sender, key-simulator, and mfr-utils all derive their versions from iarm-query-powerstate. While this consolidation is good for maintainability, consider documenting this relationship more clearly in the comment at lines 105-106. The current comment only mentions that they use the same repo but doesn't explicitly state the version inheritance pattern.

Copilot uses AI. Check for mistakes.
echo ""
echo "=== Validation Summary ==="
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")"
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space before 'FAILED' in the PR Title output line, causing inconsistent formatting compared to the PR Description line. The space should be removed for consistent output alignment.

Suggested change
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")"
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 30, 2025 19:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

satlead and others added 8 commits October 31, 2025 03:23
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458

Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

---------

Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
Copilot AI review requested due to automatic review settings October 31, 2025 12:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

madanagopalt and others added 5 commits October 31, 2025 08:57
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-9558: Cleanup ripple calls in lifecyclemanager

---------

Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
Copilot AI review requested due to automatic review settings October 31, 2025 15:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

filipe-norte-red and others added 7 commits December 18, 2025 14:19
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC
compliant and no longer depends on Thunder.

Set initial versions of Firebolt C++ recipes.

Risks: None


Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec

Signed-off-by: Tomasz Blaszczak <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,81 @@
name: RDK-E Middleware Change Request
description: Change Request for RDK-E Middleware
title: "<JIRA TICKET>:<Ticket Title> "
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a trailing space after "Ticket Title" in the title template. This could lead to inconsistent PR titles with unnecessary whitespace. The title field should be:
title: "<JIRA TICKET>:<Ticket Title>"
instead of:
title: "<JIRA TICKET>:<Ticket Title> "

Suggested change
title: "<JIRA TICKET>:<Ticket Title> "
title: "<JIRA TICKET>:<Ticket Title>"

Copilot uses AI. Check for mistakes.
IshvarKR and others added 2 commits December 19, 2025 11:26
Co-authored-by: ikavas409_comcast <[email protected]>
Co-authored-by: madanagopalt <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-10493: copilot fix for static analysis issues

---------

Co-authored-by: agampa263 <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +6
name: PR Title Validation

on:
pull_request:
branches: [develop]
types: [opened, edited, synchronize]
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title "bring latest changes" does not follow the format required by the newly added PR title validation workflow. According to the validation rules being added in this PR (line 31-33 of validate_pr_title.yml), the title should match the pattern: TICKETID-number : description (e.g., "RDKEMW-123 : Fix playback issue"). This PR title will fail its own validation rules once merged.

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}"

PV:pn-xdial = "3.0.1"
PV:pn-xdial = "1.0.1"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package version for xdial is being downgraded from "3.0.1" to "1.0.1". Version downgrades are unusual and can cause issues with package management systems that expect monotonically increasing versions. Please verify this is intentional and not an error. If this is a deliberate change due to version scheme updates, consider documenting the rationale.

Suggested change
PV:pn-xdial = "1.0.1"
PV:pn-xdial = "3.0.2"

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}"

PV:pn-networkmanager-plugin = "1.3.0"
PV:pn-networkmanager-plugin = "v1.10.0"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version string for networkmanager-plugin now includes a "v" prefix ("v1.10.0" vs previous "1.3.0"). Inconsistent version string formatting across packages can cause issues. Most other packages in this file use version numbers without the "v" prefix. Consider removing the "v" prefix for consistency, unless it's required by the specific package's versioning scheme.

Suggested change
PV:pn-networkmanager-plugin = "v1.10.0"
PV:pn-networkmanager-plugin = "1.10.0"

Copilot uses AI. Check for mistakes.
melhar098 and others added 6 commits December 19, 2025 14:56
Reason for change: move recipe information closer to developer’s repos
Test Procedure: see Jira ticket
Risks: Low
Priority: P1

Signed-off-by: Mahmoud El-haron <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Version: Major
Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
Copilot AI review requested due to automatic review settings January 5, 2026 15:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

divyang-public and others added 2 commits January 5, 2026 17:53
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
@github-actions
Copy link

github-actions bot commented Jan 9, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


17 out of 18 committers have signed the CLA.
✅ (satlead)[https://github.com/satlead]
✅ (Vismalskumar0)[https://github.com/Vismalskumar0]
✅ (madanagopalt)[https://github.com/madanagopalt]
✅ (nhanasi)[https://github.com/nhanasi]
✅ (anand-ky)[https://github.com/anand-ky]
✅ (rdkcm-rdke)[https://github.com/rdkcm-rdke]
✅ (gurpreet319)[https://github.com/gurpreet319]
✅ (yuvaramachandran-gurusamy)[https://github.com/yuvaramachandran-gurusamy]
✅ (ks734)[https://github.com/ks734]
✅ (vjain008)[https://github.com/vjain008]
✅ (divyang-public)[https://github.com/divyang-public]
✅ (muthushiamsankar)[https://github.com/muthushiamsankar]
✅ (AravindanNC)[https://github.com/AravindanNC]
✅ (sindhu-krishnan)[https://github.com/sindhu-krishnan]
✅ (satya200)[https://github.com/satya200]
✅ (egalla204)[https://github.com/egalla204]
✅ (sborushevsky)[https://github.com/sborushevsky]
@rekhap2kandhavelan
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI review requested due to automatic review settings January 9, 2026 18:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.