Skip to content

Conversation

@madanagopalt
Copy link
Contributor

No description provided.

@madanagopalt madanagopalt requested review from a team as code owners September 25, 2025 04:50
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 21 committers have signed the CLA.

✅ ssitar583
✅ yuvaramachandran-gurusamy
✅ egalla204
✅ dkumar798
✅ klu339
✅ AravindanNC
✅ plaksh002c-public
❌ Adrian Muzyka
❌ pkumbh631
❌ rosemarybennyy
❌ satlead
❌ nhanasi
❌ rdkcm-rdke
❌ satya200
❌ anand-ky
❌ sborushevsky
❌ preeja33
❌ divyang-public
❌ rekhap2kandhavelan
❌ arun-madhavan-013
❌ tharun-kumarv


Adrian Muzyka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI review requested due to automatic review settings October 28, 2025 14:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR brings in the latest changes by updating package versions, source revisions, and adding new workflow files. The changes consolidate version management and introduce PR validation and scanning workflows.

Key changes:

  • Updates multiple package versions and source revisions across middleware components
  • Consolidates duplicate package version definitions to use shared references
  • Adds GitHub workflows for PR validation, FOSSID scanning, and CLA checking

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
recipes-core/packagegroups/packagegroup-middleware-layer.bb Bumps package version to 8.3.4.0 and adds conditional sceneset dependency
conf/include/generic-srcrev.inc Updates source revisions for 30+ components and adds new entries for xdial, sceneset, and packager-headers
conf/include/generic-pkgrev.inc Updates package versions across 30+ components and consolidates related packages to use shared version variables
.github/workflows/validate_pr_desc.yml Adds new workflow to validate PR titles and descriptions contain valid ticket IDs
.github/workflows/fossid_integration_stateless_diffscan_target_repo.yml Adds workflow for FOSSID license scanning on pull requests
.github/workflows/cla.yml Adds workflow for Contributor License Agreement validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

echo ""
echo "=== Validation Summary ==="
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")"
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space before 'FAILED' in the error output. Should be 'FAILED' not ' FAILED' to maintain consistent formatting with the PR Description line.

Suggested change
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")"
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 28, 2025 16:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


PV:pn-rdkfwupgrader = "1.3.0"
PV:pn-rdkfwupgrader = "1.3.2"
PR:pn-rdkfwupgrader = "r0"
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR for rdkfwupgrader has been reset to r0 after a version bump from 1.3.0 to 1.3.2. Consider whether the package release (PR) should remain at its previous value or be incremented rather than reset, as resetting to r0 typically indicates a new upstream version with no local modifications.

Suggested change
PR:pn-rdkfwupgrader = "r0"
PR:pn-rdkfwupgrader = "r1"

Copilot uses AI. Check for mistakes.
PV:pn-rbus = "2.6.0"
PR:pn-rbus = "r7"
PV:pn-rbus = "2.9.0"
PR:pn-rbus = "r0"
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package releases (PR) for rbus and rfc have been reset to r0 after version bumps. Previously rbus was at r7 and rfc was at r1. This reset pattern appears inconsistent with typical Yocto best practices where PR values should either increment or remain unchanged when PV increases, unless there's a deliberate policy to reset PRs on version changes.

Copilot uses AI. Check for mistakes.
PV:pn-rfc = "1.1.5"
PR:pn-rfc = "r1"
PV:pn-rfc = "1.1.7"
PR:pn-rfc = "r0"
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package releases (PR) for rbus and rfc have been reset to r0 after version bumps. Previously rbus was at r7 and rfc was at r1. This reset pattern appears inconsistent with typical Yocto best practices where PR values should either increment or remain unchanged when PV increases, unless there's a deliberate policy to reset PRs on version changes.

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}"

PV:pn-xdial = "3.0.1"
PV:pn-xdial = "1.0.0"
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xdial package version has been downgraded from 3.0.1 to 1.0.0, which appears to be a regression. Verify that this downgrade is intentional, as it may indicate a mistake or a significant change in versioning scheme that should be documented.

Suggested change
PV:pn-xdial = "1.0.0"
PV:pn-xdial = "3.0.1"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 29, 2025 19:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


inherit packagegroup volatile-bind-gen

# For interim development and package depolyment to test should be using pre release tags
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'depolyment' to 'deployment'.

Suggested change
# For interim development and package depolyment to test should be using pre release tags
# For interim development and package deployment to test should be using pre release tags

Copilot uses AI. Check for mistakes.
PV = "8.3.3.0"
PV = "8.4.1.0"

# PRs are prefered to be be incremented during development stages for any updates in corresponding
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'prefered' to 'preferred'.

Suggested change
# PRs are prefered to be be incremented during development stages for any updates in corresponding
# PRs are preferred to be be incremented during development stages for any updates in corresponding

Copilot uses AI. Check for mistakes.
PV = "8.3.3.0"
PV = "8.4.1.0"

# PRs are prefered to be be incremented during development stages for any updates in corresponding
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed duplicate word 'be' in comment.

Suggested change
# PRs are prefered to be be incremented during development stages for any updates in corresponding
# PRs are prefered to be incremented during development stages for any updates in corresponding

Copilot uses AI. Check for mistakes.
wlan-p2p \
thunder-hang-recovery \
thunder-plugin-activator \
${@bb.utils.contains('DISTRO_FEATURES', 'sceneset', " sceneset ", "", d)} \
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional sceneset inclusion has unnecessary leading and trailing spaces in the string ' sceneset '. Consider using 'sceneset' without extra spaces for cleaner formatting.

Suggested change
${@bb.utils.contains('DISTRO_FEATURES', 'sceneset', " sceneset ", "", d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'sceneset', "sceneset", "", d)} \

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 30, 2025 19:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

satlead and others added 8 commits October 31, 2025 03:23
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458

Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

---------

Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
Copilot AI review requested due to automatic review settings October 31, 2025 12:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

madanagopalt and others added 5 commits October 31, 2025 08:57
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-9558: Cleanup ripple calls in lifecyclemanager

---------

Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
Copilot AI review requested due to automatic review settings October 31, 2025 15:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

filipe-norte-red and others added 7 commits December 18, 2025 14:19
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC
compliant and no longer depends on Thunder.

Set initial versions of Firebolt C++ recipes.

Risks: None


Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec

Signed-off-by: Tomasz Blaszczak <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 179 to 181
PV:pn-systimemgrinetrface = "1.4.0"
PR:pn-systimemgrinetrface = "r0"
PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment contains a typo. The word "inetrface" should be spelled "interface". This typo appears in the package name itself (pn-systimemgrinetrface), which suggests this is a systemic naming issue rather than just a comment typo.

Suggested change
PV:pn-systimemgrinetrface = "1.4.0"
PR:pn-systimemgrinetrface = "r0"
PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}"
PV:pn-systimemgrinterface = "1.4.0"
PR:pn-systimemgrinterface = "r0"
PACKAGE_ARCH:pn-systimemgrinterface = "${MIDDLEWARE_ARCH}"

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-rdksysctl = "${MIDDLEWARE_ARCH}"

PV:pn-xdial = "3.0.1"
PV:pn-xdial = "1.0.1"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version format is inconsistent with other entries in this file. All other package version assignments use the format PV:pn-xdial = "3.0.1" (with quotes around the version), but this line uses PV:pn-xdial = "1.0.1". While the format itself is correct, the version change from "3.0.1" to "1.0.1" appears to be a downgrade rather than an upgrade, which is unusual for a "bring latest changes" PR.

Suggested change
PV:pn-xdial = "1.0.1"
PV:pn-xdial = "3.0.1"

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}"

PV:pn-networkmanager-plugin = "1.4.0"
PV:pn-networkmanager-plugin = "v1.10.0"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version format includes a 'v' prefix which is inconsistent with the version format used for the same package in line 275. In line 275, the version is "1.0.1" without a 'v' prefix, but here it's "v1.10.0" with a 'v' prefix. This inconsistency in version formatting could cause issues with version comparison or package management.

Suggested change
PV:pn-networkmanager-plugin = "v1.10.0"
PV:pn-networkmanager-plugin = "1.10.0"

Copilot uses AI. Check for mistakes.
IshvarKR and others added 2 commits December 19, 2025 11:26
Co-authored-by: ikavas409_comcast <[email protected]>
Co-authored-by: madanagopalt <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-10493: copilot fix for static analysis issues

---------

Co-authored-by: agampa263 <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PV:pn-mfr-utils = "${PV:pn-iarm-query-powerstate}"
PR:pn-mfr-utils = "${PR:pn-iarm-query-powerstate}"
PACKAGE_ARCH:pn-mfr-utils = "${MIDDLEWARE_ARCH}"

Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several lines removed in this section (previously lines for lsof and jquery) that are not being replaced or documented in the changelog. The removal of package version definitions without explanation could lead to build failures if these packages are still required elsewhere. Please verify that removing these package definitions is intentional and won't break any dependencies.

Suggested change
# NOTE:
# Package version definitions for 'lsof' and 'jquery' previously existed
# in this section but have been intentionally removed because the
# corresponding packages/recipes are no longer built or referenced in
# this configuration. Their removal is not expected to affect any
# remaining dependencies.

Copilot uses AI. Check for mistakes.
Comment on lines +87 to +89
echo "Ticket ID found in PR title."
echo ""
echo "ALL VALIDATIONS PASSED! PR title contains a valid ticket ID."
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title "bring latest changes" is not descriptive and does not follow the expected format shown in the validation workflow. According to the new validate_pr_title.yml workflow being added in this PR, PR titles should follow the format: <TICKETID>-<ticketno.> : <description> with valid ticket IDs being RDKEMW, RDKEVD, IMMUI, or RDK.

This PR title should be updated to include a proper ticket reference and meaningful description of the changes being made.

Suggested change
echo "Ticket ID found in PR title."
echo ""
echo "ALL VALIDATIONS PASSED! PR title contains a valid ticket ID."
echo "Ticket ID found in PR title: \"$PR_TITLE\""
echo ""
echo "ALL VALIDATIONS PASSED! PR title matches the expected format '<TICKETID>-<ticketno.> : <description>' and contains a valid ticket ID (RDKEMW, RDKEVD, IMMUI, or RDK)."

Copilot uses AI. Check for mistakes.
PV:pn-sysint = "3.0.5"
PR:pn-sysint = "r0"
PV:pn-sysint = "4.2.0"
PR:pn-sysint = "r3"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sysint package version has been changed from "3.0.5" to "4.2.0" and the PR value from "r0" to "r3". This represents a major version bump and suggests significant changes. However, there's an inconsistency: typically when PV changes, PR should reset to "r0" unless there are multiple releases of the same version. Please verify that PR="r3" is intentional for version 4.2.0.

Suggested change
PR:pn-sysint = "r3"
PR:pn-sysint = "r0"

Copilot uses AI. Check for mistakes.

PV:pn-iarm-query-powerstate = "1.0.6"
# All of these iarm-query-powerstate, iarm-set-powerstate, iarm-event-sender,
# key-simulator and mfr-utils use sys_mon_tools repo.
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new comment block has been added (lines 105-106) explaining that multiple packages share the same repository. While this is helpful documentation, there's a typo: "mfr-utils" appears in the comment but the actual variable name pattern in line 107 is "iarm-query-powerstate". The comment should accurately reflect all the package names that use this shared configuration pattern for clarity.

Suggested change
# key-simulator and mfr-utils use sys_mon_tools repo.
# and key-simulator use sys_mon_tools repo.

Copilot uses AI. Check for mistakes.
- develop
- support/dunfell
- 'support/*.*.*'
- 'support/*.*.*.*'
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow file has been updated to remove "support/dunfell" as a specific branch and add a new pattern "support/..." for four-part version numbers. However, this creates a potential issue: the pattern "support/.." could match "support/1.2.3" while "support/...*" would match "support/1.2.3.4". If there's a need to support both three-part and four-part version numbers, this is correct. However, if this change is meant to replace the three-part pattern, line 8 should be removed to avoid ambiguity.

Copilot uses AI. Check for mistakes.

inherit packagegroup volatile-bind-gen

# For interim development and package depolyment to test should be using pre release tags
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number has been updated from "8.3.3.0" to "8.4.2.1", which appears to be a significant version jump. However, there's a typo in the comment on line 11: "depolyment" should be "deployment". This typo already exists in the unchanged code but is visible in the context.

Suggested change
# For interim development and package depolyment to test should be using pre release tags
# For interim development and package deployment to test should be using pre release tags

Copilot uses AI. Check for mistakes.
melhar098 and others added 6 commits December 19, 2025 14:56
Reason for change: move recipe information closer to developer’s repos
Test Procedure: see Jira ticket
Risks: Low
Priority: P1

Signed-off-by: Mahmoud El-haron <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Version: Major
Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
Copilot AI review requested due to automatic review settings January 5, 2026 15:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

divyang-public and others added 2 commits January 5, 2026 17:53
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
@github-actions
Copy link

github-actions bot commented Jan 9, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


17 out of 18 committers have signed the CLA.
✅ (satlead)[https://github.com/satlead]
✅ (Vismalskumar0)[https://github.com/Vismalskumar0]
✅ (madanagopalt)[https://github.com/madanagopalt]
✅ (nhanasi)[https://github.com/nhanasi]
✅ (anand-ky)[https://github.com/anand-ky]
✅ (rdkcm-rdke)[https://github.com/rdkcm-rdke]
✅ (gurpreet319)[https://github.com/gurpreet319]
✅ (yuvaramachandran-gurusamy)[https://github.com/yuvaramachandran-gurusamy]
✅ (ks734)[https://github.com/ks734]
✅ (vjain008)[https://github.com/vjain008]
✅ (divyang-public)[https://github.com/divyang-public]
✅ (muthushiamsankar)[https://github.com/muthushiamsankar]
✅ (AravindanNC)[https://github.com/AravindanNC]
✅ (sindhu-krishnan)[https://github.com/sindhu-krishnan]
✅ (satya200)[https://github.com/satya200]
✅ (egalla204)[https://github.com/egalla204]
✅ (sborushevsky)[https://github.com/sborushevsky]
@rekhap2kandhavelan
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI review requested due to automatic review settings January 9, 2026 18:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.