bring latest changes #2015
bring latest changes #2015
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates source revision hashes and package versions for three components in the build configuration files.
- Updated SRCREV hashes for
subttxrend-appandentservices-infrato point to newer commits - Bumped package versions for
entservices-casting(1.2.8 → 1.2.12),entservices-infra(3.0.0 → 3.1.0), andsubttxrend-app(1.4.0 → 1.5.0)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| conf/include/generic-srcrev.inc | Updated SRCREV commit hashes for subttxrend-app and entservices-infra packages |
| conf/include/generic-pkgrev.inc | Incremented package versions (PV) for entservices-casting, entservices-infra, and subttxrend-app |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| inherit packagegroup volatile-bind-gen | ||
|
|
||
| # For interim development and package depolyment to test should be using pre release tags |
There was a problem hiding this comment.
Corrected spelling of 'depolyment' to 'deployment'.
| # For interim development and package depolyment to test should be using pre release tags | |
| # For interim development and package deployment to test should be using pre release tags |
| PV = "8.3.4.0" | ||
| PV = "8.4.1.0" | ||
|
|
||
| # PRs are prefered to be be incremented during development stages for any updates in corresponding |
There was a problem hiding this comment.
Corrected spelling of 'prefered' to 'preferred'. Also note there is a duplicate word 'be be' that should be 'to be'.
| # PRs are prefered to be be incremented during development stages for any updates in corresponding | |
| # PRs are preferred to be incremented during development stages for any updates in corresponding |
Change-Id: I7e3bb29e11db4f44ccacec25e2c06c3284dabfea
…ic-support into topic/RDKEMW-9458 Change-Id: Ic73851602e0a3fb3899ffa71de81d53afa4ca502
Rebase and merge
* Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc --------- Co-authored-by: Vismal S Kumar <[email protected]>
RDKEMW-9667: Update generic-pkgrev.inc
* Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-9558: Cleanup ripple calls in lifecyclemanager --------- Co-authored-by: Anand Kandasamy <[email protected]>
RDKEMW-9530: download manager service updates
RDKEMW-9849: Move memcapture to middleware layer
Change-Id: I9b37875bd79398b270e619248a284727d0c41fde
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-networkmanager-plugin = "1.4.0" | ||
| PV:pn-networkmanager-plugin = "v1.10.0" |
There was a problem hiding this comment.
The version format for pn-networkmanager-plugin uses "v1.10.0" (with a 'v' prefix), while most other package versions in this file use semantic versioning without the 'v' prefix (e.g., "1.4.0", "2.9.0", etc.). For consistency, consider using "1.10.0" instead of "v1.10.0" unless there's a specific reason for the prefix.
| PV:pn-networkmanager-plugin = "v1.10.0" | |
| PV:pn-networkmanager-plugin = "1.10.0" |
| - develop | ||
| - support/dunfell | ||
| - 'support/*.*.*' | ||
| - 'support/*.*.*.*' |
There was a problem hiding this comment.
The branch pattern 'support/dunfell' has been removed while a new pattern 'support/...' (four-part version) has been added. Please verify that removing 'support/dunfell' is intentional and won't break existing automation for that branch. If the dunfell support branch is still active, it may need to be explicitly included or covered by one of the wildcard patterns.
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC compliant and no longer depends on Thunder. Set initial versions of Firebolt C++ recipes. Risks: None Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec Signed-off-by: Tomasz Blaszczak <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PV:pn-systimemgrinetrface = "1.4.0" | ||
| PR:pn-systimemgrinetrface = "r0" | ||
| PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}" |
There was a problem hiding this comment.
Spelling error in package name: "systimemgrinetrface" should be "systimemgrinterface". This appears to be a typo in the package name that could cause issues if the actual package name is different.
| PV:pn-systimemgrinetrface = "1.4.0" | |
| PR:pn-systimemgrinetrface = "r0" | |
| PACKAGE_ARCH:pn-systimemgrinetrface = "${MIDDLEWARE_ARCH}" | |
| PV:pn-systimemgrinterface = "1.4.0" | |
| PR:pn-systimemgrinterface = "r0" | |
| PACKAGE_ARCH:pn-systimemgrinterface = "${MIDDLEWARE_ARCH}" |
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-networkmanager-plugin = "1.4.0" | ||
| PV:pn-networkmanager-plugin = "v1.10.0" |
There was a problem hiding this comment.
Inconsistent version format: The version is specified as "v1.10.0" with a 'v' prefix, while all other package versions in this file use numeric format without prefix (e.g., "1.0.0", "2.9.0"). This inconsistency could cause issues with version comparisons or package management. Consider removing the 'v' prefix to match the standard format used throughout the file.
| PV:pn-networkmanager-plugin = "v1.10.0" | |
| PV:pn-networkmanager-plugin = "1.10.0" |
Co-authored-by: ikavas409_comcast <[email protected]> Co-authored-by: madanagopalt <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc * Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-10493: copilot fix for static analysis issues --------- Co-authored-by: agampa263 <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PV:pn-firebolt-cpp-transport = "0.2.0" | ||
| PR:pn-firebolt-cpp-transport = "r0" | ||
| PACKAGE_ARCH:pn-firebolt-cpp-transport = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-firebolt-cpp-client = "0.2.0" | ||
| PR:pn-firebolt-cpp-client = "r0" | ||
| PACKAGE_ARCH:pn-firebolt-cpp-client = "${MIDDLEWARE_ARCH}" |
There was a problem hiding this comment.
New package version entries for firebolt-cpp-transport and firebolt-cpp-client have been added, but there are no corresponding SRCREV entries in generic-srcrev.inc. If these packages use source repositories, they should have SRCREV definitions to specify which commit to use. Please verify if SRCREV entries are needed or if these packages use a different source mechanism.
| - RDKEMW-9716: Update generic-pkgrev.inc [`#2091`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/2091) | ||
| - RDKEMW-9716: Reboot Causes Standby Instead of ON [`#2082`](https://github.com/rdkcentral/meta-middleware-generic-support/pull/2082) |
There was a problem hiding this comment.
There are duplicate entries for RDKEMW-9716. Line 30 references PR #2091 with description "Update generic-pkgrev.inc" and line 31 references PR #2082 with description "Reboot Causes Standby Instead of ON". This appears to be an error in the changelog generation or merging. Please verify which entry is correct or if both should be listed with distinct descriptions.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-networkmanager-plugin = "1.4.0" | ||
| PV:pn-networkmanager-plugin = "v1.10.0" |
There was a problem hiding this comment.
The version for pn-networkmanager-plugin uses a "v" prefix (v1.10.0), which is inconsistent with the versioning format used by other packages in this file that use numeric versions without the "v" prefix. Consider using "1.10.0" instead of "v1.10.0" for consistency.
| PV:pn-networkmanager-plugin = "v1.10.0" | |
| PV:pn-networkmanager-plugin = "1.10.0" |
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-gdb = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-sceneset = "1.0.0" | ||
| PV:pn-sceneset = "0.1.0" |
There was a problem hiding this comment.
The version for pn-sceneset appears to be downgraded from "1.0.0" to "0.1.0". If this is intentional, it should be clearly documented in the commit message or PR description. Version downgrades are unusual and can indicate an error. Please verify this change is correct.
| PV:pn-sceneset = "0.1.0" | |
| PV:pn-sceneset = "1.0.0" |
Reason for change: move recipe information closer to developer’s repos Test Procedure: see Jira ticket Risks: Low Priority: P1 Signed-off-by: Mahmoud El-haron <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
…ic-support into RDKEMW_11604
Version: Major Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
RDKEMW-11560: Update middleware package group
20 participants
No description provided.