Skip to content

Conversation

@balasaraswathy-n
Copy link
Contributor

Rebasing

@balasaraswathy-n balasaraswathy-n requested a review from a team as a code owner December 10, 2025 05:57
Copilot AI review requested due to automatic review settings December 10, 2025 05:57
@balasaraswathy-n balasaraswathy-n requested a review from a team as a code owner December 10, 2025 05:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a rebase operation that integrates changes from another branch, including version updates for two middleware packages (ctrlm-main and xr-voice-sdk) and updates the overall package group version. The changes maintain consistency across source revision files, package version files, and the changelog.

Key changes:

  • Updated ctrlm-main to version 1.1.7 with new SRCREV
  • Updated xr-voice-sdk to version 1.0.8 with new SRCREV
  • Bumped middleware layer package version from 8.4.2.0 to 8.4.2.1

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
recipes-core/packagegroups/packagegroup-middleware-layer.bb Updated package group version from 8.4.2.0 to 8.4.2.1
conf/include/generic-srcrev.inc Updated source revisions for ctrlm-main and xr-voice-sdk to new commit hashes
conf/include/generic-pkgrev.inc Bumped package versions for ctrlm-main (1.1.6→1.1.7) and xr-voice-sdk (1.0.7→1.0.8)
CHANGELOG.md Added comprehensive changelog entries for versions 1.13.1, 1.13.0, 1.12.3, and 1.8.10 with pull request references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

madanagopalt and others added 7 commits December 10, 2025 11:54
Reason for change: need to address coding guidelines in TTS
Test Procedure: Mentioned in ticket
Risks: Low

Signed-off-by: kumar <[email protected]>
Reason for change: need to address coding guidelines in TTS
Test Procedure: Mentioned in ticket
Risks: Low

Signed-off-by: kumar <[email protected]>
)

* RDKEMW-10658: AAMP Federated Release for Sprint 2511 : Tag 2.11.0

Signed-off-by: psiva01 <[email protected]>

* Update SRCREV for aamp to new commit hash

* Update SRCREV

* Update SRCREV for aamp to a final commit hash

---------

Signed-off-by: psiva01 <[email protected]>
Co-authored-by: narenr94 <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 10, 2025 14:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}"

PV:pn-networkmanager-plugin = "1.9.0"
PV:pn-networkmanager-plugin = "v1.10.0"
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version format "v1.10.0" is inconsistent with other package versions in this file, which use numeric-only format (e.g., "1.9.0", "1.7.3"). The "v" prefix should be removed to maintain consistency.

Suggested change
PV:pn-networkmanager-plugin = "v1.10.0"
PV:pn-networkmanager-plugin = "1.10.0"

Copilot uses AI. Check for mistakes.
PV:pn-rtcore = "1.0.1"
PR:pn-rtcore = "r2"
PACKAGE_ARCH:pn-rtcore = "${MIDDLEWARE_ARCH}"

Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version update from "1.0.10" to "2.0.1" represents a major version bump, which typically indicates breaking changes. However, there's no documentation or comment explaining what breaking changes were introduced. Consider adding a comment to explain the rationale for this major version change.

Suggested change
# Major version bump for rdknativescript (1.x → 2.x) to reflect API-breaking changes;
# see the rdknativescript 2.x release notes/changelog for detailed migration info.

Copilot uses AI. Check for mistakes.
filipe-norte-red and others added 7 commits December 18, 2025 14:19
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC
compliant and no longer depends on Thunder.

Set initial versions of Firebolt C++ recipes.

Risks: None


Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec

Signed-off-by: Tomasz Blaszczak <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PACKAGE_ARCH:pn-rtcore = "${MIDDLEWARE_ARCH}"

PV:pn-rdknativescript = "1.0.10"
PV:pn-rdknativescript = "2.0.1"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version format is inconsistent. This package version changes from "1.0.10" to "2.0.1", which represents a major version bump. However, this appears to be part of a rebase operation with many incremental updates to other packages. Consider verifying that this major version jump is intentional and correctly reflects the package's breaking changes or significant new features.

Suggested change
PV:pn-rdknativescript = "2.0.1"
PV:pn-rdknativescript = "1.0.11"

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}"

PV:pn-networkmanager-plugin = "1.9.0"
PV:pn-networkmanager-plugin = "v1.10.0"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version prefix is inconsistent with other packages in this file. This is the only package version prefixed with "v" (v1.10.0), while all other package versions use plain numeric versions without the "v" prefix. This should be changed to "1.10.0" for consistency.

Suggested change
PV:pn-networkmanager-plugin = "v1.10.0"
PV:pn-networkmanager-plugin = "1.10.0"

Copilot uses AI. Check for mistakes.
PACKAGE_ARCH:pn-gdb = "${MIDDLEWARE_ARCH}"

PV:pn-sceneset = "1.0.0"
PV:pn-sceneset = "0.1.0"
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version appears to have decreased from "1.0.0" to "0.1.0", which represents a backward version change. This is unusual in a rebase operation and could cause issues with package management systems that expect monotonically increasing version numbers. Verify this version downgrade is intentional.

Suggested change
PV:pn-sceneset = "0.1.0"
PV:pn-sceneset = "1.0.0"

Copilot uses AI. Check for mistakes.
IshvarKR and others added 2 commits December 19, 2025 11:26
Co-authored-by: ikavas409_comcast <[email protected]>
Co-authored-by: madanagopalt <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* Update generic-srcrev.inc

* Update generic-pkgrev.inc

* RDKEMW-10493: copilot fix for static analysis issues

---------

Co-authored-by: agampa263 <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Copilot AI review requested due to automatic review settings December 19, 2025 16:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

melhar098 and others added 6 commits December 19, 2025 14:56
Reason for change: move recipe information closer to developer’s repos
Test Procedure: see Jira ticket
Risks: Low
Priority: P1

Signed-off-by: Mahmoud El-haron <[email protected]>
Co-authored-by: Anand Kandasamy <[email protected]>
Version: Major
Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
Copilot AI review requested due to automatic review settings January 5, 2026 15:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

divyang-public and others added 4 commits January 5, 2026 17:53
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
RDKEMW-11560: Update middleware package group
Copilot AI review requested due to automatic review settings January 9, 2026 18:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.