-
Notifications
You must be signed in to change notification settings - Fork 16
rebasing #2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/RDKEMW-9147_autorev
Are you sure you want to change the base?
rebasing #2400
Conversation
Reason for change: resolving guidelines errors Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: kumar <[email protected]>
…tpatch Release Signed-off-by: Divyang Abhay Sarangi <[email protected]>
RDKEMW-11158: Rebase with develop
RDKEMW-11158: Rebase with 'develop'
RDKEMW-11158: Rebase with 'develop'
RDKEMW-11158: Backmerge Release branch to develop for MW 8.4.2.1 Q4 Release
… v1.0.8 (#2341) Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs a rebase operation that integrates changes from another branch, including version updates for two middleware packages (ctrlm-main and xr-voice-sdk) and updates the overall package group version. The changes maintain consistency across source revision files, package version files, and the changelog.
Key changes:
- Updated ctrlm-main to version 1.1.7 with new SRCREV
- Updated xr-voice-sdk to version 1.0.8 with new SRCREV
- Bumped middleware layer package version from 8.4.2.0 to 8.4.2.1
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Updated package group version from 8.4.2.0 to 8.4.2.1 |
| conf/include/generic-srcrev.inc | Updated source revisions for ctrlm-main and xr-voice-sdk to new commit hashes |
| conf/include/generic-pkgrev.inc | Bumped package versions for ctrlm-main (1.1.6→1.1.7) and xr-voice-sdk (1.0.7→1.0.8) |
| CHANGELOG.md | Added comprehensive changelog entries for versions 1.13.1, 1.13.0, 1.12.3, and 1.8.10 with pull request references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: need to address coding guidelines in TTS Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: kumar <[email protected]>
Reason for change: need to address coding guidelines in TTS Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: kumar <[email protected]>
) * RDKEMW-10658: AAMP Federated Release for Sprint 2511 : Tag 2.11.0 Signed-off-by: psiva01 <[email protected]> * Update SRCREV for aamp to new commit hash * Update SRCREV * Update SRCREV for aamp to a final commit hash --------- Signed-off-by: psiva01 <[email protected]> Co-authored-by: narenr94 <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-networkmanager-plugin = "1.9.0" | ||
| PV:pn-networkmanager-plugin = "v1.10.0" |
Copilot
AI
Dec 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version format "v1.10.0" is inconsistent with other package versions in this file, which use numeric-only format (e.g., "1.9.0", "1.7.3"). The "v" prefix should be removed to maintain consistency.
| PV:pn-networkmanager-plugin = "v1.10.0" | |
| PV:pn-networkmanager-plugin = "1.10.0" |
conf/include/generic-pkgrev.inc
Outdated
| PV:pn-rtcore = "1.0.1" | ||
| PR:pn-rtcore = "r2" | ||
| PACKAGE_ARCH:pn-rtcore = "${MIDDLEWARE_ARCH}" | ||
|
|
Copilot
AI
Dec 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version update from "1.0.10" to "2.0.1" represents a major version bump, which typically indicates breaking changes. However, there's no documentation or comment explaining what breaking changes were introduced. Consider adding a comment to explain the rationale for this major version change.
| # Major version bump for rdknativescript (1.x → 2.x) to reflect API-breaking changes; | |
| # see the rdknativescript 2.x release notes/changelog for detailed migration info. |
RDKEMW-10715: Add RDKAT-ATSPI2 unit tests and bug fixes
Reason for change: Update Firebolt C++ to a version that is JSON-RPC compliant and no longer depends on Thunder. Set initial versions of Firebolt C++ recipes. Risks: None Change-Id: I724a08afd7ebfb5bee1e4b5c82bbd256495858ec Signed-off-by: Tomasz Blaszczak <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-rtcore = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-rdknativescript = "1.0.10" | ||
| PV:pn-rdknativescript = "2.0.1" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version format is inconsistent. This package version changes from "1.0.10" to "2.0.1", which represents a major version bump. However, this appears to be part of a rebase operation with many incremental updates to other packages. Consider verifying that this major version jump is intentional and correctly reflects the package's breaking changes or significant new features.
| PV:pn-rdknativescript = "2.0.1" | |
| PV:pn-rdknativescript = "1.0.11" |
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-memcr = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-networkmanager-plugin = "1.9.0" | ||
| PV:pn-networkmanager-plugin = "v1.10.0" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version prefix is inconsistent with other packages in this file. This is the only package version prefixed with "v" (v1.10.0), while all other package versions use plain numeric versions without the "v" prefix. This should be changed to "1.10.0" for consistency.
| PV:pn-networkmanager-plugin = "v1.10.0" | |
| PV:pn-networkmanager-plugin = "1.10.0" |
conf/include/generic-pkgrev.inc
Outdated
| PACKAGE_ARCH:pn-gdb = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PV:pn-sceneset = "1.0.0" | ||
| PV:pn-sceneset = "0.1.0" |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version appears to have decreased from "1.0.0" to "0.1.0", which represents a backward version change. This is unusual in a rebase operation and could cause issues with package management systems that expect monotonically increasing version numbers. Verify this version downgrade is intentional.
| PV:pn-sceneset = "0.1.0" | |
| PV:pn-sceneset = "1.0.0" |
Co-authored-by: ikavas409_comcast <[email protected]> Co-authored-by: madanagopalt <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
* Update generic-srcrev.inc * Update generic-pkgrev.inc * Update generic-srcrev.inc * Update generic-pkgrev.inc * RDKEMW-10493: copilot fix for static analysis issues --------- Co-authored-by: agampa263 <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: move recipe information closer to developer’s repos Test Procedure: see Jira ticket Risks: Low Priority: P1 Signed-off-by: Mahmoud El-haron <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
…ic-support into RDKEMW_11604
Version: Major Change-Id: I73f5a40e4c699035a6abb679666c301c0203a1e3
RDKEMW-11604: Migrate Develop branch from entservices-infra/rdkservcies-cpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
RDKEMW-11621: Rebase with develop
RDKEMW-11621: Backmerge Release branch into Develop for MW 8.4.4.0 Release
RDKEMW-11560: Update middleware package group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Rebasing