RDKEMW-18711: VG is not working in Xione Dhruv build#6467
Conversation
…k host Reason for change: - TTS OOP plugin /etc/WPEFramework/config.json fallback read "port" and "binding" as Core::JSON::String - Core::JSON::String::Value() returns the quoted form for JSON string fields, so "binding":"0.0.0.0" yields an endpoint of "0.0.0.0":9998 (literal quotes) which Core::NodeId cannot parse - An OOP child connects back to main on the same host; the listen binding is not the right connect target. Read port as DecUInt32 and use loopback. Test Procedure: described in the ticket Implements: code changes in TextToSpeech/impl Risks: Low Source: COMCAST License: Apache-2.0 Upstream-Status: Pending Version: patch Signed-off-by: Sergiy Gladkyy <sgladkyy@productengine.com>
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the TextToSpeech implementation derives the Thunder RPC endpoint (THUNDER_ACCESS) when falling back to /etc/WPEFramework/config.json, to avoid quoted-string parsing issues and to ensure OOP children connect via loopback.
Changes:
- Read
portfrom/etc/WPEFramework/config.jsonas a JSON number (Core::JSON::DecUInt32) instead of a JSON string. - Construct the endpoint using loopback (
127.0.0.1:<port>) instead of using the listen binding address.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Core::JSON::DecUInt32 port = config.Get("port"); | ||
| if(port.Value() != 0) | ||
| endpoint = std::string("127.0.0.1:") + std::to_string(port.Value()); |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
Closing in favor of an equivalent patch against rdkcentral/entservices-mediaanddrm — that's the actual source-of-truth for the TextToSpeech plugin shipped in RDK-E develop builds (recipe entservices-mediaanddrm.bb in meta-rdk-video pins it as SRCREV). This rdkservices repo is the RDK-V line; the same SatToken JSON-parse bug exists here too but is not on the path for the Dhruv VG regression on RDKEMW-18711. Reopening or filing a separate RDK-V backport later if needed. |
Read THUNDER_ACCESS port as JSON number and use loopback host
Reason for change:
Test Procedure: described in the ticket
Implements: code changes in TextToSpeech/impl
Risks: Low
Source: COMCAST
License: Apache-2.0
Upstream-Status: Pending
Version: patch