Skip to content

RDK-56115 - Fix coverity issues in RRD [High] #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

RDK-56115 - Fix coverity issues in RRD [High] #103

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
caef256
Update rrdJsonParser.c
Abhinavpv28 Mar 22, 2025
de33ccd
Update rrdJsonParser.c
Abhinavpv28 Mar 22, 2025
5c5df60
Update rrdIarmEvents.c
Abhinavpv28 Mar 22, 2025
f4bee32
Update rrdEventProcess.c
Abhinavpv28 Mar 22, 2025
01dea55
Update rrdEventProcess.c
Abhinavpv28 Mar 22, 2025
3220112
Update rrdJsonParser.c
Abhinavpv28 Mar 22, 2025
0f38b12
Update rrdIarmEvents.c
Abhinavpv28 Mar 22, 2025
6877f92
Update rrdJsonParser.c
Abhinavpv28 Mar 22, 2025
281e010
Update rrdEventProcess.c
Abhinavpv28 Mar 22, 2025
373fda2
Update rrdEventProcess.c
Abhinavpv28 Mar 22, 2025
9bf72ae
Update rrdEventProcess.c
Abhinavpv28 Mar 22, 2025
192a36f
Update rrdEventProcess.c
Abhinavpv28 Mar 22, 2025
0f07e25
Update rrdEventProcess.c
Abhinavpv28 Mar 22, 2025
567078e
Merge pull request #111 from rdkcentral/develop
Abhinavpv28 Apr 15, 2025
ccef609
Update rrdJsonParser.c
Abhinavpv28 Apr 15, 2025
70f0ba5
Update rrdIarmEvents.c
Abhinavpv28 Apr 15, 2025
8c62735
Update rrdEventProcess.c
Abhinavpv28 Apr 15, 2025
5d611c3
Update rrdEventProcess.c
Abhinavpv28 Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/rrdEventProcess.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ void processIssueTypeEvent(data_buf *rbuf)
}

RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: ...Exiting...\n", __FUNCTION__, __LINE__);
return;
return; // CID 336987: Resource leak (RESOURCE_LEAK)
}

/*
Expand Down Expand Up @@ -296,13 +296,22 @@ static void processIssueTypeInStaticProfile(data_buf *rbuf, issueNodeData *pIssu
if (isStaticIssue)
{
// Issue in Static Profile JSON
RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: Issue Data Node: %s and Sub-Node: %s found in Static JSON File %s... \n", __FUNCTION__, __LINE__, pIssueNode->Node, pIssueNode->subNode, RRD_JSON_FILE);
checkIssueNodeInfo(pIssueNode, jsonParsed, rbuf, false, NULL); // sanity Check and Get Command List
if ( pIssueNode->Node && pIssueNode->subNode ) // CID 336981: Use after free (USE_AFTER_FREE), CID 336980:Use after free (USE_AFTER_FREE)
{
RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: Issue Data Node: %s and Sub-Node: %s found in Static JSON File %s... \n", __FUNCTION__, __LINE__, pIssueNode->Node, pIssueNode->subNode, RRD_JSON_FILE);
if( rbuf ) // CID 336984: Double free (USE_AFTER_FREE)
{
checkIssueNodeInfo(pIssueNode, jsonParsed, rbuf, false, NULL); // sanity Check and Get Command List
}
}
}
else
{
RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d] Issue Data Not found in Static JSON File... \n", __FUNCTION__, __LINE__);
processIssueTypeInInstalledPackage(rbuf, pIssueNode);
if ( pIssueNode->Node && pIssueNode->subNode ) // CID 336980: Double free (USE_AFTER_FREE), CID 336980:Use after free (USE_AFTER_FREE)
{
processIssueTypeInInstalledPackage(rbuf, pIssueNode);
}
}

freeParsedJson(jsonParsed);
Expand Down
Loading