[DELIA-68036] RRD failing in device for some commands, getting invalid message type (SCXI11BEI) #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shibu-kv
requested changes
May 12, 2025
| @@ -326,14 +326,15 @@ void _remoteDebuggerEventHandler(rbusHandle_t handle, rbusEvent_t const* event, | |||
| return; | |||
| } | |||
|
|
|||
| int len = strlen(rbusValue_GetString(value, NULL)); | |||
| int len = strlen(rbusValue_GetString(value, NULL))+1; | |||
There was a problem hiding this comment.
Can you please cross check rbusValue_GetString definition.
I believe it already allocates and returns you a buffer . If that is the case the lines till 337 might be redundant . Also we might be having memleak in case allocated but is not released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: RRD failing in device for some commands, getting invalid message type (SCXI11BEI)
Test Procedure: Focussed regression on remote debugger static profile
Risks: Low
Signed-off-by: Abhinav P V [email protected]