rebase

.github/workflows/L1-Test.yml

@@ -2,7 +2,7 @@ name: L1 Unit Tests Remote Debugger
 
 on:
   pull_request:
-    branches: [ develop, main, feature/RDK-49894 ]
+    branches: [ develop ]
 
 env:
   AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME }}

.github/workflows/L2-tests.yml

@@ -1,7 +1,7 @@
 name: L2 Integration Tests
 
 on:
-  workflow_dispatch:
+  pull_request:
     branches: [ develop ]
 
 env:
@@ -14,15 +14,34 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v2
+      - name: Checkout code rfc code
+        uses: actions/checkout@v4
+        with:
+          path: remote_debugger
+
+      - name: Check out dependent repostiories
+        uses: actions/checkout@v4
+        with:
+          repository: 'rdkcentral/rfc'
+          path: rfc
 
-      - name: Log in to GitHub Container Registry
-        uses: docker/login-action@v2
+      - name: Check out dependent repostiories
+        uses: actions/checkout@v4
+        with:
+          repository: 'rdkcentral/iarmmgrs'
+          path: iarmmgrs
+
+      - name: Check out dependent repostiories
+        uses: actions/checkout@v4
         with:
-          registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
+          repository: 'rdkcentral/iarmbus'
+          path: iarmbus
+
+      - name: Check out dependent repostiories
+        uses: actions/checkout@v4
+        with:
+          repository: 'rdkcentral/tr69hostif'
+          path: tr69hostif
 
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v1
@@ -32,15 +51,24 @@ jobs:
           docker pull ghcr.io/rdkcentral/docker-device-mgt-service-test/mockxconf:latest
           docker pull ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest
           docker pull ghcr.io/rdkcentral/docker-rdk-ci:latest
+
       - name: Start mock-xconf service
         run: |
-          docker run -d --name mockxconf -p 50050:50050 -p 50051:50051 -p 50052:50052 -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/mockxconf:latest
+          docker run -d --name mockxconf -p 50050:50050 -p 50051:50051 -p 50052:50052 -p 50054:50054 -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/mockxconf:latest
+
       - name: Start l2-container service
         run: |
           docker run -d --name native-platform --link mockxconf -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest
+
+
+      - name: Move dependent repositories in native-platform container to /usr
+        run: |
+          docker exec -i native-platform /bin/bash -c "rm -rf /usr/rfc && mv /mnt/L2_CONTAINER_SHARED_VOLUME/rfc /usr/ && mv /mnt/L2_CONTAINER_SHARED_VOLUME/iarmmgrs /usr/ && rm -rf /usr/iarmbus && mv /mnt/L2_CONTAINER_SHARED_VOLUME/iarmbus /usr/ && mv /mnt/L2_CONTAINER_SHARED_VOLUME/tr69hostif /usr/"
+
       - name: Enter Inside Platform native container and run L2 Test
         run: |
-          docker exec -i native-platform /bin/bash -c "cd /mnt/L2_CONTAINER_SHARED_VOLUME/ && sh cov_build.sh && export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/lib/x86_64-linux-gnu:/lib/aarch64-linux-gnu:/usr/local/lib: && find / -name downloadUtil.h && ls -l && sh run_l2.sh" 
+          docker exec -i native-platform /bin/bash -c "cd /mnt/L2_CONTAINER_SHARED_VOLUME/remote_debugger && sh cov_build.sh && export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/lib/x86_64-linux-gnu:/lib/aarch64-linux-gnu:/usr/local/lib: && find / -name downloadUtil.h && ls -l && sh run_l2.sh" 
+
       - name: Copy l2 test results to runner 
         run: |
           docker cp native-platform:/tmp/l2_test_report /tmp/L2_TEST_RESULTS
@@ -59,4 +87,4 @@ jobs:
         if: github.repository_owner == 'rdkcentral'
         run: |
           docker cp /tmp/L2_TEST_RESULTS ci-container:/tmp/L2_TEST_RESULTS
-          docker exec -i ci-container bash -c "echo 'Contents in workspace directory' && ls -l && echo '===============================' && echo 'Contents in /tmp/L2_TEST_RESULTS' && ls -l /tmp/L2_TEST_RESULTS && echo '===============================' && git config --global --add safe.directory /mnt/L2_CONTAINER_SHARED_VOLUME && gtest-json-result-push.py /tmp/L2_TEST_RESULTS https://rdkeorchestrationservice.apps.cloud.comcast.net/rdke_orchestration_api/push_unit_test_results /mnt/L2_CONTAINER_SHARED_VOLUME"
+          docker exec -i ci-container bash -c "echo 'Contents in workspace directory' && ls -l && echo '===============================' && echo 'Contents in /tmp/L2_TEST_RESULTS' && ls -l /tmp/L2_TEST_RESULTS && echo '===============================' && git config --global --add safe.directory /mnt/L2_CONTAINER_SHARED_VOLUME/remote_debugger && gtest-json-result-push.py /tmp/L2_TEST_RESULTS https://rdkeorchestrationservice.apps.cloud.comcast.net/rdke_orchestration_api/push_unit_test_results /mnt/L2_CONTAINER_SHARED_VOLUME/remote_debugger"

.github/workflows/code-coverage.yml

@@ -0,0 +1,54 @@
+name: Code Coverage
+
+on:
+  pull_request:
+    branches: [ main ]
+
+jobs:
+  execute-unit-code-coverage-report-on-release:
+    name: Test coverage report for release
+    runs-on: ubuntu-latest
+    container:
+      image: ghcr.io/rdkcentral/docker-rdk-ci:latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Run unit tests with coverage flags enabled
+        run: |
+          sh run_ut.sh --enable-cov
+      - name: Caculate the code coverage summary
+        run: |
+          cd ./src/unittest
+          lcov --list coverage.info | grep "Lines\|Total" > /tmp/coverage_summary.txt
+          cd -
+
+      - name: Update the coverage report to Pull request using actions
+        uses: actions/github-script@v4
+        with:
+          script: |
+            const fs = require('fs');
+            const lcov_result = fs.readFileSync('/tmp/coverage_summary.txt', 'utf8'); 
+
+            github.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: 
+                    '## Code Coverage Summary \n' +
+                    ' ' +
+                    '```' +
+                    lcov_result + 
+                    '```'
+            });
+      - name: Generate the html report
+        run: |
+          cd ./src/unittest
+          genhtml coverage.info --output-directory /tmp/coverage_report
+          cd -
+      - name: Upload the coverage report to Pull request using actions
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage-report
+          path: /tmp/coverage_report

.github/workflows/native_full_build.yml

@@ -3,7 +3,7 @@ name: Build Component in Native Environment
 on:
   pull_request:
     branches: [ develop  ]
-    paths: ['**/*.c', '**/*.cpp', '**/*.cc', '**/*.cxx', '**/*.h', '**/*.hpp']
+    paths: ['**/*.c', '**/*.cpp', '**/*.cc', '**/*.cxx', '**/*.h', '**/*.hpp', '**/*.sh' ]
 
 jobs:
   build-systemtimemgr-on-pr:
@@ -15,8 +15,41 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
+        with:
+          path: remote_debugger
+
+      - name: Checkout code rfc code
+        uses: actions/checkout@v4
+        with:
+          path: remote_debugger
+
+      - name: Check out dependent repostiories
+        uses: actions/checkout@v4
+        with:
+          repository: 'rdkcentral/rfc'
+          path: rfc
+
+      - name: Check out dependent repostiories
+        uses: actions/checkout@v4
+        with:
+          repository: 'rdkcentral/iarmmgrs'
+          path: iarmmgrs
+
+      - name: Check out dependent repostiories
+        uses: actions/checkout@v4
+        with:
+          repository: 'rdkcentral/iarmbus'
+          path: iarmbus
+
+      - name: Check out dependent repostiories
+        uses: actions/checkout@v4
+        with:
+          repository: 'rdkcentral/tr69hostif'
+          path: tr69hostif
+
 
       - name: native build
         run: |
+          cd remote_debugger
           chmod +x cov_build.sh
           sh -e cov_build.sh

CHANGELOG.md

@@ -4,9 +4,72 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+#### [1.2.6](https://github.com/rdkcentral/remote_debugger/compare/1.2.5...1.2.6)
+
+- Feature/rdk 56115 coverity [`#108`](https://github.com/rdkcentral/remote_debugger/pull/108)
+- [RDKE] L2 Tests And Integration With CI for Remote Debugger Dynamic Updates [`#98`](https://github.com/rdkcentral/remote_debugger/pull/98)
+- RDKECMF-219 Enable component build workflow on Pull Request and remove unnecessary token [`#70`](https://github.com/rdkcentral/remote_debugger/pull/70)
+- RDK-56451 [RDKE] Move tr69hostif L2 binary into common docker repo [`#104`](https://github.com/rdkcentral/remote_debugger/pull/104)
+- RDK-56115 : [RDKE] Fix coverity issues in RRD [`6edfc37`](https://github.com/rdkcentral/remote_debugger/commit/6edfc376fbd899e2992ed2c26cdeb86351c925aa)
+- RDK-56115 : Coverity fix [`4955236`](https://github.com/rdkcentral/remote_debugger/commit/49552366c6ff0d59024e3a449e3a52868a4222de)
+- RDK-56115 : Coverity fix [`8f37f99`](https://github.com/rdkcentral/remote_debugger/commit/8f37f9936ec865d68eb05eb6f0137888cbdb627d)
+
+#### [1.2.5](https://github.com/rdkcentral/remote_debugger/compare/1.2.4...1.2.5)
+
+> 27 March 2025
+
+- RDK-55702: Update the MW clients to use Power Manager Plugin [`#100`](https://github.com/rdkcentral/remote_debugger/pull/100)
+- RDKEMW-1768 -Fix UT in RRD with Static profile update and Null Check [`#102`](https://github.com/rdkcentral/remote_debugger/pull/102)
+- RDKECMF-219 Remove redundant variable [`#96`](https://github.com/rdkcentral/remote_debugger/pull/96)
+- RDKB-58835-[Productisation] Enable RRD Dynamic Profile for RDKB platforms [`#88`](https://github.com/rdkcentral/remote_debugger/pull/88)
+- 1.2.5 release changelog updates [`8c49b9c`](https://github.com/rdkcentral/remote_debugger/commit/8c49b9cd05f4c16c5ea2dea79963a2b81b697d6a)
+- Merge tag '1.2.4' into develop [`9c234d3`](https://github.com/rdkcentral/remote_debugger/commit/9c234d33e7649424a503259411c749e024e8d986)
+
+#### [1.2.4](https://github.com/rdkcentral/remote_debugger/compare/1.2.3...1.2.4)
+
+> 6 March 2025
+
+- RDKB-58835  : [Productisation] Enable RRD Dynamic Profile for RDKB platforms [`#83`](https://github.com/rdkcentral/remote_debugger/pull/83)
+- 1.2.4 release changelog updates [`d167642`](https://github.com/rdkcentral/remote_debugger/commit/d167642d7f037c2255d94e2e2ed36f2151defef3)
+
+#### [1.2.3](https://github.com/rdkcentral/remote_debugger/compare/1.2.2...1.2.3)
+
+> 26 February 2025
+
+- Remote Debugger 1.2.3 [`#80`](https://github.com/rdkcentral/remote_debugger/pull/80)
+- DELIA-67277: Use the updated msg_unpack_next() for handling webconfig data  [`#74`](https://github.com/rdkcentral/remote_debugger/pull/74)
+- Rebase [`#64`](https://github.com/rdkcentral/remote_debugger/pull/64)
+- rebase [`#57`](https://github.com/rdkcentral/remote_debugger/pull/57)
+- RDKE-263:[OSCR Scan] RDKE - remote_debugger repo [`#44`](https://github.com/rdkcentral/remote_debugger/pull/44)
+-    RDK-56099: Pytest L2 Implementation Code Changes [`#42`](https://github.com/rdkcentral/remote_debugger/pull/42)
+- RDK-56099: Pytest L2 Implementation Code Changes [`#39`](https://github.com/rdkcentral/remote_debugger/pull/39)
+- Revert "rebase (#54)" [`#55`](https://github.com/rdkcentral/remote_debugger/pull/55)
+- rebase [`#54`](https://github.com/rdkcentral/remote_debugger/pull/54)
+- Revert "RDKB-58634: Replace tr181 set with rbus set for rdm download request" [`25f13a7`](https://github.com/rdkcentral/remote_debugger/commit/25f13a75102d0a68b7bb7c40d0ecc84a6e9de993)
+- RDKB-58634: Replace tr181 set with rbus set for rdm download request [`17eb94d`](https://github.com/rdkcentral/remote_debugger/commit/17eb94df5fddaf253cd9a216be8eebc0116dbe0b)
+- RDK-56099: Pre-clone dependent repositories [`205e931`](https://github.com/rdkcentral/remote_debugger/commit/205e93195e5c7513116eb13b79248030ceeaaf5a)
+
+#### [1.2.2](https://github.com/rdkcentral/remote_debugger/compare/1.2.1...1.2.2)
+
+> 21 February 2025
+
+- Update cov_build.sh [`#65`](https://github.com/rdkcentral/remote_debugger/pull/65)
+- RDKEMW-1768: Add code-coverage workflow with release [`#60`](https://github.com/rdkcentral/remote_debugger/pull/60)
+- RDK-56099: Pytest L2 Implementation Code Changes [`#53`](https://github.com/rdkcentral/remote_debugger/pull/53)
+- RDK-56099: Enable L2 test workflows with PR [`#49`](https://github.com/rdkcentral/remote_debugger/pull/49)
+- RDKE-263:[OSCR Scan] RDKE - remote_debugger repo [`#44`](https://github.com/rdkcentral/remote_debugger/pull/44)
+-    RDK-56099: Pytest L2 Implementation Code Changes [`#42`](https://github.com/rdkcentral/remote_debugger/pull/42)
+- RDK-56099: Pytest L2 Implementation Code Changes [`#39`](https://github.com/rdkcentral/remote_debugger/pull/39)
+- RDK-56099: Pre-clone dependent repositories [`d3a7b30`](https://github.com/rdkcentral/remote_debugger/commit/d3a7b3099cec688061e8612fd679a5dcb902c45a)
+- Create code-coverage.yml [`4e9a0c1`](https://github.com/rdkcentral/remote_debugger/commit/4e9a0c16d2e787a791e43b4f796d237b5300aab2)
+- Create uploadSTBLogs.sh [`2d0db19`](https://github.com/rdkcentral/remote_debugger/commit/2d0db196b033d27bb0e3f63364c90ea0cbc17111)
+
 #### [1.2.1](https://github.com/rdkcentral/remote_debugger/compare/1.2.0...1.2.1)
 
+> 31 January 2025
+
 - DELIA-67372: RRD- dynamic command is not appending commands to [`#30`](https://github.com/rdkcentral/remote_debugger/pull/30)
+- Release 1.2.1 changelog updates [`e185df0`](https://github.com/rdkcentral/remote_debugger/commit/e185df0ce81094e4563c94435af95d01641c9670)
 
 #### [1.2.0](https://github.com/rdkcentral/remote_debugger/compare/1.1.0...1.2.0)
 

cov_build.sh

@@ -1,11 +1,49 @@
+##########################################################################
+# If not stated otherwise in this file or this component's LICENSE
+# file the following copyright and licenses apply:
+#
+# Copyright 2018 RDK Management
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+##########################################################################
+
 WORKDIR=`pwd`
 # Build and install critical dependency
 export ROOT=/usr
-export INSTALL_DIR=${ROOT}/local
+export INSTALL_DIR=/usr/local
 mkdir -p $INSTALL_DIR
-#Build rfc
+
+
+# Build tr181api from rfc source code
 cd ${ROOT}
-git clone https://github.com/rdkcentral/rfc.git
+
+# Clone all dependencies if not present already
+if [ ! -d rfc ]; then
+    git clone https://github.com/rdkcentral/rfc.git
+fi
+
+if [ ! -d iarmmgrs ]; then
+    git clone https://github.com/rdkcentral/iarmmgrs.git
+fi
+
+if [ ! -d iarmbus ]; then
+    git clone https://github.com/rdkcentral/iarmbus.git
+fi
+
+if [ ! -d tr69hostif ]; then
+    git clone https://github.com/rdkcentral/tr69hostif.git
+fi
+
 cd rfc
 autoreconf -i
 ./configure --enable-rfctool=yes --enable-tr181set=yes
@@ -16,18 +54,20 @@ cd /usr/rfc/tr181api
 g++ -fPIC -shared -o libtr181api.so tr181api.cpp -I/usr/local/include/wdmp-c
 mv ./libtr181api.so /usr/local/lib
 cp ./tr181api.h /usr/local/include
+
+# Install header files alone from armmgrs repositories
 cd $ROOT
-rm -rf iarmmgrs
-rm -rf iarmbus
-git clone https://github.com/rdkcentral/iarmmgrs.git
+
 cp /usr/iarmmgrs/rdmmgr/include/rdmMgr.h /usr/local/include
-git clone https://github.com/rdkcentral/iarmbus.git
+
+# Install header files alone from iarmbus repositories
 cp /usr/iarmbus/core/include/libIBusDaemon.h /usr/local/include
 cp /usr/iarmbus/core/include/libIBus.h /usr/local/include
 cp /usr/iarmbus/core/libIARMCore.h /usr/local/include
 cp /usr/iarmmgrs/hal/include/pwrMgr.h /usr/local/include/
 
-git clone https://github.com/rdkcentral/tr69hostif.git
+# Build and install stubs from tr69hostif
+
 cd tr69hostif
 cd ./src/unittest/stubs
 g++ -fPIC -shared -o libIARMBus.so iarm_stubs.cpp  -I/usr/tr69hostif/src/hostif/parodusClient/pal -I/usr/tr69hostif/src/unittest/stubs -I/usr/tr69hostif/src/hostif/parodusClient/waldb -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/tr69hostif/src/hostif/include -I/usr/tr69hostif/src/hostif/profiles/DeviceInfo -I/usr/tr69hostif/src/hostif/parodusClient/pal -fpermissive
@@ -39,5 +79,5 @@ cd $WORKDIR
 autoreconf -i
 autoupdate
 ./configure --prefix=${INSTALL_DIR} --enable-iarmbusSupport=yes
-make remotedebugger_CFLAGS="-I/usr/include/cjson -I/usr/local/include/wdmp-c -I/usr/local/include/rbus -I/usr/local/include -I/usr/local/include/trower-base64" remotedebugger_LDFLAGS="-L/usr/local/lib -lrdkloggers -lcjson -lrfcapi -lrbus -lmsgpackc -lsecure_wrapper -lwebconfig_framework -lIARMBus -ltr181api  -L/usr/local/lib/x86_64-linux-gnu -ltrower-base64 -L/usr/lib/x86_64-linux-gnu"
+make remotedebugger_CFLAGS="-I/usr/include/cjson -I/usr/local/include/wdmp-c -I/usr/local/include/rbus -I/usr/local/include -I/usr/local/include/trower-base64 -DIARMBUS_SUPPORT" remotedebugger_LDFLAGS="-L/usr/local/lib -lrdkloggers -lcjson -lrfcapi -lrbus -lmsgpackc -lsecure_wrapper -lwebconfig_framework -lIARMBus -ltr181api  -L/usr/local/lib/x86_64-linux-gnu -ltrower-base64 -L/usr/lib/x86_64-linux-gnu"
 make install