Added xdial Parse authorised domains #2 #104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margret-jaison-infosys
force-pushed
the
Xdial-Parse-authorized-domains
branch
from
ddc972e to
48b8c73
Compare
|
Internal ticket created for tracking https://ccp.sys.comcast.net/browse/RDKCOM-4663 |
|
Please bring the changes to 24Q2_sprint branch. |
|
Migrated Changes to 24Q2 : #108 |
|
@viveksinghnarwaria do i need to do anything for this pull request |
Please close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The xdial app list is initially populated from the command line. This commit replaces the naive parsing implementation, which adds the allowed origins based on hardcoded values with implementation, which honors the passed origins.