Fix for using Facebooks SSL certificate. (Fixed cURL problem)#17
Open
antila wants to merge 1 commit intordohms:masterfrom
antila:master
Open
Fix for using Facebooks SSL certificate. (Fixed cURL problem)#17antila wants to merge 1 commit intordohms:masterfrom antila:master
antila wants to merge 1 commit intordohms:masterfrom
antila:master
Conversation
…g on Windows that causes cURL to fail due to not having a certificate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed a bug where the cURL call would fail due to not having the Facebook SSL certificate.
I added support for cURL to make the requests with the certificate (if the certificate file is present) and give instructions to the user on how to get the certificate, instead of showing a general cURL error.
Maybe you can just include the certificate file in the source? That would make it even more easier for the user.