Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Clean and modularize InvoiceService payment processing #39

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Refactor: Clean and modularize InvoiceService payment processing #39

wants to merge 5 commits into from

Conversation

Jabin0214
Copy link

Summary

  • Refactored ProcessPayment method for clarity and maintainability.
  • Extracted private methods:
    • HandleZeroAmountInvoice
    • HandleSubsequentPayments
    • HandleFirstPayment
    • ApplyPayment
  • Reduced code duplication and improved readability.

Notes

  • All existing unit tests remain unchanged and pass successfully.
  • Ready for review.

@Jabin0214 Jabin0214 marked this pull request as draft March 11, 2025 04:23
@Jabin0214 Jabin0214 marked this pull request as ready for review March 11, 2025 04:23
@Jabin0214
Copy link
Author

@re-leased-hiring Please review my refactoring task. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jabin0214